Ethereal-cvs: [ethereal-cvs] cvs commit: ethereal packet-cops.c packet-ddtp.c packet-gre.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Gilbert Ramirez Jr." <gram@xxxxxxxxxxxx>
Date: Wed, 14 Jun 2000 22:48:58 -0500 (CDT)
gram        2000/06/14 22:48:55 CDT

  Modified files:
    .                    packet-cops.c packet-ddtp.c packet-gre.c 
                         packet-ipx.c packet-ipx.h packet-isl.c 
                         packet-l2tp.c packet-mip.c packet-ppp.c 
                         packet-syslog.c packet-vlan.c 
                         packet-x11.c proto.c proto.h tvbuff.h 
  Log:
  Convert IPX-and-friend dissectors in packet-ipx.c to use
  tvbuffs.
  
  In doing so, I realied that my recommendation for using
  tvb_new_subset(pi.compat_top_tvb, -1, -1) was incorrect, because
  some dissectors (ethernet!) change pi.len and pi.cap_len. So, I have
  to take those two variables into account instead of using -1 and -1.
  
  So, I provide a macro called tvb_create_from_top(offset), where
  offset is the name of your offset variable. It is a wrapper around
  tvb_new_subset().
  
  I converted the lines that followed my suggestion to use
  tvb_create_from_top().
  
  In proto.c I added
  proto_tree_add_debug_text(proto_tree*, const char*, ...)
  It's much like proto_tree_add_text(), except that it takes no offset
  or length; it's soley for temporarily putting debug text into the
  proto_tree while debugging a dissector. In making sure that its
  use is temporary, the funciton also prints the debug string to stdout
  to remind the programmer that the debug code needs to be removed
  before shipping the code.
  
  Revision  Changes    Path
  1.2       +3 -4      ethereal/packet-cops.c
  1.8       +2 -3      ethereal/packet-ddtp.c
  1.23      +2 -2      ethereal/packet-gre.c
  1.62      +253 -208  ethereal/packet-ipx.c
  1.8       +2 -2      ethereal/packet-ipx.h
  1.13      +4 -4      ethereal/packet-isl.c
  1.13      +2 -2      ethereal/packet-l2tp.c
  1.5       +2 -2      ethereal/packet-mip.c
  1.37      +2 -2      ethereal/packet-ppp.c
  1.3       +3 -4      ethereal/packet-syslog.c
  1.17      +2 -2      ethereal/packet-vlan.c
  1.7       +3 -2      ethereal/packet-x11.c
  1.69      +27 -4     ethereal/proto.c
  1.35      +12 -1     ethereal/proto.h
  1.5       +5 -1      ethereal/tvbuff.h