Ethereal-cvs: [ethereal-cvs] cvs commit: ethereal packet-rpc.c conversation.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Sun, 14 Nov 1999 15:17:03 -0600 (CST)
guy         1999/11/14 15:17:01 CST

  Modified files:
    .                    packet-rpc.c conversation.c 
  Log:
  For ONC RPC, when constructing conversations, use a null address as the
  destination address for calls and the source address of the reply - we
  should't require the server address to be the same for a call and reply,
  as they may not be on a multi-homed server (clients presumably check the
  XID only, or perhaps the XID and the port whence the reply came,
  although with TI-RPC I don't think they can check the port without
  checking the address as well).
  
  This requires that the conversation code not assume that the source and
  destination addresses for a given packet in a conversation have the same
  type, so, when comparing addresses for equality, it must explicitly
  check the address types.
  
  In said code, also check the port numbers before we check the addresses
  - testing ports is cheaper, as they're just integers, and there's
  probably a decent chance that you won't see two conversations between
  different pairs of hosts and the *same* pair of ports in a capture file,
  so the cheaper port tests are probably decently likely to fail first.
  
  Revision  Changes    Path
  1.11      +24 -7     ethereal/packet-rpc.c
  1.5       +22 -25    ethereal/conversation.c