Ethereal-cvs: [ethereal-cvs] cvs commit: ethereal ethereal.c file.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Gilbert Ramirez Jr." <gram@xxxxxxxxxxxx>
Date: Sun, 15 Aug 1999 02:28:29 -0500 (CDT)
gram        1999/08/15 02:28:27 CDT

  Modified files:
    .                    ethereal.c file.c 
  Log:
  Fixed the problem with an assert coming from gtkwidget.c:3196 when
  selecting a field from more than one protocol tree. It turns out that
  gtktree.c doesn't clear the tree-item selection list when you use
  gtk_tree_clear_items() (which calls gtk_tree_remove_items() ). So the next
  time a tree item is selected in a new protocol tree (which is our old
  protocol tree, with everything removed, and new things added), gtk_tree
  tries to _deselect_ our old selection. But that tree-item which is trying
  to be deselected is long gone, resulting in the assert because widget == NULL.
  A function needs to be added to gtk_tree to deselect the tree-item selection
  for us. (or we need to go through the hassle of creating a new gtk_tree
  instead of recycling tree_view over and over).
  
  I stole some code from another section of gtktree.c which lets us clear
  the selection in clear_tree_and_hex_views().
  
  Also, I modified the argument to gtk_tree_set_view_mode. We were using
  "TRUE", when really we should have used a member of the GtkTreeViewMode
  enumeration, namely GTK_TREE_VIEW_ITEM ( which is 1, which is TRUE :-)
  
  Revision  Changes    Path
  1.89      +6 -4      ethereal/ethereal.c
  1.72      +22 -4     ethereal/file.c