Wireshark-dev: Re: [Wireshark-dev] FT_BYTES hf with len==0
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Martin Kaiser <lists@xxxxxxxxx>
Date: Fri, 20 Dec 2013 14:18:00 +0100
Thus wrote Martin Kaiser (lists@xxxxxxxxx):

> Thus wrote Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

> > proto_item_fill_label() allows empty bytes:

> > 5389     case FT_BYTES:
> > 5390     case FT_UINT_BYTES:
> > 5391             bytes = (guint8 *)fvalue_get(&fi->value);
> > 5392             label_fill(label_str, 0, hfinfo,
> > 5393                             (bytes) ? bytes_to_str(bytes, fvalue_length(&fi->value)) : "<MISSING>");
> > 5394             break;

> > It'd be good to make them consistent, allow empty bytes (+1 from me) or assert in both place.

> ok, I'll change this.

done in r54290.