Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 38028: /trunk/epan/dissectors/ /trun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Sake Blok <sake@xxxxxxxxxx>
Date: Fri, 15 Jul 2011 11:09:45 +0200
On 15 jul 2011, at 02:34, Maynard, Chris wrote:

>> Log:
>> If the first 8 bytes of the icmp echo/echo-reply data look like a
>> timestamp, dissect it as a timestmap and calculate the time since the icmp
>> packet was created.
>> 
> 
> Sake, now that you've dug into timestamps for ICMP echo/echo-reply data, maybe you might have some thoughts about how to improve the last patch I submitted to bug 5770 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5770)?  I'm sure the patch will no longer apply cleanly now, but hopefully you can get a feel for what I was trying to do.  If you really want, I can resubmit a patch that will apply cleanly to the trunk.

Nice idea, but that won't really work well, see my response in the bug-report...

Cheers,
Sake