Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Date: Thu, 21 Apr 2011 16:33:15 +0200


2011/4/21 Stig Bjørlykke <stig@xxxxxxxxxxxxx>
On Thu, Apr 21, 2011 at 3:32 PM,  <alagoutte@xxxxxxxxxxxxx> wrote:
>  Fix Dead Store (Dead nested assignment) Warning found by Clang

-                                       msg_type = tvb_get_ntohs(tvb, (tmp_idx+=2));
+                                       msg_type = tvb_get_ntohs(tvb, tmp_idx);

Are you sure this is correct?  What about "tmp_idx+2"?

Oups !
Fix in Rev  36768