Wireshark-dev: [Wireshark-dev] Eliminate annoying color filter dialog
From: Chris Maynard <chris.maynard@xxxxxxxxx>
Date: Tue, 8 Mar 2011 20:02:19 +0000 (UTC)
I regularly switch between a custom build of Wireshark for analyzing my
company's protocols and the trunk when doing general Wireshark
development/testing.  Unfortunately, I have lots of custom color filters in
place that are invalid for the trunk for obvious reasons.  But every time I
switch to the trunk, for every custom color filter I have, I get an annoying
dialog telling me, "Could not compile color filter "blah" from saved filters." 
I've made a change in my local sandbox to avoid this, but would anyone have any
grumblings if I permanently eliminate that dialog?  Here's all I do to get rid
of it:

Index: color_filters.c
===================================================================
--- color_filters.c     (revision 36170)
+++ color_filters.c     (working copy)
@@ -573,9 +573,11 @@
                        dfilter_t *temp_dfilter;

                        if (!dfilter_compile(filter_exp, &temp_dfilter)) {
+#if 0 /* This is too annoying when switching back/forth from custom builds */
                                simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK,
                                "Could not compile color filter %s from saved
filters.\n%s",
                                              name, dfilter_error_msg);
+#endif
                                skip_end_of_line = TRUE;
                                continue;
                        }