Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 35292: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

[Gerald Combs <gerald@xxxxxxxxxxxxx>]

64 bytes is a little on the small side but I thought it would be better
to err on the side of paranoia. If if you want to switch it back that's OK.

On 12/28/10 1:47 PM, Martin Mathieson wrote:
> Thanks for fixing the check on the loop.
> But why the ep_allocate() ?  64 bytes isn't much - they could be static
> in case MAX_RAR_PDUs ever increased.  I don't mind that much...
> 
> Martin
> 
> On Tue, Dec 28, 2010 at 8:47 PM, <gerald@xxxxxxxxxxxxx
> <mailto:gerald@xxxxxxxxxxxxx>> wrote:
> 
>     http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35292
>     <http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35292>
> 
>     User: gerald
>     Date: 2010/12/28 12:47 PM
> 
>     Log:
>      From non-customers via bug 5530: Fix a buffer overflow in the MAC LTE
>      dissector.  From me: Add a define, ep_allocate the buffer.
> 
>     Directory: /trunk/epan/dissectors/
>      Changes    Path                Action
>      +3 -2      packet-mac-lte.c    Modified
> 
>     ___________________________________________________________________________
>     Sent via:    Wireshark-commits mailing list
>     <wireshark-commits@xxxxxxxxxxxxx
>     <mailto:wireshark-commits@xxxxxxxxxxxxx>>
>     Archives:    http://www.wireshark.org/lists/wireshark-commits
>     Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>                 mailto:wireshark-commits-request@xxxxxxxxxxxxx
>     <mailto:wireshark-commits-request@xxxxxxxxxxxxx>?subject=unsubscribe
> 
> 
> 
> 
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe