Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 23128:/trunk/asn1/h225/ /trunk/asn1/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 10 Oct 2007 11:40:48 +0200
On Wed, Oct 10, 2007 at 11:30:46AM +0200, Kukosa, Tomas wrote:
> > Thanks! Is there a reason why you modified M.am and M.nmake instead of
> > M.inc and M.inc.nmake in asn1/ ? That way I'll only need to change the
> > M.common files.
> 
> The reason is that MAKE_CNF_EXPORT has to be defined before M.common is
> included.
> It is why I suggest to think about M.preinc and M.preinc.nmake
> introducing an put MAKE_CNF_EXPORT into them.
...
> What do you think about this solution?

Looks good!

  ciao
     Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.