Wireshark · Wireshark-dev: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars

["Stefan (metze) Metzmacher" <metze@xxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

if isprint() is used, we should make sure the value
isn't larger than 0xFF, as currently GDK_Up and GDK_Down
trigger a focus switch to the filter.

can someone apply this?

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFFZVSBm70gjA5TCD8RAqpOAKC3NEJQsXwCEeGjKqkLAg1RYaZhmgCgnEpb
OS1s0ECtxhXnuomoz2/HrpM=
=bibu
-----END PGP SIGNATURE-----

Index: gtk/main.c
===================================================================
--- gtk/main.c	(Revision 19957)
+++ gtk/main.c	(Arbeitskopie)
@@ -3802,7 +3802,7 @@
     } else if (event->keyval == GDK_F7) {
 	packet_list_prev();
 	return TRUE;
-    } else if (isprint(event->keyval)) {
+    } else if (!(event->keyval & 0xFF00) && isprint(event->keyval)) {
 	/* Forward the keypress on to the display filter entry */
 	if (main_display_filter_widget && !gtk_widget_is_focus(main_display_filter_widget)) {
 	    gtk_window_set_focus(GTK_WINDOW(top_level), main_display_filter_widget);

Attachment: up-down-fix-01.diff.sig
Description: PGP signature