Wireshark-commits: [Wireshark-commits] master-3.0 2013384: NSIS: Add ERROR_PRODUCT_VERSION to the v
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 15 Feb 2019 12:53:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20133841766f629b014916907929fc208b850842
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

2013384 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    NSIS: Add ERROR_PRODUCT_VERSION to the vcredist checks.
    
    If the Visual C++ Redistributable installer returns 1638
    (ERROR_PRODUCT_VERSION) treat it as a success.
    
    Bug: 15509
    Change-Id: I136704ddc3266abc1a79f0fdcdd0b6cb7e33266e
    Reviewed-on: https://code.wireshark.org/review/32041
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 4bcad12279aab875bb9f871e7dd984a43bebe86e)
    Reviewed-on: https://code.wireshark.org/review/32043
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  0abfc10   macOS: Try to work around .dmg packaging issues.
     add  2013384   NSIS: Add ERROR_PRODUCT_VERSION to the vcredist checks.


Summary of changes:
 packaging/nsis/wireshark.nsi | 2 ++
 1 file changed, 2 insertions(+)