Wireshark-commits: [Wireshark-commits] master b503613: Add macros for the pack_flags field.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Feb 2019 18:43:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5036134c27b55e26dec584a8cc7a9ac844b136c
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b503613 by Guy Harris (guy@xxxxxxxxxxxx):

    Add macros for the pack_flags field.
    
    Add macros to extract the direction, reception type, and FCS length
    fields of the pack_flags field, and add definitions for different
    directions and reception types.
    
    Add a macro to construct a pack_flags field value from subfields; this
    is for use by non-pcapng file readers (the pack_flags field is just a
    copy of the EPB flags option, so that's not needed for pcapng).
    
    Move some #defines for that field from packet-frame.c to wtap.h, and
    rename them to match the new macros.
    
    Use the macros rather than rolling our own code.
    
    Fix a variable name in text2pcap.c that apparently had the wrong name,
    given the value that was being tested.
    
    Change-Id: Ia788ca4e9f5fabd8d24e6ead5ff1817509f54827
    Reviewed-on: https://code.wireshark.org/review/32010
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bf4fe34   LTE RRC: add dissection of NR RSRP/RSRQ/SINR fields
     add  b503613   Add macros for the pack_flags field.


Summary of changes:
 epan/dissectors/packet-frame.c | 85 ++++++++++++++++++++++--------------------
 text2pcap.c                    | 42 ++++++++++-----------
 ui/text_import.c               |  8 ++--
 wiretap/pcapng.c               |  4 +-
 wiretap/wtap.h                 | 73 +++++++++++++++++++++++++++++++++++-
 5 files changed, 143 insertions(+), 69 deletions(-)