Wireshark-commits: [Wireshark-commits] master 40f0f68: TDS: ensure to always initialize tds_encodin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 01 Feb 2018 03:07:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=40f0f6885f5d14e5e66f5f3237a0001612f781b5
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

40f0f68 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    TDS: ensure to always initialize tds_encoding_char even when protocol is unknown
    
    Otherwise we use an uninitialized variable
    
    Bug: 14372
    Change-Id: Idacdb40569421f7e41e181c14fb2bc033b0645b8
    Reviewed-on: https://code.wireshark.org/review/25529
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0c7bbc7   Qt: Avoid a potentially large memdup.
    adds  40f0f68   TDS: ensure to always initialize tds_encoding_char even when protocol is unknown


Summary of changes:
 epan/dissectors/packet-tds.c | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)