Wireshark-commits: [Wireshark-commits] master f3df81b: Qt: Fix open extcap help URL.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Dec 2016 12:09:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f3df81bf590a1c020155a485d77a2ab506270959
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f3df81b by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix open extcap help URL.
    
    The return value from QString::compare() is equal to zero when the
    strings are equal.  Fix the code for checking and opening the extcap
    help URL if not matching "file".
    
    This bug was introduced in g46caff30.
    
    Ping-Bug: 13218
    Change-Id: I2a84e61f0191b57269f8ce829ff82200bf19a7ac
    Reviewed-on: https://code.wireshark.org/review/19442
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  40c618e   Infiniband: Use base of packet tree (top_tree) for "infiniband.mad.cm.private" heuristic dissector.
    adds  f3df81b   Qt: Fix open extcap help URL.


Summary of changes:
 ui/qt/extcap_options_dialog.cpp |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)