Wireshark-commits: [Wireshark-commits] master 541beaa: Qt: use references on tap_rtp_stat_t private
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Dec 2016 12:55:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=541beaad6e99c8efc8a57a8e87fd5e8c3d56056a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

541beaa by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: use references on tap_rtp_stat_t private members (CID 1397703 and 1397704)
    
    This should solve the "passing parameter statinfo of type "tap_rtp_stat_t"
    (size 5040 bytes) by value" warnings reported by Coverity.
    
    Change-Id: I327906f7925ab21a914b8a98ff8481a0af9f7a2f
    Reviewed-on: https://code.wireshark.org/review/19380
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  61d2c8f   RTP: fix a possible NULL pointer dereference (CID 1397705 & 1397706)
    adds  541beaa   Qt: use references on tap_rtp_stat_t private members (CID 1397703 and 1397704)


Summary of changes:
 ui/qt/rtp_analysis_dialog.cpp |    4 ++--
 ui/qt/rtp_analysis_dialog.h   |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)