Wireshark-commits: [Wireshark-commits] master a8d06c7: packet-nbt.c: General cleanup
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Dec 2016 03:54:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8d06c7008bc2e82711e063641c4c2ba731cb08c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a8d06c7 by Michael Mann (mmann78@xxxxxxxxxxxx):

    packet-nbt.c: General cleanup
    
    1. Remove functionality that was replaced by a proto_tree_add_bitmask
    2. Remove use of nbdgm_header structure which is just a useless placeholder
    3. Remove some if (tree) over single fields.
    
    Change-Id: I0879043685686eb5b861cf77ec38bbf25ed6044e
    Reviewed-on: https://code.wireshark.org/review/19254
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b585c72   file-jpeg.c - Pacify pre-commit hooks by removing macro
    adds  a8d06c7   packet-nbt.c: General cleanup


Summary of changes:
 epan/dissectors/packet-nbt.c |  200 ++++++++++++------------------------------
 1 file changed, 54 insertions(+), 146 deletions(-)