Wireshark-commits: [Wireshark-commits] master 74f025d: RTPS: Cleanup endian handling
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2016 22:05:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74f025d79e37dbbd628144a7b69c8f0f23b50996
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

74f025d by Michael Mann (mmann78@xxxxxxxxxxxx):

    RTPS: Cleanup endian handling
    
    1. Rather than pass a boolean that has to be continually evaluated, just pass the
    necessary encoding (ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN)
    2. Incorporate more use of proto_tree_add_item_ret_[u]int
    3. Remove NEXT_guint16 and NEXT_guint32 because we now have tvb_get_guint16 and
    tvb_get_guint32
    
    Change-Id: Ib1c3488450b4e727d2c1943ba4e577faf2350dcc
    Reviewed-on: https://code.wireshark.org/review/19103
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  548b9fe   kafka: add dissection for rest of api keys
    adds  74f025d   RTPS: Cleanup endian handling


Summary of changes:
 epan/dissectors/packet-rtps.c | 1332 +++++++++++++++++++----------------------
 epan/dissectors/packet-rtps.h |   34 +-
 2 files changed, 619 insertions(+), 747 deletions(-)