Wireshark-commits: [Wireshark-commits] master b3e70f9: Qt: Refactor the packet list scroll bar.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3e70f9a7e91c7b462336f875c26965faedf1953
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
b3e70f9 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Refactor the packet list scroll bar.
Split OverlayScrollBar into parent and child scroll bar widgets. This
gives us two packet list scroll bars: a packet map, which draws and
operates on nearby packets and a normal scroll bar.
The packet map is drawn to the left of the child scroll bar. This gives
us more room to draw and doesn't obscure the scroll bar itself (which is
a problem on newer versions of Windows). When the user clicks on a
portion of the map, scroll to that part of the packet list.
Draw marked packet ticks over the normal scroll bar. Marked & ignored
are on the left, time references are on the right.
To do:
- Borrow more from packet fence and graph something (packet size? time
delta?)
Change-Id: Ie952fcbd98fd0e047200f2279cb63227feabf5b1
Reviewed-on: https://code.wireshark.org/review/15046
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from 3c5a9b1 Qt: Display filter toolbar behavior tweaks.
adds b3e70f9 Qt: Refactor the packet list scroll bar.
Summary of changes:
ui/qt/overlay_scroll_bar.cpp | 251 ++++++++++++++++++++++++++++--------------
ui/qt/overlay_scroll_bar.h | 33 +++++-
ui/qt/packet_list.cpp | 113 +++++++------------
ui/qt/packet_list.h | 3 +-
4 files changed, 237 insertions(+), 163 deletions(-)