Wireshark-commits, November 2015
November 01, 2015
03:21 [Wireshark-commits] master ced7412: TCP: replace some dissector asserts by a return Wireshark code review
03:21 [Wireshark-commits] master-2.0 c01faec: TCP: replace some dissector asserts by a return Wireshark code review
03:25 [Wireshark-commits] master af11478: bluetooth: Fix uninitialized value warning Wireshark code review
04:10 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 7 x64 buildbot-no-reply
08:26 [Wireshark-commits] master adc7bfe: voip_calls.c: add missing tap_draw callback to taps asking for a redraw Wireshark code review
08:26 [Wireshark-commits] master 9df0b8f: VoIP Calls: fix SIP calls state Wireshark code review
08:27 [Wireshark-commits] master 16f5b11: Qt: do not draw sequence analysis items with a display status set to false Wireshark code review
08:28 [Wireshark-commits] master-2.0 bf63b1a: voip_calls.c: add missing tap_draw callback to taps asking for a redraw Wireshark code review
08:29 [Wireshark-commits] master-2.0 cf2b149: VoIP Calls: fix SIP calls state Wireshark code review
08:30 [Wireshark-commits] master-2.0 0fd5fe6: Qt: do not draw sequence analysis items with a display status set to false Wireshark code review
08:49 [Wireshark-commits] master 56d0127: ISIS Hello: Restore correct dissection of SPB BVID Wireshark code review
09:00 [Wireshark-commits] master 4f04a3c: tools/pidl: avoid trailing tabs Wireshark code review
11:51 [Wireshark-commits] master 89c96d2: Add GUID dissector table support. Wireshark code review
14:51 [Wireshark-commits] master c042416: TDS: Register each login param in a separate field Wireshark code review
14:54 [Wireshark-commits] master ae574e3: packet-dcerpc: improve dissection of bind time feature negotiation Wireshark code review
15:16 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Fuzz Test buildbot-no-reply
16:12 [Wireshark-commits] master 21d881e: [Automatic update for 2015-11-01] Wireshark code review
16:19 [Wireshark-commits] master-2.0 e5db88a: [Automatic update for 2015-11-01] Wireshark code review
16:26 [Wireshark-commits] master-1.12 61581bb: [Automatic update for 2015-11-01] Wireshark code review
17:13 [Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows 7 x64 buildbot-no-reply
17:19 [Wireshark-commits] master a4a5f2d: Disable RTP player debug logs that were presumably left activated by mistake Wireshark code review
17:20 [Wireshark-commits] master c9c1ae4: [iso7816] remove unnecessary initial values Wireshark code review
17:24 [Wireshark-commits] master-2.0 0cb9273: Disable RTP player debug logs that were presumably left activated by mistake Wireshark code review
19:52 [Wireshark-commits] master d09cc65: [bitcoin] Convert commands into a dissector table Wireshark code review
20:32 [Wireshark-commits] master 69e61db: [bitcoin] don't THROW() an exception from a dissector Wireshark code review
21:43 [Wireshark-commits] master ad1b785: udp_dissect_pdus follow-up Wireshark code review
21:43 [Wireshark-commits] master-2.0 6379ae6: udp_dissect_pdus follow-up Wireshark code review
November 02, 2015
01:09 [Wireshark-commits] master f015c85: Update some WSUG screenshots and markup. Wireshark code review
03:49 [Wireshark-commits] master e52931b: RTPS: added new encoding to proto.c and used it in the rtps dissector Wireshark code review
11:38 [Wireshark-commits] master 4a8b20a: rtd_table(.h): fix api reference Wireshark code review
11:40 [Wireshark-commits] master 7f10520: srt_table(.h): fix api reference Wireshark code review
11:42 [Wireshark-commits] master 1c5b3c3: wsgcrypt.h checks internally if we HAVE_LIBGCRYPT Wireshark code review
11:44 [Wireshark-commits] master-2.0 ceba686: rtd_table(.h): fix api reference Wireshark code review
11:44 [Wireshark-commits] master-2.0 78dcbaa: srt_table(.h): fix api reference Wireshark code review
12:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
12:51 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86 buildbot-no-reply
13:03 [Wireshark-commits] master 1316fdf2: [GTPv2] Dissect UTRAN F-Container content. Wireshark code review
16:15 [Wireshark-commits] master 307443c: funnel_string_dialog(.h): fix extra ‘;’ [-Wpedantic] Wireshark code review
16:56 [Wireshark-commits] master-2.0 5c104e6: Update some WSUG screenshots and markup. Wireshark code review
17:42 [Wireshark-commits] master 8fdeb61: packet(.h): fix api reference / -Wdocumentation Wireshark code review
17:45 [Wireshark-commits] master 3dd5e25: packet-dcerpc: add proto_tree_add_dcerpc_drep() Wireshark code review
18:19 [Wireshark-commits] master 22a9376: BER: Removed erroneous callback from dissect_ber_external_U Wireshark code review
18:19 [Wireshark-commits] master-2.0 d64a210: BER: Removed erroneous callback from dissect_ber_external_U Wireshark code review
20:21 [Wireshark-commits] master-2.0 acbb4ac: ISIS Hello: Restore correct dissection of SPB BVID Wireshark code review
20:29 [Wireshark-commits] master-2.0 0f7121a: epan(.h): fix api reference Wireshark code review
21:29 [Wireshark-commits] master 332b9ce: PDCP LTE: fix dissection of signalling PDUs sent on common control channels Wireshark code review
21:32 [Wireshark-commits] master-2.0 9d38a9a: PDCP LTE: fix dissection of signalling PDUs sent on common control channels Wireshark code review
23:49 [Wireshark-commits] master 0f4d139: Update my e-mail address in the AUTHORS file Wireshark code review
November 03, 2015
00:37 [Wireshark-commits] master 6d1b6cd: CMake: Look for Python using the "App Paths" key. Wireshark code review
00:38 [Wireshark-commits] master-2.0 9b57b2c: CMake: Look for Python using the "App Paths" key. Wireshark code review
00:46 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 7 x64 buildbot-no-reply
00:51 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
00:58 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
01:04 [Wireshark-commits] master dd17c69: RADIUS: Fix length of display data for Ascend-Data-Filter Wireshark code review
01:06 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
01:09 [Wireshark-commits] master 4c03f4b: CMake: Pass ABSOLUTE to get_filename_component. Wireshark code review
01:09 [Wireshark-commits] master-2.0 72761a0: CMake: Pass ABSOLUTE to get_filename_component. Wireshark code review
01:35 [Wireshark-commits] master 5c5cc22: Revert the last two CMake changes. Wireshark code review
01:36 [Wireshark-commits] master-2.0 311dc57: Revert the last two CMake changes. Wireshark code review
01:46 [Wireshark-commits] master 6375df2: Put a newline at the end of the file. Wireshark code review
12:20 [Wireshark-commits] master 8571dbb: Document dissector "Decode As" functionality in README.dissector Wireshark code review
12:20 [Wireshark-commits] master-2.0 3628bb7: Document dissector "Decode As" functionality in README.dissector Wireshark code review
12:20 [Wireshark-commits] master 3df2333: Remaining ADDRESS macro to address function conversions Wireshark code review
12:21 [Wireshark-commits] master eafc94c: [Qt recent files menu] make sure that the "Clear Menu" item is retranslated Wireshark code review
12:38 [Wireshark-commits] master f528f55: packet-dcerpc-witness: initial implementation based on the idl file from samba Wireshark code review
12:47 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64 buildbot-no-reply
13:57 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
14:33 [Wireshark-commits] master 6c64a41: [SIP] Rework how the length of the diagnostic string is determined, it did not work with multiple SIP packages in one frame. Wireshark code review
14:35 [Wireshark-commits] master 657c55e: GTPv2: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
14:35 [Wireshark-commits] master-2.0 d86861b: [Qt recent files menu] make sure that the "Clear Menu" item is retranslated Wireshark code review
14:41 [Wireshark-commits] master-2.0 d464f27: [SIP] Rework how the length of the diagnostic string is determined, it did not work with multiple SIP packages in one frame. Wireshark code review
14:44 [Wireshark-commits] master-2.0 7ca8067: [GTPv2] Dissect UTRAN F-Container content. Wireshark code review
15:57 [Wireshark-commits] master-2.0 d763776: GTPv2: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
18:14 [Wireshark-commits] master 2244c6d: Update .mailmap with my new e-mail address Wireshark code review
19:22 [Wireshark-commits] master 688f2e8: Include packet-dcerpc-witness.h, so it's in the source tarball. Wireshark code review
21:00 [Wireshark-commits] master 86320fd: Qt: Turn off WindowModified when closing a file. Wireshark code review
21:00 [Wireshark-commits] master-2.0 1a396f2: Qt: Turn off WindowModified when closing a file. Wireshark code review
November 04, 2015
00:49 [Wireshark-commits] master 40b45df: packetbb; display Addressblock Tail as Tail Wireshark code review
00:49 [Wireshark-commits] master-2.0 5f74256: packetbb; display Addressblock Tail as Tail Wireshark code review
00:56 [Wireshark-commits] master 58431e2: Don't include libwireshark headers from libwiretap. Wireshark code review
01:55 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
02:46 [Wireshark-commits] master 795b5c1: Refactor some GSS-API dissectors to accept dissector data instead of using packet_info. Wireshark code review
02:49 [Wireshark-commits] master 321934f: MPTCP: Use copy_address_wmem() instead of copy_address() Wireshark code review
02:55 [Wireshark-commits] master-2.0 f24fc89: MPTCP: Use WMEM_COPY_ADDRESS() instead of copy_address() Wireshark code review
03:08 [Wireshark-commits] master-2.0 b766ec5: RADIUS: Fix length of display data for Ascend-Data-Filter Wireshark code review
03:48 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
08:46 [Wireshark-commits] master ff9f9fc: Don't include "file.h" if you don't need it. Wireshark code review
09:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
09:12 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
09:13 [Wireshark-commits] master 6704c8a: Don't include stuff from libwireshark. Wireshark code review
09:18 [Wireshark-commits] master eebbd0a: One more file that now needs wsutil/str_util.h for plurality(). Wireshark code review
10:41 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
11:30 [Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test buildbot-no-reply
11:32 [Wireshark-commits] master c7c33b0: Updated Diameter dictionary.xml with AVP values. Wireshark code review
11:33 [Wireshark-commits] master-2.0 50a4cb5: Updated Diameter dictionary.xml with AVP values. Wireshark code review
11:34 [Wireshark-commits] master ccca843: Activate word wrap for hintLabel defined as QLabel Wireshark code review
11:35 [Wireshark-commits] master-2.0 30039d1: Activate word wrap for hintLabel defined as QLabel Wireshark code review
11:38 [Wireshark-commits] master cde99ec: [OpenFlow] Use correct name for flag OFPMPF_REPLY_MORE in v5 dissector Wireshark code review
11:38 [Wireshark-commits] master-2.0 26be84f: [OpenFlow] Use correct name for flag OFPMPF_REPLY_MORE in v5 dissector Wireshark code review
12:16 [Wireshark-commits] master 58528f6: Fix AddressSanitizer (./configure --enable-asan) builds Wireshark code review
12:29 [Wireshark-commits] master-2.0 08a07fd: Fix AddressSanitizer (./configure --enable-asan) builds Wireshark code review
12:37 [Wireshark-commits] master 0ccab3c: Dictionary (diameter): fix indent (use tabs) Wireshark code review
12:40 [Wireshark-commits] master 74541a9: Don't allow multiple registrations of a protocol in dissector tables. Wireshark code review
12:43 [Wireshark-commits] master e0e574d: Refactor DCE/RPC dissection to include a real dissector table. Wireshark code review
12:46 [Wireshark-commits] master-2.0 1c4432c: Dictionary (diameter): fix indent (use tabs) Wireshark code review
12:55 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Ubuntu 14.04 x64 buildbot-no-reply
12:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
13:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
13:15 [Wireshark-commits] master 676e7ec: (Temporarily) Allow DCE/RPC dissector table to have duplicates. Wireshark code review
13:19 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 7 x64 buildbot-no-reply
13:19 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
13:41 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
14:43 [Wireshark-commits] master bd44cee: Diameter: fix a typo in dictionary.xml Wireshark code review
15:51 [Wireshark-commits] master 02dcf3c: Don't allow DCE/RPC dissector table to have duplicates Wireshark code review
17:24 [Wireshark-commits] master df48714: Skinny: fix dissector registration for SSL Wireshark code review
17:27 [Wireshark-commits] master 87aca40: SSL: fix SCTP port association so as to match what is done for UDP/TCP Wireshark code review
17:27 [Wireshark-commits] master-2.0 c3384ea: Skinny: fix dissector registration for SSL Wireshark code review
17:28 [Wireshark-commits] master-2.0 5e01e93: SSL: fix SCTP port association so as to match what is done for UDP/TCP Wireshark code review
17:55 [Wireshark-commits] master 283e63c: Squelch a "setjmp/longjump may clobber" warning. Wireshark code review
18:04 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64 buildbot-no-reply
18:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
18:22 [Wireshark-commits] master-2.0 b6fce8a: Diameter: fix a typo in dictionary.xml Wireshark code review
18:39 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
18:43 [Wireshark-commits] master a892e9b: Declaring volatile pointers to functions is hard, let's go shopping! Wireshark code review
19:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
22:22 [Wireshark-commits] master 0e01c01: gssapi: add init in wrap_dissect_gssapi_payload(). Wireshark code review
November 05, 2015
00:43 [Wireshark-commits] master ca69e8e: randpkt: code restyle. Wireshark code review
02:01 [Wireshark-commits] master ea0e29f: packet-dcerpc: fix dissecting of decrypted payload Wireshark code review
02:53 [Wireshark-commits] master 51dcd59: packet-dcerpc: let dcerpc_get_proto_name() handle unknown uuids Wireshark code review
04:02 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
07:42 [Wireshark-commits] master 9c0d550: extcap: Provide capture filter to extcap binary Wireshark code review
07:43 [Wireshark-commits] master-2.0 89642b3: extcap: Provide capture filter to extcap binary Wireshark code review
09:50 [Wireshark-commits] master 2eec154: [IPsec] Hand the subdissector the payload data only, not including the padding and auth data. Wireshark code review
09:52 [Wireshark-commits] master-2.0 d892994: [IPsec] Hand the subdissector the payload data only, not including the padding and auth data. Wireshark code review
17:17 [Wireshark-commits] master 52970ef: DNS: Register dissector by name Wireshark code review
17:17 [Wireshark-commits] master-2.0 efa7248: DNS: Register dissector by name Wireshark code review
19:57 [Wireshark-commits] master 4ea610a: dcerpc: add check for mutually exclusive function pointers Wireshark code review
21:24 [Wireshark-commits] master 25e3a6c: docs: Windows CMake builds Wireshark code review
21:24 [Wireshark-commits] master-2.0 fa85852: docs: Windows CMake builds Wireshark code review
22:40 [Wireshark-commits] master 9a47bc5: Match what most source say are the actual Japanese 4.9 GHz channels. Wireshark code review
22:56 [Wireshark-commits] master 2096c00: Get rid of ws80211_frequency_to_channel(). Wireshark code review
23:40 [Wireshark-commits] master d02104c: Qt: Check for a sane window geometry. Wireshark code review
23:49 [Wireshark-commits] master-2.0 0d0302e: Qt: Check for a sane window geometry. Wireshark code review
November 06, 2015
00:02 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86 buildbot-no-reply
00:07 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
01:14 [Wireshark-commits] master ce22578: Don't include io.h in Flex scanners - they're not interactive. Wireshark code review
04:38 [Wireshark-commits] master 8fb1f8e: reassemble: Add key destroy function to g_hash_table Wireshark code review
04:38 [Wireshark-commits] master-2.0 b10ab40: reassemble: Add key destroy function to g_hash_table Wireshark code review
04:40 [Wireshark-commits] master 4f01f3d: Move -fno-delete-null-pointer-checks to optional Wireshark code review
07:48 [Wireshark-commits] master 018e93a: Another unnecessary include of io.h. Wireshark code review
07:51 [Wireshark-commits] master-2.0 546984c: Another unnecessary include of io.h. Wireshark code review
07:52 [Wireshark-commits] master 35a1383: Major Re-factoring of the dissector and some new features. Wireshark code review
07:53 [Wireshark-commits] master-2.0 051e415: Major Re-factoring of the dissector and some new features. Wireshark code review
08:06 [Wireshark-commits] master af9ca05: packet-dcerpc: implement dissecting of rpc_sec_verification_trailer Wireshark code review
09:03 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
17:41 [Wireshark-commits] master 677027a: DCERPC: fix compilation with OSX buildbots and Ubuntu 15.10 Wireshark code review
18:12 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86 buildbot-no-reply
18:26 [Wireshark-commits] master cb3bdec: [Dissector tables] DISSECTOR_TABLE_NOT_ALLOW_DUPLICATE -> DISSECTOR_TABLE_ALLOW_DUPLICATE Wireshark code review
18:33 [Wireshark-commits] master 2d00abc: No need to include io.h. Wireshark code review
18:38 [Wireshark-commits] master 2cd80a7: Add Nokia Intelligent Service Interface (ISI) dissector Wireshark code review
18:43 [Wireshark-commits] master ee0dbdc: MPTCP: Use wmem_list instead of GSList Wireshark code review
18:44 [Wireshark-commits] master-2.0 75a53a7: MPTCP: Use wmem_list instead of GSList Wireshark code review
19:15 [Wireshark-commits] master bebc416: "#if 0" out an unused value_string table. Wireshark code review
19:35 [Wireshark-commits] master fdeab5a: Fix 32-bit OS X buildbot. Wireshark code review
19:51 [Wireshark-commits] master 1799834: Fix crash in internals menu dissector tables dialog by supporting FT_GUID type. Wireshark code review
20:19 [Wireshark-commits] master-2.0 625f246: bluetooth: Fix uninitialized value warning Wireshark code review
20:22 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
20:28 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
20:29 [Wireshark-commits] master 3b125e7: Make rect_on_screen Qt4-compatible. Wireshark code review
20:29 [Wireshark-commits] master-2.0 746eeb8: Make rect_on_screen Qt4-compatible. Wireshark code review
20:29 [Wireshark-commits] master 3a598d9: Sort isi_sim_cause. Wireshark code review
21:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
21:21 [Wireshark-commits] master 161f449c: 4294967296 is not guaranteed to be a valid integer constant. Wireshark code review
22:44 [Wireshark-commits] master-2.0 c82364b: Revert "Another unnecessary include of io.h." Wireshark code review
23:44 [Wireshark-commits] master f542ab8: file_util.h includes io.h, we don't need to do so ourselves. Wireshark code review
November 07, 2015
07:40 [Wireshark-commits] master e0cf8b6: ssl: add expert info for session resumption Wireshark code review
07:45 [Wireshark-commits] master 5735738: packet-smb2: make smb2_set_dcerpc_file_id() more reliable Wireshark code review
07:46 [Wireshark-commits] master e3c4626: isis-hello: Fix typo "Srea" -> "Area" Wireshark code review
14:10 [Wireshark-commits] master b56d323: Consider "HTTP over UDP" to be SSDP. Wireshark code review
14:11 [Wireshark-commits] master 3aefd3b: Create real dissector tables for SSL and DTLS to use. Wireshark code review
14:12 [Wireshark-commits] master f4921c1: Add support for registering protocols (dissectors) over DTLS. Wireshark code review
14:13 [Wireshark-commits] master 8ebc108: DNS: Add support of DNS over TLS and over DTLS Wireshark code review
16:06 [Wireshark-commits] master cdcf272: NSIS: clear errors before checking WinPcap uninstall registry entry Wireshark code review
16:06 [Wireshark-commits] master-2.0 18be1e1: NSIS: clear errors before checking WinPcap uninstall registry entry Wireshark code review
16:07 [Wireshark-commits] master-1.12 a91df74: NSIS: clear errors before checking WinPcap uninstall registry entry Wireshark code review
21:09 [Wireshark-commits] master e6a2f17: Add user preference to display IPv6 ext headers under root protocol tree Wireshark code review
21:11 [Wireshark-commits] master-2.0 417dc0b: DNS: Add support of DNS over TLS and over DTLS Wireshark code review
21:13 [Wireshark-commits] master 31f004f: Further refactor GSS_API dissectors to pass gssapi_encrypt_info_t structure between dissectors instead of using packet_info.h The only remaining explicit user of the packet_info members is the NTLMSSP dissector. However, there may be "hidden" use of it in the spnego dissector passing between ASN.1 functions. Someone more familiar with the protocols could possibly trim some of the "extra copies" between packet_info and gssapi_encrypt_info_t structure, but I went the "better safe than sorry" route. Wireshark code review
21:15 [Wireshark-commits] master 24bfb7e: column-utils: Refactor col_append_port() to col_append_ports() Wireshark code review
21:52 [Wireshark-commits] master 0162e54: Clean up includes of unistd.h, fcntl.h, and sys/stat.h. Wireshark code review
22:03 [Wireshark-commits] master 4897ef1: Just use <wsutil/file_util.h>. Wireshark code review
22:18 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
22:47 [Wireshark-commits] master a8766cc: Check for read errors in the open routine. Wireshark code review
22:47 [Wireshark-commits] master-2.0 9e82a8b: Check for read errors in the open routine. Wireshark code review
22:52 [Wireshark-commits] master e52d0fa: Remove #if 0'ed out includes. Wireshark code review
22:58 [Wireshark-commits] master e9ad65a: Get rid of some commented-out stuff. Wireshark code review
23:03 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
23:13 [Wireshark-commits] master 8e689a9: Remove some unnecessary includes. Wireshark code review
23:18 [Wireshark-commits] master 23dd596: Renames to avoid collisons with read() and write() routines. Wireshark code review
23:46 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
November 08, 2015
00:35 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
01:07 [Wireshark-commits] master 71c0960: <stdlib.h> is needed for atoi(). Wireshark code review
01:13 [Wireshark-commits] master f385922: More needed <stdlib.h>. Note why it and <stdio.h> are needed. Wireshark code review
01:27 [Wireshark-commits] master 9d52712: More unnecessary <stdio.h> includes. Wireshark code review
02:40 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
09:21 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Fuzz Test buildbot-no-reply
09:35 [Wireshark-commits] master dc13187: This doesn't need <wsutil/file_util.h>. Wireshark code review
10:00 [Wireshark-commits] master 11bdada: Update to reflect current reality. Wireshark code review
10:32 [Wireshark-commits] master caa1e87: Use ws_{read, write, fdopen, close}. Wireshark code review
11:25 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
14:55 [Wireshark-commits] master 5c2ab82: DCT2000 wiretap: Try to address CID 1158844 and 1158845 Wireshark code review
15:09 [Wireshark-commits] master 44644ed: DCT2000: eliminate dead code return from function (CID 1158885) Wireshark code review
16:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
16:12 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
16:32 [Wireshark-commits] master 7d8a094: DCT2000: change switch to if - I'm surprised it compiled at all Wireshark code review
17:03 [Wireshark-commits] master 0b3091f: GTP sequence number fix for allowing to have sequence number equal to 0 Wireshark code review
17:03 [Wireshark-commits] master-2.0 de550be: GTP sequence number fix for allowing to have sequence number equal to 0 Wireshark code review
17:04 [Wireshark-commits] master-1.12 f30de77: GTP sequence number fix for allowing to have sequence number equal to 0 Wireshark code review
18:31 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
18:32 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
18:32 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86 buildbot-no-reply
18:32 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 7 x64 buildbot-no-reply
18:32 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
18:32 [Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test buildbot-no-reply
18:51 [Wireshark-commits] master 1e87ff4: [Automatic update for 2015-11-08] Wireshark code review
18:59 [Wireshark-commits] master-2.0 4d3a689: [Automatic update for 2015-11-08] Wireshark code review
19:06 [Wireshark-commits] master-1.12 4905d2b: [Automatic update for 2015-11-08] Wireshark code review
19:24 [Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.6 x86 buildbot-no-reply
19:51 [Wireshark-commits] master 47172e7: Qt: Start adjusting icon sizes dynamically. Wireshark code review
19:51 [Wireshark-commits] master-2.0 cfdff01: Qt: Start adjusting icon sizes dynamically. Wireshark code review
19:53 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
November 09, 2015
10:58 [Wireshark-commits] master-2.0 34d119b: isis-hello: Fix typo "Srea" -> "Area" Wireshark code review
11:28 [Wireshark-commits] master d4985a5: idl2wrs: fix some glibc calls in favour of glib. Wireshark code review
11:28 [Wireshark-commits] master cb3dd95: WPA/WPA2 decoding fixes and improvements Wireshark code review
12:42 [Wireshark-commits] master 51f59e1: DTLS: fix no previous prototype for 'dtls_dissector_add/delete' [-Wmissing-prototypes] Wireshark code review
15:59 [Wireshark-commits] master 8f52962: Convert some "ethertype" subdissectors to "new" style. Wireshark code review
16:00 [Wireshark-commits] master 0aa9e98: Convert some UDP subdissectors to "new" style. Wireshark code review
16:00 [Wireshark-commits] master 2fe0fc5: Convert some TCP subdissectors to "new" style. Wireshark code review
16:05 [Wireshark-commits] master fcda681: randpkt: fix no previous prototype for 'randpkt_*' [-Wmissing-prototypes] Wireshark code review
17:40 [Wireshark-commits] master fe12759: androiddump: make nanoseconds int Wireshark code review
17:40 [Wireshark-commits] master-2.0 73841fd: androiddump: make nanoseconds int Wireshark code review
19:55 [Wireshark-commits] master 09f5ff4: Call the dumper routine to finish write a file the "finish" routine. Wireshark code review
19:55 [Wireshark-commits] master-2.0 5db1187: Call the dumper routine to finish write a file the "finish" routine. Wireshark code review
20:01 [Wireshark-commits] master 3425b5b: Update tests to reflect Lua file API change (write_close -> write_finish). Wireshark code review
20:01 [Wireshark-commits] master-2.0 f824a84: Update tests to reflect Lua file API change (write_close -> write_finish). Wireshark code review
21:12 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Ubuntu 14.04 x64 buildbot-no-reply
21:12 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
21:21 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 7 x64 buildbot-no-reply
21:33 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
21:35 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
21:47 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
November 10, 2015
00:32 [Wireshark-commits] master d64cf48: Fix Developers Guide link to source snapshots Wireshark code review
01:13 [Wireshark-commits] master 411112a: packet-smb2: provide reassembling support for Named Pipe subdissectors (e.g. DCERPC) Wireshark code review
01:23 [Wireshark-commits] master 6c3c6de: Treat "-" as "standard input" in the CLI, not in libwiretap. Wireshark code review
01:43 [Wireshark-commits] master-2.0 8fdef73: Treat "-" as "standard input" in the CLI, not in libwiretap. Wireshark code review
05:56 [Wireshark-commits] master 20a7e7f: file.c: do not try to close a file descriptor that was previously already closed Wireshark code review
08:45 [Wireshark-commits] master d059714: ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for ZBEE_ZCL_40_BIT_UINT Wireshark code review
08:56 [Wireshark-commits] master 3e5b253: RPC: call REPORT_DISSECTOR_BUG() rather than abort(). Wireshark code review
08:56 [Wireshark-commits] master-2.0 ce173bb: file.c: do not try to close a file descriptor that was previously already closed Wireshark code review
08:57 [Wireshark-commits] master-2.0 68d5d1d: RPC: call REPORT_DISSECTOR_BUG() rather than abort(). Wireshark code review
08:57 [Wireshark-commits] master-2.0 dd736b9: ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for ZBEE_ZCL_40_BIT_UINT Wireshark code review
09:03 [Wireshark-commits] master 0a99323: GIOP dissector: Replies are not correctly associated with requests Wireshark code review
09:03 [Wireshark-commits] master-2.0 6b5837c: GIOP dissector: Replies are not correctly associated with requests Wireshark code review
09:05 [Wireshark-commits] master 630ccbe: Make the dfilter time tests work regardless of what time zone the tests are being run in. Wireshark code review
09:17 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
09:47 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64 buildbot-no-reply
10:12 [Wireshark-commits] master 827b7dd: Skip only the actual file descriptor close when writing to stdout. Wireshark code review
10:19 [Wireshark-commits] master-2.0 019557e: Skip only the actual file descriptor close when writing to stdout. Wireshark code review
10:26 [Wireshark-commits] master-2.0 6ce6985: Use WMEM_COPY_ADDRESS(), not copy_address_wmem(). Wireshark code review
10:50 [Wireshark-commits] master b3fa7e5: Add a comment for is_stdout. Wireshark code review
10:51 [Wireshark-commits] master-2.0 9d48e02: Add a comment for is_stdout. Wireshark code review
10:55 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86 buildbot-no-reply
11:29 [Wireshark-commits] master 6ae50eb: Call wtap_dump_open_check() in wtap_dump_init_dumper(). Wireshark code review
11:30 [Wireshark-commits] master-2.0 3a962d4: Call wtap_dump_open_check() in wtap_dump_init_dumper(). Wireshark code review
12:12 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
18:10 [Wireshark-commits] master e2193fe: Fix typo. Wireshark code review
18:10 [Wireshark-commits] master-2.0 636d667: Fix typo. Wireshark code review
19:37 [Wireshark-commits] master 6a56224: [docsis->packet-tlv.c] Update for modem capabilities TLV 5, subTLV 2 and subTLV 33 Wireshark code review
19:38 [Wireshark-commits] master-2.0 1094da4: [docsis->packet-tlv.c] Update for modem capabilities TLV 5, subTLV 2 and subTLV 33 Wireshark code review
20:00 [Wireshark-commits] master-2.0 6b315b4: Update the release notes. Wireshark code review
20:29 [Wireshark-commits] master-2.0 0b5f601: Apple just calls it "OS X" these days. Wireshark code review
21:00 [Wireshark-commits] master 0d497e8: Initial Sysdig syscall (event) support. Wireshark code review
21:03 [Wireshark-commits] master-2.0 e9d1d00: Initial Sysdig syscall (event) support. Wireshark code review
21:09 [Wireshark-commits] master 0b05086: Apple calls it just "OS X" these days. Wireshark code review
21:09 [Wireshark-commits] master-2.0 2b4881f: Apple calls it just "OS X" these days. Wireshark code review
21:48 [Wireshark-commits] master ec303c1: Add CMakeLists.txt.user* to .gitignore. Wireshark code review
21:54 [Wireshark-commits] master 67a6342: New 2.0 symbols. Wireshark code review
21:54 [Wireshark-commits] master-2.0 9bfc915: New 2.0 symbols. Wireshark code review
22:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
22:14 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64 buildbot-no-reply
November 11, 2015
00:07 [Wireshark-commits] master 905314f: Additional 2.1 symbols. Wireshark code review
00:15 [Wireshark-commits] master b9b74fc: ISI: fix code will never be executed [-Wunreachable-code] Wireshark code review
00:22 [Wireshark-commits] master c2afc9e: Change prototype of callbacks passed to wmem_tree_foreach so that they accept the node key as a first parameter. Wireshark code review
00:23 [Wireshark-commits] master 541f352: UDP: Don't throw malformed errors for empty UDP payload Wireshark code review
00:23 [Wireshark-commits] master-2.0 5679982: UDP: Don't throw malformed errors for empty UDP payload Wireshark code review
00:25 [Wireshark-commits] master 886de6b: ISI: Add Modelines info Wireshark code review
04:40 [Wireshark-commits] master 18a54fc: debian: Drop menu support Wireshark code review
04:42 [Wireshark-commits] master 927a55f: debian: Add note to README.Debian to log in again to be able to capture packets Wireshark code review
04:43 [Wireshark-commits] master 2d1bf73: debian: Finish postinst of wireshark-common even when wireshark group is a user group Wireshark code review
04:44 [Wireshark-commits] master 5055291: debian: Ship wireshark.1 in the package we ship /usr/bin/wireshark Wireshark code review
04:45 [Wireshark-commits] master 7d86cc9: debian: Ship wireshark.desktop file in wireshark-qt Wireshark code review
04:46 [Wireshark-commits] master b732f44: GTK: Add separate working desktop file for GTK+ Wireshark GUI Wireshark code review
04:47 [Wireshark-commits] master f2ac2e4: debian: Move icon and mime info file to wireshark-common Wireshark code review
04:51 [Wireshark-commits] master-2.0 de1faf3: debian: Drop menu support Wireshark code review
04:52 [Wireshark-commits] master-2.0 1cdaea2: debian: Add note to README.Debian to log in again to be able to capture packets Wireshark code review
04:52 [Wireshark-commits] master-2.0 51b4c32: debian: Finish postinst of wireshark-common even when wireshark group is a user group Wireshark code review
04:53 [Wireshark-commits] master-2.0 d42095a: debian: Ship wireshark.desktop file in wireshark-qt Wireshark code review
04:54 [Wireshark-commits] master-2.0 cb81c7a: GTK: Add separate working desktop file for GTK+ Wireshark GUI Wireshark code review
05:26 [Wireshark-commits] master 8930b0d: debian: Make make dist know about moving wireshark.1 to wireshark-qt and removal of wireshark.menu Wireshark code review
05:28 [Wireshark-commits] master 757fe65: Qt: Freeze+thaw the main window during nested operations. Wireshark code review
05:28 [Wireshark-commits] master-2.0 4afc1be: Qt: Freeze+thaw the main window during nested operations. Wireshark code review
08:06 [Wireshark-commits] master 5f4c9b2: Make routines used only within wiretap/merge.c static. Wireshark code review
08:07 [Wireshark-commits] master-2.0 c156a64: Make routines used only within wiretap/merge.c static. Wireshark code review
08:16 [Wireshark-commits] master a4981a2: Qt: fixes to 'Edit Column' dialog Wireshark code review
08:17 [Wireshark-commits] master-2.0 60cebb7: Qt: fixes to 'Edit Column' dialog Wireshark code review
08:17 [Wireshark-commits] master 328fbc0: Qt: fix profile rename Wireshark code review
08:18 [Wireshark-commits] master-2.0 ca5a275: Qt: fix profile rename Wireshark code review
10:36 [Wireshark-commits] master-1.12 146485d: Add CMakeLists.txt.user* to .gitignore. Wireshark code review
11:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
12:23 [Wireshark-commits] master-2.0 df2fcdf: Update user guide for upcoming 2.0 release Wireshark code review
12:25 [Wireshark-commits] master-2.0 3062480: Change prototype of callbacks passed to wmem_tree_foreach so that they accept the node key as a first parameter. Wireshark code review
12:26 [Wireshark-commits] master-2.0 b13ec59: debian: Make make dist know about moving wireshark.1 to wireshark-qt and removal of wireshark.menu Wireshark code review
12:30 [Wireshark-commits] wireshark-win32-libs rev 474: / /trunk/packages/: user-guide-g7ea0d6c.zip user-guide-gdf2fcdf.zip /trunk/: README.txt pascal
12:45 [Wireshark-commits] wireshark-win32-libs rev 475: /tags/2015-11-11/ pascal
12:51 [Wireshark-commits] wireshark-win64-libs rev 427: / /trunk/packages/: user-guide-g7ea0d6c.zip user-guide-gdf2fcdf.zip /trunk/: README.txt pascal
12:58 [Wireshark-commits] wireshark-win64-libs rev 428: /tags/2015-11-11/ pascal
13:22 [Wireshark-commits] master f1ff6d6: randpkt: split into a core and an app. Wireshark code review
15:04 [Wireshark-commits] master-2.0 7c2ae96: debian: Ship wireshark.1 in the package we ship /usr/bin/wireshark Wireshark code review
17:31 [Wireshark-commits] master fb3d382: Update user guide for development release Wireshark code review
17:43 [Wireshark-commits] master c4b4b9a: Rename the wireshark-gnome RPM package wireshark-gtk. Wireshark code review
17:44 [Wireshark-commits] master-2.0 3e1dc65: Rename the wireshark-gnome RPM package wireshark-gtk. Wireshark code review
17:47 [Wireshark-commits] master ec289ed: Put randpkt-core.h into the release tarball. Wireshark code review
17:47 [Wireshark-commits] master b20d5bb: CMake: set WinPcap version in top CMakeLists.txt file like for NMake Wireshark code review
18:00 [Wireshark-commits] master-2.0 9d47195: CMake: set WinPcap version in top CMakeLists.txt file like for NMake Wireshark code review
18:00 [Wireshark-commits] master 978d7a8: Update user guide for upcoming 2.0 release Wireshark code review
18:15 [Wireshark-commits] master 4a97057: Fixup a couple of stdout checks. Wireshark code review
18:16 [Wireshark-commits] master-2.0 f4d421d: Fixup a couple of stdout checks. Wireshark code review
19:05 [Wireshark-commits] master-2.0 e42ec18: Update translations for 2.0.0rc3. Wireshark code review
19:08 [Wireshark-commits] master-2.0 be439b9: Update user guide for upcoming 2.0 release Wireshark code review
19:55 [Wireshark-commits] master b6fd85b: Put wtap_dump_open() right before wtap_dump_open_ng(). Wireshark code review
19:55 [Wireshark-commits] master-2.0 8050a32: Put wtap_dump_open() right before wtap_dump_open_ng(). Wireshark code review
20:43 [Wireshark-commits] master ca2ecc1: Qt: fix cursor position when editing coloring rules names or filters Wireshark code review
20:43 [Wireshark-commits] master-2.0 1c1a5c2: Qt: fix cursor position when editing coloring rules names or filters Wireshark code review
21:08 [Wireshark-commits] master-2.0 841d5e1: Build 2.0.0rc3. Wireshark code review
21:09 [Wireshark-commits] [wireshark] annotated tag v2.0.0rc3 created (now 0fa79db) Wireshark code review
November 12, 2015
00:07 [Wireshark-commits] master-2.0 52302cf: 2.0.0rc3 → 2.0.0rc4. Wireshark code review
00:57 [Wireshark-commits] master af8c70c: Add $(randpkt_INCLUDES) to $(noinst_HEADERS) so they're distributed. Wireshark code review
00:59 [Wireshark-commits] master 75dc205: Add wtap_dump_open_tempfile routines, to write to a temporary file. Wireshark code review
01:00 [Wireshark-commits] master-2.0 05e9f0c: Add wtap_dump_open_tempfile routines, to write to a temporary file. Wireshark code review
01:49 [Wireshark-commits] master 412ab83: Plug file descriptor leak. Wireshark code review
01:49 [Wireshark-commits] master-2.0 726a84b: Plug file descriptor leak. Wireshark code review
03:31 [Wireshark-commits] master 09f43c1: Export functions str_to_ip() and str_to_ip6() to plugins Wireshark code review
03:31 [Wireshark-commits] master-2.0 dccdc70: Export functions str_to_ip() and str_to_ip6() to plugins Wireshark code review
03:33 [Wireshark-commits] master bf2b578: Make it possible to set an environment variable to do debug builds. Wireshark code review
03:35 [Wireshark-commits] master 50e83c0: 802.11: avoid multi return on SSID or MESHID Wireshark code review
03:35 [Wireshark-commits] master-2.0 fecd0f6: 802.11: avoid multi return on SSID or MESHID Wireshark code review
03:36 [Wireshark-commits] master 90d9710: IPv6: Register extension header fields under the appropriate protocol Wireshark code review
06:30 [Wireshark-commits] master e240ad8: Use format_text() when displaying, not when handing to AirPDcap. Wireshark code review
06:31 [Wireshark-commits] master-2.0 aed1269: Use format_text() when displaying, not when handing to AirPDcap. Wireshark code review
06:59 [Wireshark-commits] master a67d426: dissector for ISO14443 protocols Wireshark code review
07:00 [Wireshark-commits] master 864872e: Qt: Added IO Graph save to clipboard button. Wireshark code review
07:03 [Wireshark-commits] master c712d65: Qt: save preferences after creating a filter from expression frame Wireshark code review
07:04 [Wireshark-commits] master-2.0 9d4ab78: Qt: Added IO Graph save to clipboard button. Wireshark code review
07:04 [Wireshark-commits] master-2.0 5e702ec: Qt: save preferences after creating a filter from expression frame Wireshark code review
07:09 [Wireshark-commits] master 1ab019f: Fix up documentation of RPM packages. Wireshark code review
07:10 [Wireshark-commits] master-2.0 2309a2d: Fix up documentation of RPM packages. Wireshark code review
07:15 [Wireshark-commits] master 2d7b0fc: [GTK] Replace deprecated gdk_pixbuf_new_from_inline() Wireshark code review
08:16 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
08:38 [Wireshark-commits] master a321e60: Squelch a compiler warning. Wireshark code review
09:45 [Wireshark-commits] master 7309217: Put back ' in user guide name Wireshark code review
11:29 [Wireshark-commits] master 56c1e80: [IMF] Add bounds checks to avoid buffer overruns, also sets the last_field flag to true if it's the end of the buffer. Wireshark code review
11:30 [Wireshark-commits] master-2.0 295397b: [IMF] Add bounds checks to avoid buffer overruns, also sets the last_field flag to true if it's the end of the buffer. Wireshark code review
15:48 [Wireshark-commits] master 2ff3c75: Qt: initialize all remote interface options Wireshark code review
15:48 [Wireshark-commits] master-2.0 832daf4: Qt: initialize all remote interface options Wireshark code review
17:16 [Wireshark-commits] master 6655ff9: [configure.ac] Update gtk+ and glib release date lists Wireshark code review
17:45 [Wireshark-commits] master db02f99: Fix installation of desktop files. Wireshark code review
17:46 [Wireshark-commits] master-2.0 508bf9b: Fix installation of desktop files. Wireshark code review
20:58 [Wireshark-commits] master 7775b48: Developer guide: add docbook-xml45 to the list of required Cygwin packages Wireshark code review
20:58 [Wireshark-commits] master-2.0 cfa5dca: Developer guide: add docbook-xml45 to the list of required Cygwin packages Wireshark code review
November 13, 2015
00:09 [Wireshark-commits] master 9fe7102: Qt: fix UI artifacts seen in UAT window on Linux or OSX Wireshark code review
00:09 [Wireshark-commits] master-2.0 5cf57a8: Qt: fix UI artifacts seen in UAT window on Linux or OSX Wireshark code review
01:48 [Wireshark-commits] master f5d7548: Qt: Coloring Rules dialog fixups. Wireshark code review
01:49 [Wireshark-commits] master-2.0 0554c2f: Qt: Coloring Rules dialog fixups. Wireshark code review
05:53 [Wireshark-commits] master bd96244: MEGACO: fix indent (remove tab) Wireshark code review
06:03 [Wireshark-commits] master 1b6bf76: Qt: Fixed signal name to avoid a warning. Wireshark code review
06:03 [Wireshark-commits] master-2.0 7dcfb52: Qt: Fixed signal name to avoid a warning. Wireshark code review
06:35 [Wireshark-commits] master aa94bbe: Qt: fix creation of a new profile broken by g328fbc0 Wireshark code review
06:35 [Wireshark-commits] master-2.0 65d8606: Qt: fix creation of a new profile broken by g328fbc0 Wireshark code review
07:33 [Wireshark-commits] master b01cd39: Diameter: Expand an error message. Wireshark code review
07:35 [Wireshark-commits] master-2.0 48565e3: Diameter: Expand an error message. Wireshark code review
07:40 [Wireshark-commits] master 91290f7: [docsis] Support for Queue Depth-based Request Frame Wireshark code review
07:45 [Wireshark-commits] master-2.0 29fe1de: [docsis] Support for Queue Depth-based Request Frame Wireshark code review
07:46 [Wireshark-commits] master 18b8f48: Fix compilation when _DEBUG is defined. Wireshark code review
08:33 [Wireshark-commits] master 89879ef: dmp: Enhance ack framenum links. Wireshark code review
08:33 [Wireshark-commits] master-2.0 d21bd22: dmp: Enhance ack framenum links. Wireshark code review
08:33 [Wireshark-commits] master acbf7d5: p_mul: Enhance ack framenum links. Wireshark code review
08:34 [Wireshark-commits] master-2.0 8589c91: p_mul: Enhance ack framenum links. Wireshark code review
09:43 [Wireshark-commits] master 661c977: Qt: Add go to next + previous packet in conversation. Wireshark code review
10:01 [Wireshark-commits] master f104333: Diameter dictionary updated. Wireshark code review
11:51 [Wireshark-commits] master-2.0 60aeed1: Diameter dictionary updated. Wireshark code review
11:51 [Wireshark-commits] master-2.0 7c194e7: Qt: Add go to next + previous packet in conversation. Wireshark code review
14:08 [Wireshark-commits] master da71ccb: epan: Free cf->edt before free cf->epan when redissecting. Wireshark code review
14:08 [Wireshark-commits] master-2.0 51d1065: epan: Free cf->edt before free cf->epan when redissecting. Wireshark code review
14:24 [Wireshark-commits] master 654d4ab: CMake: add our own FindCygwin module Wireshark code review
14:24 [Wireshark-commits] master-2.0 25ec91a: CMake: add our own FindCygwin module Wireshark code review
15:07 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Fuzz Test buildbot-no-reply
15:45 [Wireshark-commits] master b776707: Diameter: fix typo in dictionary Wireshark code review
15:45 [Wireshark-commits] master-2.0 156bd6f: Diameter: fix typo in dictionary Wireshark code review
17:44 [Wireshark-commits] master 01f7356: register_dissector -> new_register_dissector Wireshark code review
19:03 [Wireshark-commits] master 679c18a: Makefile.nmake: add randpkt-core.obj to the list of cleaned objects Wireshark code review
November 14, 2015
13:31 [Wireshark-commits] master 5c1b132: airpdcap_system.(h) fix parameter 'mngHandshake/mngDecrypt' not found in the function declaration [-Wdocumentation] Wireshark code review
14:34 [Wireshark-commits] master 2e19755: dmp: Fixed ack framenum links. Wireshark code review
14:42 [Wireshark-commits] master 20388ef: p_mul: Fixed ack framenum links. Wireshark code review
15:17 [Wireshark-commits] master-2.0 188db54: dmp: Fixed ack framenum links. Wireshark code review
15:18 [Wireshark-commits] master-2.0 669275e: p_mul: Fixed ack framenum links. Wireshark code review
16:37 [Wireshark-commits] master-1.12 960ac0b: DNS: Ignore Client Subnet option's data length when > 16 Wireshark code review
17:16 [Wireshark-commits] master 76dec3b: UDP Multicast Stats: Fixed typo Wireshark code review
17:17 [Wireshark-commits] master-2.0 9505d3c: UDP Multicast Stats: Fixed typo Wireshark code review
18:00 [Wireshark-commits] master 8faf5c8: register_dissector -> new_register_dissector Wireshark code review
18:11 [Wireshark-commits] master 9196fa9: Qt: Fixed use-of-deallocated-memory when removing a profile. Wireshark code review
18:11 [Wireshark-commits] master-2.0 b1d106a: Qt: Fixed use-of-deallocated-memory when removing a profile. Wireshark code review
21:23 [Wireshark-commits] master 1310102: Lua: Disallow ProtoField FRAMENUM to fetch from Tvb. Wireshark code review
21:23 [Wireshark-commits] master-2.0 b3fdc18: Lua: Disallow ProtoField FRAMENUM to fetch from Tvb. Wireshark code review
21:54 [Wireshark-commits] master 28ea582: register_dissector -> new_register_dissector Wireshark code review
21:55 [Wireshark-commits] master 159227a: register_dissector -> new_register_dissector for plugins. Wireshark code review
November 15, 2015
01:51 [Wireshark-commits] master a595c70: [docsis->packet-tlv.c] Updated Confirmation Code list per MULPIv3.1-I07 Annex C.4 Wireshark code review
01:51 [Wireshark-commits] master 4dea5db: [docsis->ucd] Add support for 6 new TLVs Wireshark code review
16:10 [Wireshark-commits] master b44e3fc: [Automatic update for 2015-11-15] Wireshark code review
16:17 [Wireshark-commits] master-2.0 df05544: [Automatic update for 2015-11-15] Wireshark code review
16:23 [Wireshark-commits] master-1.12 7a801e1: [Automatic update for 2015-11-15] Wireshark code review
18:25 [Wireshark-commits] master 82bd3cc: udp: Don't mark zero checksum illegal when in_error_pkt. Wireshark code review
18:26 [Wireshark-commits] master-2.0 5d41bb3: udp: Don't mark zero checksum illegal when in_error_pkt. Wireshark code review
18:33 [Wireshark-commits] master e6b5f01: Lua: Added support for ProtoField framenum type. Wireshark code review
18:33 [Wireshark-commits] master-2.0 76a8009: Lua: Added support for ProtoField framenum type. Wireshark code review
19:33 [Wireshark-commits] master 25fd5b5: gtk: Fixed out-of-source autotools build. Wireshark code review
19:56 [Wireshark-commits] master a8e7740: Lua: Check for nil valuestring for integer fields. Wireshark code review
19:57 [Wireshark-commits] master-2.0 03da34b: Lua: Check for nil valuestring for integer fields. Wireshark code review
20:15 [Wireshark-commits] master 67ad1de: FindLUA.cmake: reject version 5.3 Wireshark code review
20:41 [Wireshark-commits] master-2.0 0f33924: FindLUA.cmake: reject version 5.3 Wireshark code review
22:04 [Wireshark-commits] master d66d379: Try retroactively applying the Qt folks' fix for QTBUG-47942. Wireshark code review
22:06 [Wireshark-commits] master 561bcff: Lua: Fixed some argument # in argument errors. Wireshark code review
22:06 [Wireshark-commits] master-2.0 982cd3f: Lua: Fixed some argument # in argument errors. Wireshark code review
22:10 [Wireshark-commits] master 974a9e3: [docsis->type29ucd] Remove Type 4 Burst from Type 29 UCD Wireshark code review
22:14 [Wireshark-commits] master 2db4543: tcp: Revert back to the old Flags entry. Wireshark code review
22:15 [Wireshark-commits] master-2.0 445c36c: tcp: Revert back to the old Flags entry. Wireshark code review
22:31 [Wireshark-commits] master 6012ba8: tcp: Indicate number of bits used for Flags. Wireshark code review
22:31 [Wireshark-commits] master-2.0 0a065f0: tcp: Indicate number of bits used for Flags. Wireshark code review
November 16, 2015
02:09 [Wireshark-commits] master-2.0 3ba5160: Try retroactively applying the Qt folks' fix for QTBUG-47942. Wireshark code review
03:50 [Wireshark-commits] master bbdd89b: create_dissector_handle -> new_create_dissector_handle Wireshark code review
05:00 [Wireshark-commits] master 9451e52: Qt iograph: Fix off-by-one, insure we plot the last interval. Wireshark code review
05:09 [Wireshark-commits] master-2.0 ac08883: Qt iograph: Fix off-by-one, insure we plot the last interval. Wireshark code review
07:12 [Wireshark-commits] master 6c1ae95: [docsis->ucd] Removed S-CDMA bursts and added expert Wireshark code review
07:15 [Wireshark-commits] master-2.0 9a7077c: [docsis->ucd] Removed S-CDMA bursts and added expert Wireshark code review
07:40 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64 buildbot-no-reply
08:02 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86 buildbot-no-reply
08:22 [Wireshark-commits] master-2.0 4d3e818: [docsis->ucd] Add support for 6 new TLVs Wireshark code review
08:36 [Wireshark-commits] master 442314e: Revert "Override optimization and other flags for make based generators." Wireshark code review
08:46 [Wireshark-commits] master-2.0 976d60c: Revert "Override optimization and other flags for make based generators." Wireshark code review
08:58 [Wireshark-commits] master-2.0 419c55e: ssl-utils: add versions to ssl debug log Wireshark code review
09:00 [Wireshark-commits] master-2.0 95fe690: ssl: add expert info for session resumption Wireshark code review
09:57 [Wireshark-commits] master 2773596: Qt: add a reference counter to sequence analysis info Wireshark code review
10:06 [Wireshark-commits] master-2.0 52b40aa: Qt: add a reference counter to sequence analysis info Wireshark code review
12:14 [Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86 buildbot-no-reply
14:31 [Wireshark-commits] master fc51af4: Don't include wireshark-gtk.desktop in RPMs. Wireshark code review
14:32 [Wireshark-commits] master-2.0 03a3896: Don't include wireshark-gtk.desktop in RPMs. Wireshark code review
15:04 [Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test buildbot-no-reply
16:50 [Wireshark-commits] master bf8ec76: Qt iograph: Trigger graph refresh when time-of-day checkbox is toggeled. Wireshark code review
17:33 [Wireshark-commits] master 92d487a: Qt: deactivate save / close / reload buttons when rescanning a capture Wireshark code review
17:34 [Wireshark-commits] master-2.0 401981d: Qt: deactivate save / close / reload buttons when rescanning a capture Wireshark code review
19:01 [Wireshark-commits] master e9dd7c8: Label the filter in the file open dialog as a "read filter". Wireshark code review
19:01 [Wireshark-commits] master-2.0 7777feb: Label the filter in the file open dialog as a "read filter". Wireshark code review
19:18 [Wireshark-commits] master 95fd55e: For now, call the finish routine in Lua file writers "close". Wireshark code review
19:18 [Wireshark-commits] master-2.0 556cc71: For now, call the finish routine in Lua file writers "close". Wireshark code review
20:40 [Wireshark-commits] master 4224aab: Qt: do not clear display filter when merging files Wireshark code review
20:40 [Wireshark-commits] master-2.0 e4da149: Qt: do not clear display filter when merging files Wireshark code review
21:10 [Wireshark-commits] master 0a0a811: catapult: fix sscanf buffer overflow Wireshark code review
21:40 [Wireshark-commits] master 9ec2cbb: Catch failure of _open_osfhandle(). Wireshark code review
21:41 [Wireshark-commits] master-2.0 1530393: Catch failure of _open_osfhandle(). Wireshark code review
21:46 [Wireshark-commits] master c909900: ssl, dtls: use a single field to track ProtocolVersion Wireshark code review
21:48 [Wireshark-commits] master 4002f98: ssl, dtls: use ProtocolVersion from Server Hello Wireshark code review
21:56 [Wireshark-commits] master-1.12 90bc4af: Catch failure of _open_osfhandle(). Wireshark code review
21:59 [Wireshark-commits] master 92bb13a: Export the value_string array ip_proto_val_ext for usage in plugins Wireshark code review
22:00 [Wireshark-commits] master 799d6fd: create_dissector_handle -> new_create_dissector_handle Wireshark code review
22:52 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
22:55 [Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows 8.1 x86 buildbot-no-reply
23:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
November 17, 2015
00:44 [Wireshark-commits] master 1aeb3cb: Remove old, unused images. Wireshark code review
00:45 [Wireshark-commits] master-2.0 4c38abd: Remove old, unused images. Wireshark code review
01:37 [Wireshark-commits] master 9a79737: CMake: Add "C:/tools/cygwin" to FindCygwin.cmake. Wireshark code review
01:37 [Wireshark-commits] master-2.0 543d677: CMake: Add "C:/tools/cygwin" to FindCygwin.cmake. Wireshark code review
04:18 [Wireshark-commits] master c302554: Misc minor issues caught by cppcheck Wireshark code review
07:32 [Wireshark-commits] master 062e5b3: Qt: setMenusForSelectedPacket when capture file is closed. Wireshark code review
07:33 [Wireshark-commits] master-2.0 7a27de4: Qt: setMenusForSelectedPacket when capture file is closed. Wireshark code review
07:35 [Wireshark-commits] master d3f68e5: Qt: avoid crash when use Go Next/Previous Conversation Wireshark code review
07:35 [Wireshark-commits] master-2.0 a289cb9: Qt: avoid crash when use Go Next/Previous Conversation Wireshark code review
07:39 [Wireshark-commits] master 2dc3b98: Qt: Removed obsolete comments. Wireshark code review
07:40 [Wireshark-commits] master-2.0 b51933d: Qt: Removed obsolete comments. Wireshark code review
08:08 [Wireshark-commits] master 14c35c3: Create C handles for pipes before running dumpcap. Wireshark code review
08:09 [Wireshark-commits] master-2.0 e7a37d4: Create C handles for pipes before running dumpcap. Wireshark code review
08:17 [Wireshark-commits] master-1.12 39e8dcc: Create C handles for pipes before running dumpcap. Wireshark code review
08:18 [Wireshark-commits] master 167874a: Extcap: allow Wireshark to list extcap interfaces even when WinPcap / Npcap is not installed Wireshark code review
08:19 [Wireshark-commits] master 527e032: Win32: Try to fix handle leaks in capture_sync. Wireshark code review
08:25 [Wireshark-commits] master 622603b: extcap: fix a bug in cfilter Wireshark code review
08:26 [Wireshark-commits] master-2.0 6c1836b: extcap: fix a bug in cfilter Wireshark code review
08:27 [Wireshark-commits] master-2.0 1191636: Extcap: allow Wireshark to list extcap interfaces even when WinPcap / Npcap is not installed Wireshark code review
08:27 [Wireshark-commits] master-2.0 e3b1aee: Win32: Try to fix handle leaks in capture_sync. Wireshark code review
09:40 [Wireshark-commits] master 7518a74: Qt: Fix a merge crash. Wireshark code review
09:41 [Wireshark-commits] master-2.0 a4cb6f6: Qt: Fix a merge crash. Wireshark code review
10:08 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 7 x64 buildbot-no-reply
10:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
10:37 [Wireshark-commits] master 9ba4c95: extcap: fix a crash introduced in g622603b Wireshark code review
10:38 [Wireshark-commits] master-2.0 8a31ba6: extcap: fix a crash introduced in g622603b Wireshark code review
13:15 [Wireshark-commits] master 7da8b65: decode Hotspot 2.0 Indication in 802.11 beacons Wireshark code review
17:19 [Wireshark-commits] master 0197156: update the ISO1443 dissector Wireshark code review
17:30 [Wireshark-commits] master a18f8c8: Qt: Fix Follow Dialog crash. Wireshark code review
17:30 [Wireshark-commits] master 04f3f65: [Diameter] Add Diameter Overload Indication AVPs [RFC 7683] Wireshark code review
17:30 [Wireshark-commits] master-2.0 e6908ce: Qt: Fix Follow Dialog crash. Wireshark code review
17:31 [Wireshark-commits] master-2.0 e9a1d0f: [Diameter] Add Diameter Overload Indication AVPs [RFC 7683] Wireshark code review
17:41 [Wireshark-commits] master 9b26632: [iso14443] dissect I-block PCB components Wireshark code review
17:41 [Wireshark-commits] master 44ca31d: [iso14443] do a more precise check for uid-related commands Wireshark code review
17:46 [Wireshark-commits] master 6893348: Qt: Fix some flow graph issues. Wireshark code review
17:46 [Wireshark-commits] master-2.0 302265e: Qt: Fix some flow graph issues. Wireshark code review
17:50 [Wireshark-commits] master abfeb2d: [iso14443] start dissecting the PCB of an S-block Wireshark code review
19:14 [Wireshark-commits] master 27502f1: debian: Don't ship unused duplicated images for guides Wireshark code review
21:51 [Wireshark-commits] master 8383cb9: Lua: Do not deregister Listener in __gc. Wireshark code review
21:52 [Wireshark-commits] master-2.0 95b7675: Lua: Do not deregister Listener in __gc. Wireshark code review
22:00 [Wireshark-commits] master ec68330: Qt: Fixup the I/O Graph color menu width on Windows. Wireshark code review
22:00 [Wireshark-commits] master-2.0 5afff39: Qt: Fixup the I/O Graph color menu width on Windows. Wireshark code review
22:32 [Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows 7 x64 buildbot-no-reply
22:36 [Wireshark-commits] master 52e95fb: Cleanups. Wireshark code review
22:36 [Wireshark-commits] master-2.0 d7806f9: Cleanups. Wireshark code review
22:46 [Wireshark-commits] master e3eb9f3: CMake: Add Qt5Svg to PACKAGELIST. Wireshark code review
22:46 [Wireshark-commits] master-2.0 804ee98: CMake: Add Qt5Svg to PACKAGELIST. Wireshark code review
22:49 [Wireshark-commits] master 0fef9d7: Fix crash in RTP Player on stop and close Wireshark code review
22:50 [Wireshark-commits] master-2.0 d92a5fa: Fix crash in RTP Player on stop and close Wireshark code review
22:50 [Wireshark-commits] master b6f060e: CMakeList.txt (ui/gtk/qt) fix indent and modelines Wireshark code review
22:58 [Wireshark-commits] master f38bd00: Commiting CISCO ERSPAN3 Marker dissector for pushing to upstream Wireshark code review
November 18, 2015
00:25 [Wireshark-commits] master b1a8a0d: MPTCP: Use endianness macros directly instead of creating new tvbuff Wireshark code review
00:29 [Wireshark-commits] master 84ab0e4: BGP: Add dissection of ESI NLRI (EVPN) RFC7432 Wireshark code review
00:31 [Wireshark-commits] master 2cbb583: [docsis->type29ucd] Update to DOCSIS 2.0 Wireshark code review
04:19 [Wireshark-commits] master-2.0 a21709e: Export the value_string array ip_proto_val_ext for usage in plugins Wireshark code review
07:18 [Wireshark-commits] master 8c211d5: epan: Check for valid cf->edt before free. Wireshark code review
07:18 [Wireshark-commits] master-2.0 f564801: epan: Check for valid cf->edt before free. Wireshark code review
07:19 [Wireshark-commits] master 1329743: Lua: Disable Reload Lua Plugins while reading file. Wireshark code review
07:19 [Wireshark-commits] master-2.0 290601a: Lua: Disable Reload Lua Plugins while reading file. Wireshark code review
07:33 [Wireshark-commits] master 4adeb42: create_dissector_handle -> new_create_dissector_handle Wireshark code review
16:36 [Wireshark-commits] master 73ee917: Qt: Don't update expert icon without a capture file. Wireshark code review
16:37 [Wireshark-commits] master-2.0 aceaaa8: Qt: Don't update expert icon without a capture file. Wireshark code review
17:37 [Wireshark-commits] master 8826db5: [iso14443] add simple components of an R-block Wireshark code review
17:45 [Wireshark-commits] master 3ca5e3e: create_dissector_handle -> new_create_dissector_handle for plugins Wireshark code review
17:51 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
18:40 [Wireshark-commits] master 5c49fac: Error from waitpid(): Fix Code is unreachable Wireshark code review
18:41 [Wireshark-commits] master-2.0 c3ac3d0: Error from waitpid(): Fix Code is unreachable Wireshark code review
19:40 [Wireshark-commits] master bdea0d4: Check for ECHILD, not for "not ECHILD". Wireshark code review
19:41 [Wireshark-commits] master-2.0 1f3e0c0: Check for ECHILD, not for "not ECHILD". Wireshark code review
20:28 [Wireshark-commits] master 3d3eb15: Revert: Free cf->edt before free cf->epan when redissecting. Wireshark code review
20:30 [Wireshark-commits] master-2.0 fbbc605: Revert: Free cf->edt before free cf->epan when redissecting. Wireshark code review
21:36 [Wireshark-commits] master-2.0 9a73b82: Build 2.0.0. Wireshark code review
21:37 [Wireshark-commits] [wireshark] annotated tag v2.0.0 created (now b47b9f2) Wireshark code review
21:37 [Wireshark-commits] [wireshark] annotated tag wireshark-2.0.0 created (now ad6fbc2) Wireshark code review
23:33 [Wireshark-commits] master-2.0 5f086d3: 2.0.0 → 2.0.1. Wireshark code review
November 19, 2015
07:53 [Wireshark-commits] master 8504d54: [docsis-type29ucd] Changed TLV Length Bad filter to make more sense Wireshark code review
07:58 [Wireshark-commits] master c3ce687: Lldp: Lldp Dissector Column Info is updated for Profinet Wireshark code review
08:02 [Wireshark-commits] master c4a4b7c: GResource configure.ac fixup Wireshark code review
12:52 [Wireshark-commits] master 9b2c889: NWP: use col_add_str to set COL_INFO Wireshark code review
12:52 [Wireshark-commits] master-2.0 b3162ea: NWP: use col_add_str to set COL_INFO Wireshark code review
13:40 [Wireshark-commits] master 4fd711f: use the official DLT for ISO14443 Wireshark code review
14:10 [Wireshark-commits] master ae6126f: ASN1 (custom.make): fix typo Wireshark code review
14:11 [Wireshark-commits] master-2.0 3fce547: ASN1 (custom.make): fix typo Wireshark code review
14:12 [Wireshark-commits] master 1a84148: Fixing picosecond timestamp for vrt protocol. Needs to be parsed as uint64 not double Wireshark code review
14:12 [Wireshark-commits] master-2.0 554babc: Fixing picosecond timestamp for vrt protocol. Needs to be parsed as uint64 not double Wireshark code review
15:29 [Wireshark-commits] master d6da952: extcap: add sshdump. Wireshark code review
15:48 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
16:51 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
16:53 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
16:55 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
17:03 [Wireshark-commits] master b61e205: osx: fix build when binary list is not fully compiled. Wireshark code review
17:03 [Wireshark-commits] master cf56221: Profinet: use pinfo pool to build conversation filter Wireshark code review
17:03 [Wireshark-commits] master-2.0 6e1dc90: Profinet: use pinfo pool to build conversation filter Wireshark code review
17:17 [Wireshark-commits] master fdf486e: nmake: fix char in comment Wireshark code review
November 20, 2015
05:47 [Wireshark-commits] master c297df1: More spelling fixes found by lintian Wireshark code review
05:48 [Wireshark-commits] master-2.0 2707658: More spelling fixes found by lintian Wireshark code review
06:25 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
07:57 [Wireshark-commits] master 0ae1965: Qt: Fixed column issues when changing profile. Wireshark code review
07:58 [Wireshark-commits] master-2.0 9625a6f: Qt: Fixed column issues when changing profile. Wireshark code review
12:14 [Wireshark-commits] master 01cdabb: androiddump: Add Bluetooth support for Android M Wireshark code review
12:33 [Wireshark-commits] master fefc14b: [docsis->ucd] Dissect TYPE and LENGTH values for burst TLVs also. Wireshark code review
12:35 [Wireshark-commits] master a2a6b6c: Enhance ERSPAN decoder to correctly support ERSPAN3 (current version mangles packets) Wireshark code review
12:49 [Wireshark-commits] master 9b7aab9: Rule-Failure-Code enum value 14 added. Wireshark code review
12:49 [Wireshark-commits] master-2.0 3c8036f: Rule-Failure-Code enum value 14 added. Wireshark code review
15:47 [Wireshark-commits] master 706cff8: sshdump: add packets count Wireshark code review
15:49 [Wireshark-commits] master 7a6ebd7: Minor Doc Update for Windows build Wireshark code review
16:00 [Wireshark-commits] master c442464: Bluetooth: Move GATT dissectors registration to GATT handoff Wireshark code review
16:00 [Wireshark-commits] master a901006: Bluetooth: Add ability to add custom UUID description Wireshark code review
16:01 [Wireshark-commits] master 8ac3d9a: Bluetooth: L2CAP: Improve tracing connects and disconnects Wireshark code review
16:01 [Wireshark-commits] master 909d9c9: Bluetooth: GATT: Add HTTP Proxy Service attributes Wireshark code review
16:01 [Wireshark-commits] master 18d0c94: Bluetooth: Update company IDs and Member/SDO UUIDs Wireshark code review
16:02 [Wireshark-commits] master d0d6940: Bluetooth: EIR/AD: Add URI item support Wireshark code review
16:02 [Wireshark-commits] master 7a7b293: Bluetooth: HCI vendor: Add some Broadcom commands Wireshark code review
16:02 [Wireshark-commits] master 928ce9f: Bluetooth: Fix remaining lengths Wireshark code review
16:03 [Wireshark-commits] master fef4714: File-format: Add ISO_14443 linktype for PCAP/PCAPNG Wireshark code review
November 21, 2015
02:53 [Wireshark-commits] master 91f4e3b: Have a separate dissector for pcap/pcapng-format packet data. Wireshark code review
03:12 [Wireshark-commits] master 227d122: Use the "pcap/pcapng packet data" dissector to dissect packet data. Wireshark code review
08:04 [Wireshark-commits] master 8762e7e: sshdump: add define for default capture bin Wireshark code review
08:20 [Wireshark-commits] master fb11b8a: usbvideo: fix Malformed packet error for SET_CUR Wireshark code review
08:21 [Wireshark-commits] master-2.0 3ea3237: usbvideo: fix Malformed packet error for SET_CUR Wireshark code review
09:40 [Wireshark-commits] master-2.0 e3ca036: Set major SO versions for release in CMake and debian/ Wireshark code review
09:56 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Ubuntu 14.04 x64 buildbot-no-reply
11:23 [Wireshark-commits] master f711fbf: ISO14443: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Wireshark code review
11:35 [Wireshark-commits] master-2.0 a0eabfa: debian: Fix bumping SO versions Wireshark code review
13:51 [Wireshark-commits] master 67d9daa: autotools: Fix extra-compiler-warnings for system headers Wireshark code review
13:53 [Wireshark-commits] master 1df7c07: RTPS: Added Topic Information feature. This feature shows the Topic Name and the Type Name of the sample by consulting a hash table that relates GUIDs and this information. Wireshark code review
14:14 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
14:59 [Wireshark-commits] master d7adc43: display_filter_edit(.h): fix comma at end of enumerator list [-Wpedantic] / commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions] Wireshark code review
16:48 [Wireshark-commits] master 02fdea0: cmake: do not remove ws.css; ignore auto-generated files Wireshark code review
16:50 [Wireshark-commits] master-2.0 1e4b183: debian: Move icon and mime info file to wireshark-common Wireshark code review
17:11 [Wireshark-commits] master 6552810: acinclude.m4: Replace AS_ECHO_N with printf Wireshark code review
18:21 [Wireshark-commits] master f1efeb1: Fix Windows hardening check Wireshark code review
18:42 [Wireshark-commits] master 23258fb: epan: Removed an unneeded g_malloc. Wireshark code review
19:34 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
20:30 [Wireshark-commits] master 94b9907: Lua: Validate Proto() arguments Wireshark code review
20:34 [Wireshark-commits] master-2.0 f13254a: Lua: Validate Proto() arguments Wireshark code review
22:44 [Wireshark-commits] master a648921: Fix Windows hardening check (x64) Wireshark code review
23:31 [Wireshark-commits] master 2c74679: Fix OSX 10.5 autotools package for missing sshdump Wireshark code review
November 22, 2015
08:23 [Wireshark-commits] master 59ffbc3: GSM MAP: Add Ericsson specific fields to MAP-OpenInfo Wireshark code review
08:27 [Wireshark-commits] master 782be9a: [docsis] Remove unused exceptions.h Wireshark code review
08:34 [Wireshark-commits] master 46876a9: Developers Guide Updates Wireshark code review
08:37 [Wireshark-commits] master f9f88ff: Diameter: add dissection of Credit-Management-Status AVP code Wireshark code review
08:39 [Wireshark-commits] master bcabd8d: register_dissector -> new_register_dissector for ASN.1 dissectors. Wireshark code review
08:43 [Wireshark-commits] master f1b3b32: Cisco FabricPath MiM: rename file name Wireshark code review
08:46 [Wireshark-commits] master 26366ef: SCSI: Fix mixed up SCSI senddiag PF values Wireshark code review
08:48 [Wireshark-commits] master-2.0 f5bad76: SCSI: Fix mixed up SCSI senddiag PF values Wireshark code review
11:25 [Wireshark-commits] master 74247f9: Fix RTP player crash on invalid streams Wireshark code review
11:25 [Wireshark-commits] master-2.0 402735d: Fix RTP player crash on invalid streams Wireshark code review
11:26 [Wireshark-commits] master 759bfb6: Do not expand packets in packet dialog by default Wireshark code review
11:27 [Wireshark-commits] master-2.0 ca749e0: Do not expand packets in packet dialog by default Wireshark code review
11:31 [Wireshark-commits] master d61c3d5: asn2wrs.py: fix path substitution when generating ASN.1 dissectors with CMake on Windows Wireshark code review
11:31 [Wireshark-commits] master-2.0 805395f: asn2wrs.py: fix path substitution when generating ASN.1 dissectors with CMake on Windows Wireshark code review
14:49 [Wireshark-commits] master a02fc3b: Qt: Set normal window icon when capture file closed. Wireshark code review
14:51 [Wireshark-commits] master-2.0 7bc6c10: Qt: Set normal window icon when capture file closed. Wireshark code review
14:52 [Wireshark-commits] master 3586150: Qt: Added translate for "Capturing from ". Wireshark code review
14:52 [Wireshark-commits] master-2.0 42f7ce1: Qt: Added translate for "Capturing from ". Wireshark code review
15:26 [Wireshark-commits] master 45259fb: RADIUS: Add display field for Ascend data Filter Wireshark code review
17:11 [Wireshark-commits] master-2.0 be6a54f6: Qt: save columns position before freezing Wireshark code review
17:29 [Wireshark-commits] master 17e088b: Qt: save columns position before freezing Wireshark code review
18:48 [Wireshark-commits] master cc9e444: We *do* use setWindowModified; remove the XXX comment saying to do so. Wireshark code review
18:53 [Wireshark-commits] master-2.0 e191090: We *do* use setWindowModified; remove the XXX comment saying to do so. Wireshark code review
19:16 [Wireshark-commits] master d69cec7: Quote the path for the Windows setup script. Wireshark code review
19:17 [Wireshark-commits] master-2.0 b6cd321: Quote the path for the Windows setup script. Wireshark code review
19:26 [Wireshark-commits] master b044e48: Quote the source directory in Git commands. Wireshark code review
19:26 [Wireshark-commits] master-2.0 f2cd6dc: Quote the source directory in Git commands. Wireshark code review
20:38 [Wireshark-commits] master 9e1128b: Add Windows CMake auto generated files to .gitignore Wireshark code review
20:39 [Wireshark-commits] master-2.0 35e508e: Add Windows CMake auto generated files to .gitignore Wireshark code review
November 23, 2015
04:07 [Wireshark-commits] master fad1565: Remove configure --enable-ipv6 option Wireshark code review
05:41 [Wireshark-commits] master c5fb402: Qt: Set tooltip for packet list header Wireshark code review
05:45 [Wireshark-commits] master 35e5523: Qt: Improved profiles popup menu Wireshark code review
05:57 [Wireshark-commits] master b9812a7: Qt: Preserve selected file in welcome screen. Wireshark code review
05:58 [Wireshark-commits] master-2.0 8ad6404: Qt: Preserve selected file in welcome screen. Wireshark code review
06:01 [Wireshark-commits] master 9fad599: merge: fix parameter 'in_files/in_count_files' not found in the function declaration [-Wdocumentation] Wireshark code review
06:02 [Wireshark-commits] master-2.0 d4f355c: merge: fix parameter 'in_files/in_count_files' not found in the function declaration [-Wdocumentation] Wireshark code review
06:03 [Wireshark-commits] master e36f987: http: case-insensitive custom headers match Wireshark code review
06:06 [Wireshark-commits] master 391f11a: epan: Free pointers to deallocated memory Wireshark code review
06:11 [Wireshark-commits] master-2.0 1b50a32: epan: Free pointers to deallocated memory Wireshark code review
07:36 [Wireshark-commits] master-2.0 a95eeb3f: Qt: Improved profiles popup menu Wireshark code review
07:40 [Wireshark-commits] master-2.0 e82c37e: Qt: Set tooltip for packet list header Wireshark code review
07:51 [Wireshark-commits] master ed4e53a: Fix 'make dumpapi' target Wireshark code review
08:26 [Wireshark-commits] master 815b7fe: Qt: Revert to more optimized code Wireshark code review
08:26 [Wireshark-commits] master-2.0 280f0d1: Qt: Revert to more optimized code Wireshark code review
09:32 [Wireshark-commits] master e0af790: lemon (tools): Fix Dereference of null pointer found by Clang analyzer Wireshark code review
09:42 [Wireshark-commits] master dee3b80: RADIUS: fix wrong offset for protocol Wireshark code review
09:43 [Wireshark-commits] master 9f017eb: RADIUS: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Wireshark code review
09:44 [Wireshark-commits] master 52c3fb8: RADIUS: Use directly tvb_ip_to_str Wireshark code review
12:25 [Wireshark-commits] master 073cfb3: CMakeLists (root): fix indent (use tabs) Wireshark code review
13:10 [Wireshark-commits] master 2bbbb48: register_dissector -> new_register_dissector Wireshark code review
13:10 [Wireshark-commits] master-2.0 92c07d3: RADIUS: fix wrong offset for protocol Wireshark code review
15:54 [Wireshark-commits] master 3b32515: RADIUS: fix indent Wireshark code review
15:55 [Wireshark-commits] master 8fa938d: HiSLIP: remove a DISSECTOR_ASSERT Wireshark code review
16:17 [Wireshark-commits] master 44cea43: RTPS: fix no previous prototype for 'compare/hash_by_guid' [-Wmissing-prototypes] Wireshark code review
16:18 [Wireshark-commits] master 3438fe2: Pcap (pktdata): fix no previous prototype for ... [-Wmissing-prototypes] Wireshark code review
16:39 [Wireshark-commits] master-2.0 bc03ab1: HiSLIP: remove a DISSECTOR_ASSERT Wireshark code review
16:58 [Wireshark-commits] master-1.12 c6efada: HiSLIP: remove a DISSECTOR_ASSERT Wireshark code review
17:03 [Wireshark-commits] master 7324555: Qt: Fixed more column issues when changing profile. Wireshark code review
17:03 [Wireshark-commits] master-2.0 688b340: Qt: Fixed more column issues when changing profile. Wireshark code review
17:23 [Wireshark-commits] master 5afbf7e0: cmake: fix "multiple rules generate abi-descriptor.template" warning Wireshark code review
17:36 [Wireshark-commits] master 57e18b0: register_dissector -> new_register_dissector Wireshark code review
20:30 [Wireshark-commits] master 81330b1: sshdump: fix int issue Wireshark code review
20:35 [Wireshark-commits] master 9851bed: Qt: Fix column resolve names Wireshark code review
20:35 [Wireshark-commits] master-2.0 0c55bd5: Qt: Fix column resolve names Wireshark code review
November 24, 2015
00:30 [Wireshark-commits] master 6ffac79: Adding RFC5512 extended community Wireshark code review
00:33 [Wireshark-commits] master 0ea7d92: DNS: Add edns-tcp-keepalive EDNS0 Option Wireshark code review
00:34 [Wireshark-commits] master bf34d53: DNS: Add EDNS(0) Padding Option Wireshark code review
00:34 [Wireshark-commits] master ed0cc43: DNS: Chain Query requests Wireshark code review
01:24 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Fuzz Test buildbot-no-reply
02:02 [Wireshark-commits] master bfd4987: dbus dissector: Handle alignments of basic types. Wireshark code review
02:04 [Wireshark-commits] master ac2008c: Qt (Recent Files): Fix typo on variable name Wireshark code review
02:30 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
05:49 [Wireshark-commits] master 921bb07: Check *how many* fields sscanf() found. Wireshark code review
05:49 [Wireshark-commits] master-2.0 1e52fad: Check *how many* fields sscanf() found. Wireshark code review
05:49 [Wireshark-commits] master-1.12 2c59970: Check *how many* fields sscanf() found. Wireshark code review
05:50 [Wireshark-commits] master da88541: Fix indentation. Wireshark code review
05:51 [Wireshark-commits] master-2.0 1d60bcd: Fix indentation. Wireshark code review
05:51 [Wireshark-commits] master-1.12 4245d2b: Fix indentation. Wireshark code review
06:00 [Wireshark-commits] master 61082a2: [docsis->type35ucd] Add support for type 35 UCD message. Wireshark code review
06:05 [Wireshark-commits] master eaac7de: Developers Guide updates for plugins with CMake Wireshark code review
06:06 [Wireshark-commits] master-2.0 9756c66: Qt (Recent Files): Fix typo on variable name Wireshark code review
06:14 [Wireshark-commits] master ffb5b3d: cmake: add dependency information for copy_data_files Wireshark code review
06:18 [Wireshark-commits] master 2bd360d: Make dissect_mp4ves_config a real dissector to be called by SDP Wireshark code review
08:00 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
08:02 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
08:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
09:25 [Wireshark-commits] master 8748a04: Fix NSIS installer generation broken in gffb5b3d Wireshark code review
10:16 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
11:48 [Wireshark-commits] master e30c8f2: Convert PPI dissectors to "new style". Wireshark code review
12:01 [Wireshark-commits] master 46f3fe4: [Custom plugins] CUSTOM_PLUGIN_IN_FILES is no longer required. Wireshark code review
12:02 [Wireshark-commits] master-2.0 4053651: [Custom plugins] CUSTOM_PLUGIN_IN_FILES is no longer required. Wireshark code review
12:58 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
13:06 [Wireshark-commits] master 4df75d7: sshdump: add default filter even when interfaces are not listed. Wireshark code review
13:17 [Wireshark-commits] master dc93041: Convert XMPP dissector to "new style". Wireshark code review
14:52 [Wireshark-commits] master 8a999d7: Convert T.124 API to use "new style" dissectors. Wireshark code review
14:52 [Wireshark-commits] master 8df0bac: Remove the LDAP wrapping for registering dissectors and just use dissector_add_string directly. Wireshark code review
14:53 [Wireshark-commits] master 5088030: Remove register_dissector. Wireshark code review
15:04 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
15:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
15:39 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
15:40 [Wireshark-commits] master 9b7aaa2: Art-Net: Add missing ArtSync opcode Wireshark code review
15:41 [Wireshark-commits] master 0981a50: Qt: check that a file name was selected before trying to export follow content Wireshark code review
15:45 [Wireshark-commits] master-2.0 b3217e2: Qt: check that a file name was selected before trying to export follow content Wireshark code review
17:09 [Wireshark-commits] master 8c46a72: VoIP: fix a null dereference when trying to retrieve the time of a T.38 tapped packet Wireshark code review
17:10 [Wireshark-commits] master-2.0 aa961e0: VoIP: fix a null dereference when trying to retrieve the time of a T.38 tapped packet Wireshark code review
17:32 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
18:15 [Wireshark-commits] master-1.12 7f90e4e: VoIP: fix a crash when trying to retrieve the time of a T.38 tapped packet Wireshark code review
19:14 [Wireshark-commits] master 9601a4f: Qt: Save preferences when hide/show columns Wireshark code review
19:14 [Wireshark-commits] master-2.0 38af1ad: Qt: Save preferences when hide/show columns Wireshark code review
20:06 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
21:05 [Wireshark-commits] wireshark-win32-libs rev 476: / /trunk/packages/: libssh-0.7.2-win32ws.zip /trunk/: README.txt pascal
21:36 [Wireshark-commits] wireshark-win32-libs rev 477: /tags/2015-11-24/ pascal
21:40 [Wireshark-commits] wireshark-win64-libs rev 429: / /trunk/packages/: libssh-0.7.2-win64ws.zip /trunk/: README.txt pascal
21:44 [Wireshark-commits] wireshark-win64-libs rev 430: /tags/2015-11-24/ pascal
23:02 [Wireshark-commits] master bd08ab9: Introduces augmented interval trees Wireshark code review
23:27 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
23:33 [Wireshark-commits] master 2f73ac0: Remove support for "old style" dissectors in PER API. Wireshark code review
23:41 [Wireshark-commits] master b9c5023: Avoid colliding definitions of wmem_tree_t. Wireshark code review
23:50 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
November 25, 2015
02:49 [Wireshark-commits] master b73e812: No declarations in the middle of code. Wireshark code review
03:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
03:31 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
05:38 [Wireshark-commits] master e9c26d0: Check whether create_tempfile() fails. Wireshark code review
05:39 [Wireshark-commits] master-2.0 e10bd6b: Check whether create_tempfile() fails. Wireshark code review
05:40 [Wireshark-commits] master dee1c6e: Profinet: ARProperties that contains Combined Object Container Bit Wireshark code review
06:00 [Wireshark-commits] master b1230ba: Fix typo. Wireshark code review
06:21 [Wireshark-commits] master 1c7b949: Use try_val_to_str_ext() in print_uuid(). Wireshark code review
07:21 [Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test buildbot-no-reply
07:30 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
07:45 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
08:29 [Wireshark-commits] master 7b10256: Profinet: All SubframeData elements are not decoded Wireshark code review
08:50 [Wireshark-commits] master dbde760: Fix copy-and-pasteo. Wireshark code review
09:24 [Wireshark-commits] master ecc9c74: Lua: fix URL to documentation Wireshark code review
09:25 [Wireshark-commits] master-2.0 b9d8d3c: Lua: fix URL to documentation Wireshark code review
10:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
10:54 [Wireshark-commits] master 6181045: Don't check whether the C++ compiler supports a flag if there isn't one. Wireshark code review
11:01 [Wireshark-commits] master 12b2e3d: cmake: fix dependencies for copy_data_files Wireshark code review
11:23 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
11:34 [Wireshark-commits] master 571ed4d: Print guint64's with G_GUINT64_FORMAT. Wireshark code review
11:44 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
12:03 [Wireshark-commits] master 9107fb6: Fix memory leaks related to hide_interface function Wireshark code review
12:36 [Wireshark-commits] master cec0593: Fix buffer overrun in zlib decompression Wireshark code review
12:37 [Wireshark-commits] master-2.0 7ea63cf: Fix buffer overrun in zlib decompression Wireshark code review
12:42 [Wireshark-commits] master-1.12 ff0220f: Fix buffer overrun in zlib decompression Wireshark code review
13:14 [Wireshark-commits] master 479ab3b: Fix memory leak in capture_get_if_capabilities Wireshark code review
13:14 [Wireshark-commits] master-2.0 d93918f: Fix memory leak in capture_get_if_capabilities Wireshark code review
13:15 [Wireshark-commits] master dcfea6a: create_dissector_handle -> new_create_dissector_handle Wireshark code review
13:27 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
14:19 [Wireshark-commits] master 9a2d16b: Fix memory leak in write_prefs Wireshark code review
14:48 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
15:20 [Wireshark-commits] master dde848b: Press Start instead of Manage Interfaces on Enter Wireshark code review
15:21 [Wireshark-commits] master-2.0 a17866f: Press Start instead of Manage Interfaces on Enter Wireshark code review
16:29 [Wireshark-commits] master 992a7ee: asn2wrs.py: always use relative paths Wireshark code review
19:21 [Wireshark-commits] master 0cd1a85: Require BER dissector (OID) registration to be "new style". Wireshark code review
19:21 [Wireshark-commits] master 73e58f0: create_dissector_handle -> new_create_dissector_handle for ASN.1 dissectors Wireshark code review
19:56 [Wireshark-commits] master bcb3191: TACACS: fix indent (and add modelines) Wireshark code review
20:03 [Wireshark-commits] master ac7982c: Remove 'filetap' residue from .gitignore Wireshark code review
20:07 [Wireshark-commits] master b314342: qt: move file close (CID 1159303) Wireshark code review
20:08 [Wireshark-commits] master-2.0 57f3171: qt: move file close (CID 1159303) Wireshark code review
20:15 [Wireshark-commits] master f5404e5: RTPS: feature to add a preference that enables the dissection of the RTPS special announcements that RTI sends. They just start by RTPX and are sent to the domain 0 always. Wireshark code review
21:01 [Wireshark-commits] master 9cd66b2: WPA (IEEE802.11) decryption function cleanups Wireshark code review
21:19 [Wireshark-commits] master 83c8cd2: wmem: add initializer (CID 1340194). Wireshark code review
22:44 [Wireshark-commits] master 723756b: PPP: RTP IPHC Compressed Non TCP packets and D bit zero packets (RFC 2507) Wireshark code review
November 26, 2015
00:00 [Wireshark-commits] master 2259bf8: SCTP: verify frame pointer before dereferencing it Wireshark code review
00:00 [Wireshark-commits] master-2.0 a77290c: SCTP: verify frame pointer before dereferencing it Wireshark code review
02:15 [Wireshark-commits] master b1044d6: ISUP: fix a wrong removal of proto_tree_add_text() Wireshark code review
02:15 [Wireshark-commits] master-2.0 904e1b4: ISUP: fix a wrong removal of proto_tree_add_text() Wireshark code review
03:01 [Wireshark-commits] master b9b6f3f: Most fields in an ISO 8601 date/time are unsigned. Wireshark code review
03:04 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
03:18 [Wireshark-commits] master 486dd13: Remove create_dissector_handle Wireshark code review
05:11 [Wireshark-commits] master 805136d: Replace tvb_get_enctohl and tvb_get_enctohs with the functions already created in tvbuff.h Wireshark code review
05:46 [Wireshark-commits] master 013bf21: [RUDP] Use proto_tree_add_bitmask instead of something homegrown. Wireshark code review
05:48 [Wireshark-commits] master 98a50d8: cmake: print the current CMAKE_C_FLAGS/CMAKE_CXX_FLAGS Wireshark code review
06:31 [Wireshark-commits] master 2cf37ea: Document tvb_get_guintXXX and tvb_get_ieee_XXX Wireshark code review
07:45 [Wireshark-commits] master ce9d2ee: Qt: Redissect packets when changing profile Wireshark code review
07:46 [Wireshark-commits] master-2.0 682e3a6: Qt: Redissect packets when changing profile Wireshark code review
08:03 [Wireshark-commits] master 30f46b6: Add a check for the day of the month. Wireshark code review
08:36 [Wireshark-commits] master 1b32d50: SCTP: add another NULL dereference check Wireshark code review
08:36 [Wireshark-commits] master-2.0 a9b4be9: SCTP: add another NULL dereference check Wireshark code review
08:38 [Wireshark-commits] master a9f5d85: NSIS: refuse to install on Windows XP or Server 2003 Wireshark code review
08:38 [Wireshark-commits] master be7bd77: Add BMT_NO_FLAGS for proto_tree_add_bitmask_XXX_with_flags. Wireshark code review
08:40 [Wireshark-commits] master-2.0 a92137d: NSIS: refuse to install on Windows XP or Server 2003 Wireshark code review
09:14 [Wireshark-commits] master-1.12 39a50f4: SCTP: verify frame pointer before dereferencing it Wireshark code review
11:05 [Wireshark-commits] master 97e627e: L2TP: Correct L2TP over IP SHA1 message digest Wireshark code review
11:05 [Wireshark-commits] master-2.0 44e5946: L2TP: Correct L2TP over IP SHA1 message digest Wireshark code review
11:06 [Wireshark-commits] master-1.12 d752a7b: L2TP: Correct L2TP over IP SHA1 message digest Wireshark code review
11:27 [Wireshark-commits] master 921a844: Remove use of APPEND_BOOLEAN_FLAG in favor of proto_tree_add_bitmask_with_flags. Wireshark code review
12:00 [Wireshark-commits] master-2.0 4dc090e: Document tvb_get_guintXXX and tvb_get_ieee_XXX Wireshark code review
12:35 [Wireshark-commits] master 3cb5d94: Completely remove "old style" dissector support. Wireshark code review
12:35 [Wireshark-commits] master edb3388: Fix ISO C restricts enumerator values to range of 'int' [-Wpedantic] Wireshark code review
12:37 [Wireshark-commits] master a198f47: cmake: add asn1 target, avoid unnecessary rebuilds Wireshark code review
13:02 [Wireshark-commits] master 470c745: autotools: do not apply CFLAGS in reverse order Wireshark code review
15:30 [Wireshark-commits] master 986a870: Change TCP transmission window full message Wireshark code review
15:30 [Wireshark-commits] master-2.0 7008a2c: Change TCP transmission window full message Wireshark code review
15:45 [Wireshark-commits] master ff5719c: Lua: Switch URL to documentation to HTTPS Wireshark code review
15:46 [Wireshark-commits] master-2.0 b6a0392: Lua: Switch URL to documentation to HTTPS Wireshark code review
17:17 [Wireshark-commits] master 4980d50: Qt: Use correct column width when switching profile Wireshark code review
17:17 [Wireshark-commits] master-2.0 41bf1dd: Qt: Use correct column width when switching profile Wireshark code review
17:47 [Wireshark-commits] master a1f2951: Qt: clear new_visible_rows_ when closing a capture file Wireshark code review
17:47 [Wireshark-commits] master-2.0 be284fd: Qt: clear new_visible_rows_ when closing a capture file Wireshark code review
18:43 [Wireshark-commits] master c965fb0: Qt: make Files Set dialog modeless Wireshark code review
18:44 [Wireshark-commits] master-2.0 8f274bc: Qt: make Files Set dialog modeless Wireshark code review
18:46 [Wireshark-commits] master-2.0 600cc28: Don't check whether the C++ compiler supports a flag if there isn't one. Wireshark code review
19:44 [Wireshark-commits] master 9418701: Process the radio information internally for AiroPeek classic files. Wireshark code review
20:01 [Wireshark-commits] master e988e1c: Wrong field name for signal strength as a percentage. Wireshark code review
20:01 [Wireshark-commits] master-2.0 e3ef813: Wrong field name for signal strength as a percentage. Wireshark code review
20:14 [Wireshark-commits] master 42e3d9a: PCEP: support of "PCEP Extensions for Establishing Relationships Between Sets of LSPs", draft-ietf-pce-association-group-00 Wireshark code review
20:15 [Wireshark-commits] master 6da5168: [mp2t] use the correct file infomation for PCR detection Wireshark code review
20:26 [Wireshark-commits] master 677faf2: Don't allow the "Ethertype" pseudo-protocol's dissection to be disabled. Wireshark code review
20:26 [Wireshark-commits] master-2.0 22cb4c4: Don't allow the "Ethertype" pseudo-protocol's dissection to be disabled. Wireshark code review
21:19 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
21:34 [Wireshark-commits] master 0c6c08a: Change Lua tests to reflect the disappearance of WTAP_ENCAP_IEEE_802_11_AIROPEEK. Wireshark code review
21:36 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
21:38 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
21:44 [Wireshark-commits] master dcb3882: qt: add initializers to extcap dialog (CID 1297113) Wireshark code review
22:27 [Wireshark-commits] master e2d5089: Scan pcapng change time to unsigned Wireshark code review
November 27, 2015
05:00 [Wireshark-commits] master 10261d1: Remove manual setting of pinfo->current_proto. Wireshark code review
05:11 [Wireshark-commits] master 3606f80: Officially remove tvb_get_string and tvb_get_stringz. Wireshark code review
05:12 [Wireshark-commits] master 4f88659: MP4ves: fix no previous prototype for ... [-Wmissing-prototypes] Wireshark code review
05:12 [Wireshark-commits] master d4277c3: qt: add initializers (CID 1311487) Wireshark code review
05:12 [Wireshark-commits] master 15086a8: Qt: Make About->Plugins scrollable Wireshark code review
05:14 [Wireshark-commits] master 2c6824d: Qt: display RTP stream Y axis values as milliseconds Wireshark code review
05:16 [Wireshark-commits] master d9f777c: Qt: display RTP/IAX2 graph analysis arrival time as absolute instead of relative Wireshark code review
05:18 [Wireshark-commits] master-2.0 0621c38: Qt: display RTP stream Y axis values as milliseconds Wireshark code review
05:20 [Wireshark-commits] master-2.0 5687e94: Qt: display RTP/IAX2 graph analysis arrival time as absolute instead of relative Wireshark code review
05:22 [Wireshark-commits] master c51f207: [LDAP] Bugfix counting of search results. Wireshark code review
05:24 [Wireshark-commits] master-2.0 5eb60c0: [LDAP] Bugfix counting of search results. Wireshark code review
05:29 [Wireshark-commits] master f5b816d: Qt: Check zero recent column width Wireshark code review
05:30 [Wireshark-commits] master-2.0 036c404: Qt: Check zero recent column width Wireshark code review
05:32 [Wireshark-commits] master 20a41fa: NGHTTP2: Update to 1.5.0 Wireshark code review
05:34 [Wireshark-commits] master 58dc5b0: SMB sidsnooping: use sid as key and name as value Wireshark code review
05:37 [Wireshark-commits] master faf680f: configure.ac: Fix CXXFLAGS with optimization for HP-UX Wireshark code review
05:38 [Wireshark-commits] master-2.0 c986188: configure.ac: Fix CXXFLAGS with optimization for HP-UX Wireshark code review
07:36 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
08:03 [Wireshark-commits] master bec2fc0: sshdump: move build check Wireshark code review
08:57 [Wireshark-commits] master-2.0 20bfc3d: autotools: do not apply CFLAGS in reverse order Wireshark code review
12:15 [Wireshark-commits] master-1.12 56bb0ac: [LDAP] Bugfix counting of search results. Wireshark code review
12:58 [Wireshark-commits] master 24d5463: pcapng: Fix ISO C forbids conversion [-Wpedantic] Wireshark code review
13:13 [Wireshark-commits] master 6221c8d: wtap: Disable ISO C forbids conversion [-Wpedantic] Wireshark code review
13:42 [Wireshark-commits] master 1949a97: [COAP] Add "2.31 Continue" code Wireshark code review
16:34 [Wireshark-commits] master 946222c: Fix crash in Capture File Properties dialog Wireshark code review
16:34 [Wireshark-commits] master-2.0 6793a03: Fix crash in Capture File Properties dialog Wireshark code review
18:39 [Wireshark-commits] master 62b03da: Fix display of bytes as EBCDIC Wireshark code review
18:39 [Wireshark-commits] master-2.0 3cd7991: Fix display of bytes as EBCDIC Wireshark code review
18:50 [Wireshark-commits] master 56625dd: Qt: remove automatic horizontal scrolling when selecting a row Wireshark code review
18:50 [Wireshark-commits] master-2.0 7d6373e: Qt: remove automatic horizontal scrolling when selecting a row Wireshark code review
21:15 [Wireshark-commits] master d7f1243: Fix crash in UDP Multicast Streams dialog Wireshark code review
21:15 [Wireshark-commits] master-2.0 916ee53: Fix crash in UDP Multicast Streams dialog Wireshark code review
21:40 [Wireshark-commits] master-2.0 a082839: Remove 'filetap' residue from .gitignore Wireshark code review
22:22 [Wireshark-commits] master 7c8314a: Fix ISO C forbids an empty translation unit [-Wpedantic] (airpcap) Wireshark code review
November 28, 2015
07:39 [Wireshark-commits] master bc4954f: [ASN1 custom dissectors]Add the abillity to build custom ASN1 based dissectors. Wireshark code review
07:44 [Wireshark-commits] master df83e45: Qt: fix "go to packet" broken by g56625dd Wireshark code review
07:45 [Wireshark-commits] master-2.0 afb7b42: Qt: fix "go to packet" broken by g56625dd Wireshark code review
07:46 [Wireshark-commits] master 75da696: Qt: set focus to text box when opening search frame Wireshark code review
07:47 [Wireshark-commits] master-2.0 8f96d53: Qt: set focus to text box when opening search frame Wireshark code review
07:54 [Wireshark-commits] master 05121be: Qt: reload after applying parameters in UDP multicast dialog Wireshark code review
07:55 [Wireshark-commits] master-2.0 18a08f4: Qt: reload after applying parameters in UDP multicast dialog Wireshark code review
09:20 [Wireshark-commits] master 44d98da: Remove the GSSAPI specific members out of packet_info structure. Wireshark code review
09:23 [Wireshark-commits] master 38c53f9: Sanity check iSeries packet length to prevent heap-based buffer overflow. Wireshark code review
09:45 [Wireshark-commits] master-2.0 68c9cc0: [mp2t] use the correct file infomation for PCR detection Wireshark code review
09:47 [Wireshark-commits] master 40b2831: Add boundary check for 802.11 decryption Wireshark code review
10:06 [Wireshark-commits] master-2.0 bf1fa88: Add boundary check for 802.11 decryption Wireshark code review
10:41 [Wireshark-commits] master-1.12 a6e8fc8: Add boundary check for 802.11 decryption Wireshark code review
11:40 [Wireshark-commits] master-2.0 0494240: Qt: Make About->Plugins scrollable Wireshark code review
12:12 [Wireshark-commits] master aaa28a9: Diameter: check IPv6 prefix length before copying it in e_in6_addr structure Wireshark code review
12:14 [Wireshark-commits] master-2.0 92c892e: Diameter: check IPv6 prefix length before copying it in e_in6_addr structure Wireshark code review
12:40 [Wireshark-commits] master-1.12 644bc78: Diameter: check IPv6 prefix length before copying it in e_in6_addr structure Wireshark code review
13:51 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
16:13 [Wireshark-commits] master 56baca6: RSVP: copy all rsvp_request_key info in file scope Wireshark code review
19:05 [Wireshark-commits] master d3e40e4: ISIS: Add Expert Info when undecoded/unknown CLV Wireshark code review
19:07 [Wireshark-commits] master 2f5849c: IS-IS: Add Instance ID TLV (RFC 6822) Wireshark code review
19:13 [Wireshark-commits] master 41d4dab: Qt: Validate capture filter before showing packet list. Wireshark code review
19:14 [Wireshark-commits] master-2.0 01e5ec7: Qt: Validate capture filter before showing packet list. Wireshark code review
19:23 [Wireshark-commits] master b8fa3d4: vwr: fix buffer overrun in getRate Wireshark code review
19:23 [Wireshark-commits] master-2.0 135c8f0: vwr: fix buffer overrun in getRate Wireshark code review
19:23 [Wireshark-commits] master-1.12 fef89fc: vwr: fix buffer overrun in getRate Wireshark code review
20:12 [Wireshark-commits] master dba1751: Make it more obvious why no bounds checks are necessary for 11n. Wireshark code review
20:18 [Wireshark-commits] master ff209f5: Make the rate tables static and const. Wireshark code review
21:34 [Wireshark-commits] master efe1b7a: LDAP: fix indent (use 2 spaces) Wireshark code review
November 29, 2015
00:03 [Wireshark-commits] master cfc47c1: Replace my_dgt_tbcd_unpack with the safer tvb_bcd_dig_to_wmem_packet_str. Wireshark code review
00:13 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
00:15 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
00:25 [Wireshark-commits] master 5e6d45c: Make address_to_display() use proper (non-)constness Wireshark code review
00:26 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
03:30 [Wireshark-commits] master f777d68: Fix Ubuntu compile error. Wireshark code review
08:48 [Wireshark-commits] buildbot failure in Wireshark 2.0 on Fuzz Test buildbot-no-reply
09:27 [Wireshark-commits] master-2.0 9764685: RSVP: copy all rsvp_request_key info in file scope Wireshark code review
09:52 [Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test buildbot-no-reply
09:57 [Wireshark-commits] master-1.12 5d20997: RSVP: copy all rsvp_request_key info in file scope Wireshark code review
10:57 [Wireshark-commits] master 9b12818: IPv6: Fix RPL routing header computed address count if ip6r_len == 0 Wireshark code review
10:59 [Wireshark-commits] master-1.12 7adf696: IPv6: Fix RPL routing header computed address count if ip6r_len == 0 Wireshark code review
11:20 [Wireshark-commits] master 3749e98: Support building the X11 dissector outside the source tree. Wireshark code review
13:28 [Wireshark-commits] master-2.0 ea96dda: IPv6: Fix RPL routing header computed address count if ip6r_len == 0 Wireshark code review
13:38 [Wireshark-commits] master 15edc8d: Fix bugs introduced in gcfc47c1 Wireshark code review
14:06 [Wireshark-commits] master 5f713f2: http: detect multiple names in Transfer-Encoding header Wireshark code review
16:14 [Wireshark-commits] master 1acb281: [Automatic update for 2015-11-29] Wireshark code review
16:22 [Wireshark-commits] master-2.0 b75548a: [Automatic update for 2015-11-29] Wireshark code review
16:30 [Wireshark-commits] master-1.12 8f04763: [Automatic update for 2015-11-29] Wireshark code review
17:23 [Wireshark-commits] master-2.0 61dcd11: Replace my_dgt_tbcd_unpack with the safer tvb_bcd_dig_to_wmem_packet_str. Wireshark code review
17:35 [Wireshark-commits] master-1.12 8194323: Replace my_dgt_tbcd_unpack with the safer tvb_bcd_dig_to_wmem_packet_str. Wireshark code review
17:40 [Wireshark-commits] master 6952c1c: USB: allow usb string descriptor short read Wireshark code review
18:09 [Wireshark-commits] master 5c620ff: Docbook: We no longer support Windows Server 2003. Wireshark code review
18:13 [Wireshark-commits] master-2.0 e3ad20c: Docbook: We no longer support Windows Server 2003. Wireshark code review
18:56 [Wireshark-commits] master 257938f: GSM SMS: fix reassembly of UCS2 encoded SMS Wireshark code review
18:57 [Wireshark-commits] master-2.0 af152e4: GSM SMS: fix reassembly of UCS2 encoded SMS Wireshark code review
19:00 [Wireshark-commits] master e75f74a: Qt: Check capture filter only once when selecting interface(s) Wireshark code review
19:01 [Wireshark-commits] master-2.0 bb206e8: Qt: Check capture filter only once when selecting interface(s) Wireshark code review
19:45 [Wireshark-commits] master-1.12 01433a4: GSM SMS: fix reassembly of UCS2 encoded SMS Wireshark code review
21:38 [Wireshark-commits] master 2932596: IPv6: Add ipv6extprotostr() to ipproto.h Wireshark code review
21:54 [Wireshark-commits] master e639a13: cfutils.c: Fix ISO C forbids an empty translation unit [-Wpedantic] Wireshark code review
22:01 [Wireshark-commits] master 185911d: Add bounds checking to find_signature. Wireshark code review
22:01 [Wireshark-commits] master-2.0 e4267dd: Add bounds checking to find_signature. Wireshark code review
22:01 [Wireshark-commits] master-1.12 51ccf92: Add bounds checking to find_signature. Wireshark code review
22:31 [Wireshark-commits] master 22d9cea: Art-Net: Add missing DHCP-Enabled flags where needed Wireshark code review
November 30, 2015
01:40 [Wireshark-commits] master 338da1c: Fix out-of-bounds read in ascend_seek. Wireshark code review
01:40 [Wireshark-commits] master-2.0 7abfa36: Fix out-of-bounds read in ascend_seek. Wireshark code review
01:41 [Wireshark-commits] master-1.12 9cf09cf: Fix out-of-bounds read in ascend_seek. Wireshark code review
04:30 [Wireshark-commits] master 943be4b: Treat invalid (negative or too-large) values in the packet header as errors. Wireshark code review
05:00 [Wireshark-commits] master 51ed8f4: Add some comments explaining what some code is doing. Wireshark code review
08:32 [Wireshark-commits] master 019446a: Handle Date: headers differently from other headers. Wireshark code review
08:43 [Wireshark-commits] master be2e099: CMake: Fix breakage with CMake 3 Wireshark code review
09:14 [Wireshark-commits] master 370d32d: Remove some THROWs and just return when lengths are bad. Wireshark code review
14:25 [Wireshark-commits] master b3b3062: mcast_stream_dlg: fix no previous prototype for function 'mcaststream_dlg_update' [-Wmissing-prototypes] Wireshark code review
18:28 [Wireshark-commits] master dc9f782: Add BASE_ALLOW_ZERO for byte arrays that are validly zero sized. Wireshark code review
20:50 [Wireshark-commits] master 78d664c: main_window: fix no previous prototype for function 'plugin_if_mainwindow_gotoframe' [-Wmissing-prototypes] Wireshark code review
20:54 [Wireshark-commits] master 83516dc: SMB2: fix problems with dissection of error response Wireshark code review
20:59 [Wireshark-commits] master d59335b: adb service/logcat : fix Consider inspecting this expression. The expression is excessive or contains a misprint found by PVS Studio (V590) Wireshark code review
21:03 [Wireshark-commits] master 9bd05a2: IMAP: fix Recurring check found by PVS Studio (V571) Wireshark code review
21:05 [Wireshark-commits] master a1d1bd2: mausb: Fix A part of conditional expression is always true found by PVS Studio (V560) Wireshark code review
21:06 [Wireshark-commits] master 0160397: mausb: The '&' operator is applied to bool type value found by PVS Studio (V564) Wireshark code review
21:33 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply

Mail converted by MHonArc