Wireshark-commits: [Wireshark-commits] master fb5e9e4: Convert AFS dissector to use ptvcursor API.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 1 Jun 2015 15:59:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb5e9e43c1429f1073a90e7dc92f79afaf18cec0
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fb5e9e4 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Convert AFS dissector to use ptvcursor API.
    
    The dissector was written in all macros, presumably to get just a single lines to display a field.  The ptvcursor API is good for that, and using it over macros more than halves the object size.  Real code (vs macros) is also much easier to use in a debugger.  It also makes it easier for the check* scripts to find possible errors.
    
    Also eliminate proto_tree_add_text.
    
    Change-Id: Id07e015b5a2d1a98a4b36e40a426442d826d9a09
    Reviewed-on: https://code.wireshark.org/review/8723
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  11b3d64   Eliminate proto_tree_add_text from packet-sip.c
    adds  fb5e9e4   Convert AFS dissector to use ptvcursor API.


Summary of changes:
 epan/dissectors/packet-afs.c | 2490 ++++++++++++++++++++----------------------
 1 file changed, 1156 insertions(+), 1334 deletions(-)