Wireshark-commits, June 2014
June 01, 2014
09:19 [Wireshark-commits] master d55bb72: Just have one value_string table for OUIs. Wireshark code review
15:30 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz-Test buildbot-no-reply
19:58 [Wireshark-commits] master 6f15d7a: Fix /home/jmayer/work/wireshark/git/wsutil/nghttp2/nghttp2_hd.c:996:12: error: ‘check_index_range’ defined but not used [-Werror=unused-function] static int check_index_range(nghttp2_hd_context *context, size_t idx) ^ cc1: all warnings being treated as errors Wireshark code review
20:04 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
20:05 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
20:06 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
20:06 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
20:08 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
20:19 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
21:18 [Wireshark-commits] master 48440ac: [Automatic manuf, services and enterprise-numbers update for 2014-06-01] Wireshark code review
21:18 [Wireshark-commits] master-1.12 52d1efa: [Automatic manuf, services and enterprise-numbers update for 2014-06-01] Wireshark code review
21:19 [Wireshark-commits] master-1.10 0be6fee: [Automatic manuf, services and enterprise-numbers update for 2014-06-01] Wireshark code review
21:19 [Wireshark-commits] master-1.8 6cfa2b6: [Automatic manuf, services and enterprise-numbers update for 2014-06-01] Wireshark code review
21:29 [Wireshark-commits] master 3883408: Fix type/length mismatch messages for FT_ETHER. Wireshark code review
21:55 [Wireshark-commits] master 090f568: Make this comple whether assertions are enabled or not. Wireshark code review
June 02, 2014
15:19 [Wireshark-commits] master 1ca8d5f: use bus_id from the conversation struct Wireshark code review
15:31 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
16:23 [Wireshark-commits] master 13513a1: HTTP2 : Max value for type is now 0x0B (BLOCKED type), update the heuristic Wireshark code review
18:33 [Wireshark-commits] master 75e53a1: EIGRP Sequence TLV Dissector Patch Wireshark code review
19:18 [Wireshark-commits] master-1.12 aec0627: EIGRP Sequence TLV Dissector Patch Wireshark code review
20:13 [Wireshark-commits] master 58348ba: get the USB conversation struct as quickly as possible at first, read only the info required to fetch the conversation struct Wireshark code review
20:14 [Wireshark-commits] master cee6c5f: use is_request from the conversation Wireshark code review
20:14 [Wireshark-commits] master ea8d6da: generate the usb tree outside of the if statement Wireshark code review
21:16 [Wireshark-commits] master 3bf635b: Update TLS extensions Wireshark code review
June 03, 2014
01:35 [Wireshark-commits] master fae9726: packet-ipmi...: Various cleanups: Wireshark code review
01:40 [Wireshark-commits] master e05dc82: Add a few more ad-hoc validations of the hf[] FIELDCONVERT field. Wireshark code review
05:09 [Wireshark-commits] master f9f3cf0: Make TCP functions available for plugins Wireshark code review
05:54 [Wireshark-commits] master fbf1873: Make decode_udp_ports() function available for plugins Wireshark code review
06:20 [Wireshark-commits] master de9efa1: LLDP : Fix bug in mdi_power_source hf. While it compiles fine, hits an assert in add_string : failed assertion "hfinfo->type == FT_STRING || hfinfo->type == FT_STRINGZ || hfinfo->type == FT_STRINGZPAD" Wireshark code review
07:55 [Wireshark-commits] master-1.12 e50fe32: LLDP : Fix bug in mdi_power_source hf. While it compiles fine, hits an assert in add_string : failed assertion "hfinfo->type == FT_STRING || hfinfo->type == FT_STRINGZ || hfinfo->type == FT_STRINGZPAD" Wireshark code review
09:25 [Wireshark-commits] master-1.12 52b1ca6: Make TCP and UDP functions available for plugins Wireshark code review
12:39 [Wireshark-commits] master 3d03216: packet-bencode: proto_tree_add_text -> somthing filterable Wireshark code review
13:09 [Wireshark-commits] master cd4ba3d: make the PCR value filterable Wireshark code review
14:34 [Wireshark-commits] master 3eacdda: Change ep_alloc() to wmem_new() change depcrecated API. Wireshark code review
15:05 [Wireshark-commits] master 0a0a4c7: USB: Try to make Mac os 10.5 buildbot Happy Wireshark code review
15:07 [Wireshark-commits] master-1.12 5c5996d: Qt: Export Object * Fix indent (remove tabs) * Add title to the window Wireshark code review
15:07 [Wireshark-commits] master 9389d78: Qt: Export Object * Fix indent (remove tabs) * Add title to the window Wireshark code review
18:01 [Wireshark-commits] master c5de173: MBIM: do not access to hash map when it is not initialized yet Wireshark code review
18:15 [Wireshark-commits] master-1.12 e4cb1a6: MBIM: do not access to hash map when it is not initialized yet Wireshark code review
June 04, 2014
00:29 [Wireshark-commits] master 88581a6: Added usb_set_addr helper function Wireshark code review
00:49 [Wireshark-commits] master c6d175e: Guarantee that open routines are initialized Wireshark code review
00:56 [Wireshark-commits] master c94d2e6: MAUSB dissector uses USB addresses Wireshark code review
04:21 [Wireshark-commits] master 4e5424a: packet-q931.c: proto_tree_add_text -> something filterable. Wireshark code review
04:23 [Wireshark-commits] master 3bdc0f9: packet-ansi_801.c: proto_tree_add_text -> somthing filterable Wireshark code review
04:24 [Wireshark-commits] master a3ebd0d: packet-q2931.c: proto_tree_add_text -> something filterable. Wireshark code review
04:26 [Wireshark-commits] master 1f17d0c: Use the -Ox compiler option. Change-Id: I5d216d132485f6d2f8c63fa5a10b22e884e26b02 Reviewed-on: https://code.wireshark.org/review/1937 Reviewed-by: Evan Huus <eapache@xxxxxxxxx> Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> Wireshark code review
04:27 [Wireshark-commits] master 09b5361: This fix now allows SASL/GSS-API with integrity only to be properly dissected in that we now properly indicate the checksum and provide the wrapped token to the LDAP dissector to dissect. Wireshark code review
04:53 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
06:14 [Wireshark-commits] master f0cf649: EPL: Reassemble the splitted payload Wireshark code review
06:21 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
06:23 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
07:27 [Wireshark-commits] master c44c153: Try to please the OSX build bot Wireshark code review
07:35 [Wireshark-commits] master 963a498: Fix packet-q931.c:604:25: error: 'ti' may be used uninitialized in this function [-Werror=uninitialized] Wireshark code review
12:25 [Wireshark-commits] master 4b9b29b: Clang complained about non initialized variable. Wireshark code review
14:55 [Wireshark-commits] master a4c3061: Use -O2 option when compiling with MSVC Wireshark code review
17:42 [Wireshark-commits] master 91afb5a: The subtype_seek_read() functions populate *phdr, not wth->phdr. So don't use the values. This problem show up on pcapng files resulting from captures of multiple interfaces. Wireshark code review
17:43 [Wireshark-commits] master-1.12 d9f4d37: The subtype_seek_read() functions populate *phdr, not wth->phdr. So don't use the values. This problem show up on pcapng files resulting from captures of multiple interfaces. Wireshark code review
19:29 [Wireshark-commits] master 3d23cbd: (Trivial) Fix a typo. Wireshark code review
19:30 [Wireshark-commits] master dc02627: tshark.c: Change "Live captures can only be saved in libpcap format" to "[...] in pcap or pcapng format" Wireshark code review
19:31 [Wireshark-commits] master 68a1b55: tshark.c: 'tshark -F pcap -w ...' should create a pcap (not pcapng) file; fixes Bug #9991. Wireshark code review
19:34 [Wireshark-commits] master-1.12 5ba06c9: (Trivial) Fix a typo. Wireshark code review
19:35 [Wireshark-commits] master-1.12 60f1288: tshark.c: Change "Live captures can only be saved in libpcap format" to "[...] in pcap or pcapng format" Wireshark code review
19:36 [Wireshark-commits] master-1.12 5756a84: tshark.c: 'tshark -F pcap -w ...' should create a pcap (not pcapng) file; fixes Bug #9991. Wireshark code review
20:02 [Wireshark-commits] master-1.10 eab9d6b: tshark.c: 'tshark -F pcap -w ...' should create a pcap (not pcapng) file; fixes Bug #9991. Wireshark code review
20:13 [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX-10.6-x64 buildbot-no-reply
20:18 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows-7-x64 buildbot-no-reply
20:18 [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX-10.5-x86 buildbot-no-reply
20:20 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Ubuntu-12.04-x64 buildbot-no-reply
20:22 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows-XP-x86 buildbot-no-reply
20:24 [Wireshark-commits] master-1.10 451796d: Revert "tshark.c: 'tshark -F pcap -w ...' should create a pcap (not pcapng) file; fixes Bug #9991." Wireshark code review
20:58 [Wireshark-commits] master-1.10 460db8a: tshark.c: Backport 68a1b55 (with change) from Dev; Also: backport dc02627 Wireshark code review
21:39 [Wireshark-commits] wireshark-win32-libs rev 446: / /trunk/packages/: gnutls-3.1.22-2.3-win32ws.zip /trunk/: README.txt pascal
21:41 [Wireshark-commits] wireshark-win64-libs rev 400: / /trunk/packages/: gnutls-3.1.22-2.3-win64ws.zip /trunk/: README.txt pascal
22:12 [Wireshark-commits] master 95b694f: Fix message about detection of asciidoc package (would always report not found before). Wireshark code review
23:05 [Wireshark-commits] master 5defb48: Do not rebuild developers-guide.xml on each run. Do this only when required. Wireshark code review
23:20 [Wireshark-commits] master fc13d22: Fix typo that would have hit once conversion of the users guide to asciidoc would have started Wireshark code review
June 05, 2014
04:12 [Wireshark-commits] master 653dd75: simplify PCR calculation Wireshark code review
04:17 [Wireshark-commits] master-1.8 be509e2: tshark.c: Change "Live captures can only be saved in libpcap format" to "[...] in libpcap or pcapng format" Wireshark code review
04:17 [Wireshark-commits] master-1.8 4ee4fc11: tshark.c: 'tshark -F libpcap -w ...' should create a libpcap (not pcapng) file; fixes Bug #9991. Wireshark code review
05:13 [Wireshark-commits] wireshark-win32-libs rev 447: /tags/2014-06-05/ /tags/2014-06-05/: README.txt README.txt /tags/2014-06-05/packages/: gnutls-3.1.22-2.3-win32ws.zip pascal
05:29 [Wireshark-commits] wireshark-win64-libs rev 401: /tags/2014-06-05/ /tags/2014-06-05/: README.txt README.txt /tags/2014-06-05/packages/: gnutls-3.1.22-2.3-win64ws.zip pascal
05:45 [Wireshark-commits] master eaa571a: Added generic setup dissector for USB control transfers Wireshark code review
05:47 [Wireshark-commits] master 5c03010: Moved dissection of standard setup requests to own function Wireshark code review
05:47 [Wireshark-commits] master c49fcec: Moved dissection of standard setup responses to own function Wireshark code review
08:02 [Wireshark-commits] master cd6e2ea: STUN: Add support of MS-TURN (Used by Lync) Wireshark code review
08:07 [Wireshark-commits] master 6db547f: STUN: Add error code from MS-ICE2BWM Wireshark code review
09:26 [Wireshark-commits] master-1.12 eb79329: Set PLUGIN_INSTALL_DIR properly for wireshark.pc Wireshark code review
09:27 [Wireshark-commits] master-1.12 8bcaca0: Honor configured CMAKE_INSTALL_LIBDIR when installing libraries Wireshark code review
09:27 [Wireshark-commits] master-1.12 77df529: Fix wireshark.pc install destination Wireshark code review
11:26 [Wireshark-commits] master 5234972: Make socpe a local variable, can be used if we change the g_slist to a wmem_list. Wireshark code review
11:48 [Wireshark-commits] master 5c48774: sip: avoid calling tvb_format_text() when tree is not visible. Wireshark code review
13:26 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
14:32 [Wireshark-commits] master 7e77631: Add a handle to dissect sip userinfo. Wireshark code review
17:59 [Wireshark-commits] master 6ac68b1: When have more than one SDU in the same RLC PDU, make sure output from all of them stays in the INFO column Wireshark code review
18:00 [Wireshark-commits] master 29222ab: Add Object (file) export for files transferred over TFTP. Updated following review comments. Wireshark code review
18:21 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
22:03 [Wireshark-commits] master 17b98ad: Add a missing header file, and add new file to cmake build Wireshark code review
23:33 [Wireshark-commits] master-1.12 25bb29a: Windows packaging and release note updates. Wireshark code review
23:48 [Wireshark-commits] master a537b3f: Windows packaging and release note updates. Wireshark code review
June 06, 2014
00:24 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
06:43 [Wireshark-commits] master 977a811: IPMI trace dissector (without PCAP-dependent part). Wireshark code review
10:17 [Wireshark-commits] master 65abca6: LLDP-MED Cleanup Wireshark code review
13:30 [Wireshark-commits] master 38fc8ba: WiMAX: fix incorrect type for include_cor2_changes variable Wireshark code review
13:37 [Wireshark-commits] master 52fe0aa: (trivial) changed when transfer info is set Wireshark code review
14:04 [Wireshark-commits] master e27a24c: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
14:05 [Wireshark-commits] master be23f16: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
14:05 [Wireshark-commits] master ed2bb85: Fix Dereference of null pointer found by Clang analyzer Wireshark code review
14:14 [Wireshark-commits] master bd84767: Added tap queue helper function to USB dissector Wireshark code review
14:47 [Wireshark-commits] master 97f0fb0: Fixed Fencing for Multiple MAUSB Packets in 1 TCP Packet. Wireshark code review
15:33 [Wireshark-commits] master ad7b538: Upgrade Windows builds to GnuTLS 3.1.22 and Gcrypt 1.6.0 Wireshark code review
15:49 [Wireshark-commits] master 60ce7bc: Add TFTP export for Qt too Wireshark code review
17:23 [Wireshark-commits] master dbb9453: Q.2931: sort extended value string 'q2931_message_type_vals' in increasing order Wireshark code review
18:40 [Wireshark-commits] master 6ec0909: Comment out an empty section. Wireshark code review
19:17 [Wireshark-commits] master 2b2fbff: Switch to a launch daemon for ChmodBPF. Wireshark code review
19:17 [Wireshark-commits] master-1.12 51ef489: Switch to a launch daemon for ChmodBPF. Wireshark code review
19:24 [Wireshark-commits] master-1.12 5741a40: Try to fix OS X GTK+ app creation. Wireshark code review
20:07 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
20:45 [Wireshark-commits] master-1.10 540f061: Switch to a launch daemon for ChmodBPF. Wireshark code review
20:54 [Wireshark-commits] master-1.8 97898a2: Switch to a launch daemon for ChmodBPF. Wireshark code review
21:40 [Wireshark-commits] master 63dc129: Get rid of some stuff left over from the days of drag-install. Wireshark code review
23:18 [Wireshark-commits] master 3169939: Moved dissection of setup field to own function Wireshark code review
23:42 [Wireshark-commits] master b69642d: Misc lldp cleanup. I'm cheating a bit here, hf_media_loc_long & hf_media_loc_lat need a 5byte bitmask, but the bitmask field in hf is restricted to guint32 Wireshark code review
June 07, 2014
06:43 [Wireshark-commits] master b319a67: When installing the launch daemon, get rid of the old startup item. Wireshark code review
06:45 [Wireshark-commits] master-1.12 003746c: When installing the launch daemon, get rid of the old startup item. Wireshark code review
06:47 [Wireshark-commits] master-1.10 6487669: When installing the launch daemon, get rid of the old startup item. Wireshark code review
06:48 [Wireshark-commits] master-1.8 ec607cd: When installing the launch daemon, get rid of the old startup item. Wireshark code review
09:10 [Wireshark-commits] master-1.12 a8df07c: Use -O2 option when compiling with MSVC Wireshark code review
10:23 [Wireshark-commits] master a048dc1: Updates as requested Wireshark code review
11:36 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
15:41 [Wireshark-commits] master 73217d9: tvb_new_subset -> tvb_new_subset_length when length parameters are equal. tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Wireshark code review
17:22 [Wireshark-commits] master b8e40b6: Added usb_get_trans_info() function Wireshark code review
17:22 [Wireshark-commits] master 0c62f06: USB: put back URB setup to parent tree like it was before g3169939 Wireshark code review
17:42 [Wireshark-commits] master 78bc006: Removed MAUSB DWORD-Aligned Length Check Wireshark code review
17:43 [Wireshark-commits] master 09f53d8: Per Spec update, SetUSBDevAddrReq now contains data Wireshark code review
17:47 [Wireshark-commits] master 39ca18d: Only nuke the startup item once we've installed the launch daemon. Wireshark code review
17:47 [Wireshark-commits] master-1.12 9cf44c1: Only nuke the startup item once we've installed the launch daemon. Wireshark code review
17:48 [Wireshark-commits] master-1.10 9afa5d6: Only nuke the startup item once we've installed the launch daemon. Wireshark code review
17:48 [Wireshark-commits] master-1.8 b8e54bc: Only nuke the startup item once we've installed the launch daemon. Wireshark code review
18:55 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
19:10 [Wireshark-commits] master 39cdb98: PEEKREMOTE packets don't appear to have Atheros padding. Wireshark code review
19:14 [Wireshark-commits] master-1.12 94dccc7: We need a "wlan_datapad" dissector as well. Wireshark code review
19:15 [Wireshark-commits] master-1.12 ff44f34: PEEKREMOTE packets don't appear to have Atheros padding. Wireshark code review
19:19 [Wireshark-commits] master-1.10 348942c: PEEKREMOTE packets don't appear to have Atheros padding. Wireshark code review
19:20 [Wireshark-commits] master-1.8 0e8a2bb: PEEKREMOTE packets don't appear to have Atheros padding. Wireshark code review
June 08, 2014
11:40 [Wireshark-commits] master-1.8 c34a63b: Revert "Fix the fuzz failure reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8940" Wireshark code review
12:13 [Wireshark-commits] master 5614601: Update CMake build for win32 to build QT again, and to find GLib and GThread libs Wireshark code review
14:36 [Wireshark-commits] master 9b49910: Linking against libgettext and libm got broken by Wireshark code review
15:32 [Wireshark-commits] master 97e1491: Sync .deb packaging from Debian Wireshark code review
15:33 [Wireshark-commits] master 6d783f2: Don't ship libfiletap in the .deb packages yet Wireshark code review
15:33 [Wireshark-commits] master cb4ec16: .deb package format is 'native' Wireshark code review
15:45 [Wireshark-commits] master fc3a804: [Automatic manuf, services and enterprise-numbers update for 2014-06-08] Wireshark code review
15:45 [Wireshark-commits] master-1.12 d801c7f: [Automatic manuf, services and enterprise-numbers update for 2014-06-08] Wireshark code review
15:45 [Wireshark-commits] master-1.10 d88fb71: [Automatic manuf, services and enterprise-numbers update for 2014-06-08] Wireshark code review
15:45 [Wireshark-commits] master-1.8 adc0d9f: [Automatic manuf, services and enterprise-numbers update for 2014-06-08] Wireshark code review
15:47 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
15:49 [Wireshark-commits] master-1.12 afa09b0: Upgrade Windows builds to GnuTLS 3.1.22 and Gcrypt 1.6.0 Wireshark code review
17:51 [Wireshark-commits] master 671d6c9: Fix make dist Wireshark code review
17:51 [Wireshark-commits] master 4f6e021: Add GPLv2+ license header to headers-check.c as per private email from the author. Wireshark code review
19:19 [Wireshark-commits] master 7de3d23: Fix Wireshark's name in Vietnamese translation Wireshark code review
19:28 [Wireshark-commits] master 1fcc673: Bugfix pdml2html.xsl fails to expand multiple identical 'proto' tags Wireshark code review
20:34 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
June 09, 2014
01:48 [Wireshark-commits] master e04f321: Fix make debian-package Wireshark code review
01:48 [Wireshark-commits] master c2f3e0a: Added TLV 16 for MDD message Wireshark code review
01:49 [Wireshark-commits] master 8996051: IEEE 80211: fix dissection of HT Capabilities Wireshark code review
02:07 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
02:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
02:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
03:27 [Wireshark-commits] buildbot failure in Wireshark 1.8 on Fuzz-Test buildbot-no-reply
05:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
07:01 [Wireshark-commits] master-1.12 0c4095c: Try to fix the problems with the SPNEGO negTokenInit differences in Microsoft implementations Wireshark code review
07:51 [Wireshark-commits] master-1.12 1194ef7: IEEE 80211: fix dissection of HT Capabilities Wireshark code review
08:54 [Wireshark-commits] master 39ac6f2: HPM.2 IPMI Trace Data encapsulation format Wireshark code review
08:59 [Wireshark-commits] master 05fcdc3: Windows does not allow data copy between dlls, declare the true_false_string locally. Wireshark code review
09:06 [Wireshark-commits] master-1.8 ac2b854: IEEE 80211: fix dissection of HT Capabilities Wireshark code review
09:25 [Wireshark-commits] master-1.10 8c900b4: IEEE 80211: fix dissection of HT Capabilities Wireshark code review
09:37 [Wireshark-commits] master-1.8 aa50774: Fix a typo in release notes Wireshark code review
10:47 [Wireshark-commits] master f33ead5: remove all checks for if (tree) Wireshark code review
10:52 [Wireshark-commits] master 6669566: Try to fix acket-tftp.c:207: error: \u2018data_tvb\u2019 may be used uninitialized in this function. Wireshark code review
12:02 [Wireshark-commits] master fcb710b: Add sse4.2 optimized function ws_mempbrk_sse42() Wireshark code review
12:08 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
12:09 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
12:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
12:49 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
13:33 [Wireshark-commits] master d3104c2: Make buildbot Happy about shadow index variable... Wireshark code review
13:35 [Wireshark-commits] master bea4106: use the direction info from the conversation struct Wireshark code review
14:58 [Wireshark-commits] master-1.12 6adf20b: Sync .deb packaging from Debian Wireshark code review
14:58 [Wireshark-commits] master-1.12 321ec17: Don't ship libfiletap in the .deb packages yet Wireshark code review
14:59 [Wireshark-commits] master-1.12 4736f58: .deb package format is 'native' Wireshark code review
14:59 [Wireshark-commits] master-1.12 d2efa6c: Add GPLv2+ license header to headers-check.c as per private email from the author. Wireshark code review
14:59 [Wireshark-commits] master-1.12 338ad80: Fix Wireshark's name in Vietnamese translation Wireshark code review
15:00 [Wireshark-commits] master-1.12 b62f155: Improve the fix by removing code that miss dissects SPNEGO stuff ... as well as remove redundant stuff from the spnego.cnf file. Wireshark code review
15:09 [Wireshark-commits] master 9dbf2ff: fill the conversation info struct in dissect_linux_usb_pseudo_header() Wireshark code review
15:31 [Wireshark-commits] master 8e8a4ce: Try to fix the builds. Wireshark code review
15:37 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
16:00 [Wireshark-commits] master f9254e5: Fix a copy paste error. Wireshark code review
16:24 [Wireshark-commits] master c2a187f: Try to fix OSX build Wireshark code review
16:36 [Wireshark-commits] master 618187a: Hopfully thiw will make the Solaris build going. Wireshark code review
16:36 [Wireshark-commits] master-1.12 fa85cc9: Fix make dist Wireshark code review
16:50 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
17:04 [Wireshark-commits] master-1.12 31783cc: Copy over git-compare-abis.sh from master-1.10. Wireshark code review
17:08 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
17:08 [Wireshark-commits] master-1.12 174cd47: Add back Balint's copyright. Wireshark code review
17:09 [Wireshark-commits] master-1.10 cab89dc: Add back Balint's copyright. Wireshark code review
17:19 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
19:30 [Wireshark-commits] master c9621e2: We must include config.h to have HAVE_SSE42 Wireshark code review
20:08 [Wireshark-commits] master 3c37630: Dissection of USB setup data in MA USB data packets Wireshark code review
22:00 [Wireshark-commits] master 9538d1c: Fix CMake build. Wireshark code review
22:02 [Wireshark-commits] master a08cbe7: Use only dpkg-buildpackage for building .debs Wireshark code review
22:55 [Wireshark-commits] master-1.8 ebaeacd: Release note updates for 1.8.15. Wireshark code review
22:55 [Wireshark-commits] master-1.10 05d09fc: Release note updates for 1.10.8. Wireshark code review
23:56 [Wireshark-commits] master 8c4a139: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
23:56 [Wireshark-commits] master f627ee8: Add Modelines info Wireshark code review
23:57 [Wireshark-commits] master 26ad824: Add Modelines info Wireshark code review
23:58 [Wireshark-commits] master 9516675: Add modelines Wireshark code review
June 10, 2014
00:58 [Wireshark-commits] master 8878d77: Current test for GIT_DIR introduced in changeset Ie1560c372e23e58fb0e310f681388b5e1a65ba5b doesn't seem to be working correctly on bash 4.3.18 : .git/hooks/pre-commit: line 11: .git: command not found Wireshark code review
03:16 [Wireshark-commits] master-1.8 83ca675: Update info re Bug # 9991: '-F libpcap' (not '-F pcap') is used in Wireshark-1.8. Wireshark code review
08:12 [Wireshark-commits] master 4571283: CPUID improvements Wireshark code review
08:13 [Wireshark-commits] master d041b1e: WS mempbrk SEE4.2: Fix indent (use 2spaces) and add Modelines info Wireshark code review
08:15 [Wireshark-commits] master dc904a1: rlc lte graph: Assigned value is garbage or undefined (clang analyzer) Wireshark code review
08:18 [Wireshark-commits] master 2f13ccc: CAPWAP: Display incorrect value for Wireless IEEE802.11 RSSI and Data Rate Wireshark code review
08:20 [Wireshark-commits] master 5cff2b6: CAPWAP: Fix soft-deprecated APIs warning Wireshark code review
08:33 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
08:58 [Wireshark-commits] master e1f0ee4: Mark an unused parameter as such. Wireshark code review
09:00 [Wireshark-commits] master 5d7b59a: Fix Buildbot Mac OS: /wsutil/ws_cpuid.h:56: warning: unused parameter 'CPUInfo' Wireshark code review
11:36 [Wireshark-commits] master e7fbf05: 3GPP NAS: add dissection of MSISDN in PCO Wireshark code review
11:47 [Wireshark-commits] master-1.12 c0c260f: LLDP-MED Cleanup Wireshark code review
11:47 [Wireshark-commits] master-1.12 0c20611: Updates as requested Wireshark code review
11:48 [Wireshark-commits] master-1.12 f1b756c: Misc lldp cleanup. I'm cheating a bit here, hf_media_loc_long & hf_media_loc_lat need a 5byte bitmask, but the bitmask field in hf is restricted to guint32 Wireshark code review
11:49 [Wireshark-commits] master-1.12 6a662cf: Add modelines Wireshark code review
11:49 [Wireshark-commits] master-1.12 2724a61: Current test for GIT_DIR introduced in changeset Ie1560c372e23e58fb0e310f681388b5e1a65ba5b doesn't seem to be working correctly on bash 4.3.18 : .git/hooks/pre-commit: line 11: .git: command not found Wireshark code review
11:49 [Wireshark-commits] master-1.12 4ac46b6: CAPWAP: Display incorrect value for Wireless IEEE802.11 RSSI and Data Rate Wireshark code review
11:50 [Wireshark-commits] master-1.10 627d583: CAPWAP: Display incorrect value for Wireless IEEE802.11 RSSI and Data Rate Wireshark code review
11:51 [Wireshark-commits] master-1.12 e3cd818: remove all checks for if (tree) Wireshark code review
12:02 [Wireshark-commits] master-1.12 d34b85c: 3GPP NAS: add dissection of MSISDN in PCO Wireshark code review
12:22 [Wireshark-commits] master 99d8c1c: Add macros to make it possible to define HAVE_SSE4_2 Wireshark code review
12:47 [Wireshark-commits] master-1.12 474de10: CAPWAP: Fix soft-deprecated APIs warning Wireshark code review
14:15 [Wireshark-commits] master 94dcbfd: Fix annoying warnings that a variable is uninitialized in checkfiltername.pl Wireshark code review
14:51 [Wireshark-commits] master fcb019a: Change HAVE_SSE42 to HAVE_SSE4_2 add $(SIMD_FLAGS) Add autotools macros to distribution Call AX_EXT to define HAVE_SSE4_2 Wireshark code review
14:57 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
16:08 [Wireshark-commits] master b6f8aea: See if this version works better on OSX 10.5 Wireshark code review
20:09 [Wireshark-commits] master-1.10 b850e6c: Squelch compiler warnings. Wireshark code review
22:32 [Wireshark-commits] master-1.10 3aea41d: Fix unused-variable warning. Wireshark code review
June 11, 2014
00:58 [Wireshark-commits] master 3fcd016: Fix bug in dissect_lldp_port_id, support all port id subtypes Wireshark code review
01:19 [Wireshark-commits] master-1.12 1fd1d3b: This fix now allows SASL/GSS-API with integrity only to be properly dissected in that we now properly indicate the checksum and provide the wrapped token to the LDAP dissector to dissect. Wireshark code review
06:55 [Wireshark-commits] master-1.12 bc2612c: Fix bug in dissect_lldp_port_id, support all port id subtypes Wireshark code review
12:05 [Wireshark-commits] master d8a21c8: Use expert info for Invalid length/type where possible, other minor fixes Wireshark code review
12:14 [Wireshark-commits] master 6ddf081: Fix switch case on ExpandedNodeId encoding mask Wireshark code review
12:14 [Wireshark-commits] master ddc275c: Unify variable and identifier names according to the UA specification Wireshark code review
12:15 [Wireshark-commits] master e2ae387: Fix NodeId and ExpandedNodeId encoding mask display Wireshark code review
12:29 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
12:30 [Wireshark-commits] master af687c5: Fix Warn Dissector bug, protocol LPP, in packet 1: proto.c:3403: failed assertion "DISSECTOR_ASSERT_NOT_REACHED" redifine FT of NavModel-GLONASS-ECEF/gloP1 Wireshark code review
12:35 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
12:45 [Wireshark-commits] master-1.12 6b57f77: Fix Warn Dissector bug, protocol LPP, in packet 1: proto.c:3403: failed assertion "DISSECTOR_ASSERT_NOT_REACHED" redifine FT of NavModel-GLONASS-ECEF/gloP1 Wireshark code review
12:47 [Wireshark-commits] master fabee43: Unify displaying of NodeId Wireshark code review
12:59 [Wireshark-commits] master baa5888: Move ServiceFault from ComplexType- to ServiceParser Wireshark code review
12:59 [Wireshark-commits] master 2ab3b2a: Improve display of Open/CloseSecureChannel requests and responses Wireshark code review
13:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
13:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
13:33 [Wireshark-commits] master-1.12 54a85ab: IPMI trace dissector Wireshark code review
13:57 [Wireshark-commits] master abf1b5e: Regenerate all sources using latest OPC UA specification Wireshark code review
13:57 [Wireshark-commits] master 5e67c45: Remove unused array length fields Wireshark code review
14:27 [Wireshark-commits] master 803d47d: opcua_simpletypes.c:94:12: error: static declaration of 'hf_opcua_NamespaceUri' follows non-static declaration Wireshark code review
15:15 [Wireshark-commits] master-1.8 6d29bec: Revert "Revert "Fix the fuzz failure reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8940"" Wireshark code review
17:41 [Wireshark-commits] master 508d16b: Use offset instead of tempOffset, return offset instead of calculating (len + n) where possible Wireshark code review
17:42 [Wireshark-commits] master 4a60a30: Rename temp variables to a more human readable form Wireshark code review
17:51 [Wireshark-commits] master-1.12 dfdaebc: Use expert info for Invalid length/type where possible, other minor fixes Wireshark code review
17:53 [Wireshark-commits] master-1.12 268eadc: Use offset instead of tempOffset, return offset instead of calculating (len + n) where possible Wireshark code review
18:08 [Wireshark-commits] master-1.12 ed14bc8: Rename temp variables to a more human readable form Wireshark code review
18:33 [Wireshark-commits] master 97a46ff: Fix bit fields definition in the "DMG Capability" IE Wireshark code review
19:08 [Wireshark-commits] master-1.12 db50467: Fix bit fields definition in the "DMG Capability" IE Wireshark code review
20:47 [Wireshark-commits] master-1.10 42b9bf0: Add a CVE ID. Wireshark code review
23:50 [Wireshark-commits] master 7db2135: A Subversion->Git change that we missed. Wireshark code review
23:50 [Wireshark-commits] master-1.12 b0c0b33: A Subversion->Git change that we missed. Wireshark code review
23:51 [Wireshark-commits] master-1.10 70c8caf: A Subversion->Git change that we missed. Wireshark code review
23:57 [Wireshark-commits] master 95065da: Some more SVN->Git. Wireshark code review
23:57 [Wireshark-commits] master-1.12 85fb7dc: Some more SVN->Git. Wireshark code review
23:57 [Wireshark-commits] master-1.10 7c3e026: Some more SVN->Git. Wireshark code review
June 12, 2014
00:32 [Wireshark-commits] master 8ff7729: Fix USB Class-Specific Control URB requests Wireshark code review
00:58 [Wireshark-commits] master 428c5b9: function to parse the usbpcap pseudo-header and fill the conversation struct Wireshark code review
05:55 [Wireshark-commits] master df8c4bf: Capture Interfaces Dialog: Wireshark code review
06:25 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
09:16 [Wireshark-commits] master 5a49913: Make sure image/expert_ok.png ends up in a source tarball. Wireshark code review
12:45 [Wireshark-commits] master d17aa36: Fix a regression, as -1 can no longer means until the end of the tvb Wireshark code review
13:36 [Wireshark-commits] master 515b78c: X11: Support XCB's new <pad align='n' /> Wireshark code review
13:52 [Wireshark-commits] master-1.12 be65a31: Fix a regression, as -1 can no longer means until the end of the tvb Wireshark code review
14:59 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
15:19 [Wireshark-commits] master 1dead2b: X11: Update generated dissector Wireshark code review
15:58 [Wireshark-commits] master-1.12 5d2b4ce: X11: Support XCB's new <pad align='n' /> Wireshark code review
16:22 [Wireshark-commits] master-1.12 e519b31: X11: Update generated dissector Wireshark code review
18:29 [Wireshark-commits] master c246513: Don't check "&(device.if_info)" to see if it's null. Wireshark code review
18:55 [Wireshark-commits] master a972e8f: Try to fix a used-but-not-set warning. Wireshark code review
19:10 [Wireshark-commits] master-1.8 2863329: A Subversion->Git change that we missed. Wireshark code review
19:10 [Wireshark-commits] master-1.8 1b7174c: Some more SVN->Git. Wireshark code review
19:24 [Wireshark-commits] master-1.8 50a182c: Build 1.8.15. Wireshark code review
19:25 [Wireshark-commits] [wireshark] annotated tag v1.8.15 created (now 9d0f3e4) Wireshark code review
19:26 [Wireshark-commits] [wireshark] annotated tag v1.8.15-rc1 created (now 54879dd) Wireshark code review
19:26 [Wireshark-commits] [wireshark] annotated tag wireshark-1.8.15 created (now 57a8edd) Wireshark code review
19:30 [Wireshark-commits] master-1.10 0f2c367: Build 1.10.8. Wireshark code review
19:32 [Wireshark-commits] [wireshark] annotated tag v1.10.8 created (now dd33589) Wireshark code review
19:32 [Wireshark-commits] [wireshark] annotated tag wireshark-1.10.8 created (now ff2cba0) Wireshark code review
19:38 [Wireshark-commits] master-1.10 6557bcb: Fix switch case on ExpandedNodeId encoding mask Wireshark code review
19:50 [Wireshark-commits] master-1.12 65c6ba6: Fix switch case on ExpandedNodeId encoding mask Wireshark code review
21:02 [Wireshark-commits] master-1.10 52a5244: Revert "Fix switch case on ExpandedNodeId encoding mask" Wireshark code review
21:09 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows-XP-x86 buildbot-no-reply
21:24 [Wireshark-commits] master 51750be: RTP: fix invalid memory access Wireshark code review
21:25 [Wireshark-commits] master-1.12 2caf31b: RTP: fix invalid memory access Wireshark code review
22:41 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
22:44 [Wireshark-commits] master-1.8 6c3ebae: 1.8.15 → 1.8.16. Wireshark code review
22:44 [Wireshark-commits] master-1.10 a4d5e0f: 1.10.8 → 1.10.9. Wireshark code review
22:45 [Wireshark-commits] [wireshark] annotated tag v1.8.16-rc1 created (now a8b14f3) Wireshark code review
22:46 [Wireshark-commits] [wireshark] annotated tag v1.10.9-rc1 created (now b657fb6) Wireshark code review
23:22 [Wireshark-commits] master-1.10 bbdbde2: Add back "Fix switch case on ExpandedNodeId encoding mask" Wireshark code review
23:56 [Wireshark-commits] master 4dfbb79: From Gisle Vanem on -dev: don't print modelines info when run with -h. Wireshark code review
June 13, 2014
00:44 [Wireshark-commits] buildbot failure in Wireshark 1.8 on Windows-XP-x86 buildbot-no-reply
18:36 [Wireshark-commits] master-1.12 4911f85: We're not on master any more. Wireshark code review
19:08 [Wireshark-commits] master-1.12 3b9e39f: Prep for 1.12.0-rc2. Wireshark code review
19:10 [Wireshark-commits] [wireshark] annotated tag v1.12.0-rc2 created (now 19a412b) Wireshark code review
19:53 [Wireshark-commits] master-1.12 fd017ee: Fix package version stamping. Wireshark code review
20:02 [Wireshark-commits] [wireshark] annotated tag v1.12.0-rc2 deleted (was 19a412b) Wireshark code review
20:02 [Wireshark-commits] [wireshark] annotated tag v1.12.0-rc2 created (now 2e3faaa) Wireshark code review
20:10 [Wireshark-commits] master-1.10 a3a6e40: Fix corruption when saving to a pcapng file if number of name resolution entries exceeds max NRB block size. Wireshark code review
20:21 [Wireshark-commits] master a6993d3: Fix package version stamping. Wireshark code review
20:21 [Wireshark-commits] master-1.10 d814a23: Fix package version stamping. Wireshark code review
20:26 [Wireshark-commits] master-1.8 0438d22: Fix package version stamping. Wireshark code review
22:44 [Wireshark-commits] master-1.12 697c069: Prep for 1.12.0-rc3. Wireshark code review
June 14, 2014
06:42 [Wireshark-commits] master 21b08ba: Rename WIRESHARK_C_FLAGS to WIRESHARK_COMMON_FLAGS Wireshark code review
06:43 [Wireshark-commits] master a4a7d2c: Small whitespace fixes Wireshark code review
06:44 [Wireshark-commits] master 9352803: Backport autofoo simd optimization Wireshark code review
07:38 [Wireshark-commits] master b70bb46: Make it harder to miss that this is also about Win builds Wireshark code review
08:49 [Wireshark-commits] master 30480da: Match for contents of WIRESHARK_SIMD_FLAGS only if non-empty Wireshark code review
13:27 [Wireshark-commits] master e143570: Define INET6 for all platforms. Show the addresses as a tooltip in capture interfaces. Wireshark code review
14:04 [Wireshark-commits] master 464c263: dissect the usbpcap_buffer_control_header in dissect_usb_common() Wireshark code review
14:04 [Wireshark-commits] master 09784a9: rename dissect_win32_usb_pseudo_header() to dissect_usbpcap_buffer_packet_header() Wireshark code review
14:05 [Wireshark-commits] master 2c9b7c5: simplify the detection of iso data start offset Wireshark code review
14:05 [Wireshark-commits] master f1523a6: remove unnecessary tree variable Wireshark code review
14:06 [Wireshark-commits] master 29a25d2: rename tree_ti to urb_tree_ti Wireshark code review
14:06 [Wireshark-commits] master 4cb8488: more descriptive names for tree variables Wireshark code review
14:07 [Wireshark-commits] master 7d5821f: mark both transfer header and payload bytes for usbpcap iso packets Wireshark code review
14:07 [Wireshark-commits] master 04b3118: let the subfct fill win32_data_len Wireshark code review
14:08 [Wireshark-commits] master 548d8aa: limit the scope of new_offset Wireshark code review
14:08 [Wireshark-commits] master a1a5f65: limit the scope of setup_tvb Wireshark code review
14:27 [Wireshark-commits] master d4c6b2a: Added monlist support Wireshark code review
14:34 [Wireshark-commits] master 4c261cf: Policy CMP020 was being set twice. Remove my original clumsy implementation. Set CMP0015 to NEW Wireshark code review
June 15, 2014
02:04 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
03:18 [Wireshark-commits] master e9dea85: acknowledge BASE_RANGE_STRING Wireshark code review
12:18 [Wireshark-commits] master dc4d370: packet-ipmi-se.c : proto_tree_add_text -> something filterable. Wireshark code review
12:26 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
12:28 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
12:29 [Wireshark-commits] master 9e4cb64: packet-ospf.c : proto_tree_add_text -> something filterable Wireshark code review
12:38 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
13:59 [Wireshark-commits] master 237fa1c: Fix warnings turning errors (also fixes buildbot) These fixes are superficial. Michael: Please review and either remove the unneeded stuff or put in the correct use. Wireshark code review
14:35 [Wireshark-commits] master 310d5ab: OSPF: Remove unused code (will be never reused) Wireshark code review
15:04 [Wireshark-commits] master 3081fe0: [Automatic manuf, services and enterprise-numbers update for 2014-06-15] Wireshark code review
15:07 [Wireshark-commits] master-1.12 f386b83: [Automatic manuf, services and enterprise-numbers update for 2014-06-15] Wireshark code review
15:09 [Wireshark-commits] master-1.10 845886c: [Automatic manuf, services and enterprise-numbers update for 2014-06-15] Wireshark code review
15:12 [Wireshark-commits] master-1.8 7a15c6c: [Automatic manuf, services and enterprise-numbers update for 2014-06-15] Wireshark code review
16:33 [Wireshark-commits] master 14903d6: Depend on docbook-xml and drop obsoleted 0005-...patch Wireshark code review
17:37 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
17:41 [Wireshark-commits] master fae6b0b: Add missing --git-dir=$srcdir/.git for ls-remote Wireshark code review
17:44 [Wireshark-commits] master b3054c2: Added some type values Wireshark code review
17:56 [Wireshark-commits] master 2356173: Fix documentation for DissectorTable_get_dissector Wireshark code review
18:41 [Wireshark-commits] master 2919633: New dissector for Character Generator Protocol (chargen). Wireshark code review
23:40 [Wireshark-commits] master-1.12 0406c06: Depend on docbook-xml and drop obsoleted 0005-...patch Wireshark code review
June 16, 2014
06:48 [Wireshark-commits] master 53c0d78: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
06:48 [Wireshark-commits] master ac5479b: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
06:49 [Wireshark-commits] master 1f47e27: Use tfs_f1_3_override_state to avoid unused variable error Wireshark code review
06:50 [Wireshark-commits] master 92fbff2: Register BER dissector as new. Wireshark code review
13:20 [Wireshark-commits] master 2274b28: iSCSI: Register iscsi dissector, so it can be used by iSER Wireshark code review
13:22 [Wireshark-commits] master 0a29589: Fix SDP dissector crash during fuzz testing Wireshark code review
13:23 [Wireshark-commits] master-1.12 b27bf15: Fix SDP dissector crash during fuzz testing Wireshark code review
14:19 [Wireshark-commits] master 066a9f3: Support out-of-source docbook build Wireshark code review
14:27 [Wireshark-commits] master dd596db: STUN: Add support of MS-TURNBWM Wireshark code review
14:58 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
15:19 [Wireshark-commits] master 39a14ab: Remove now-unused functions. Wireshark code review
15:20 [Wireshark-commits] master e46c1af: Remove emem from ssl utils, use glib instead. Wireshark code review
15:25 [Wireshark-commits] master 83f9cc6: Remove last caller of se_strdup_printf Wireshark code review
15:36 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:36 [Wireshark-commits] master c76b70f: Remove last remaining call to se_strdup Wireshark code review
15:38 [Wireshark-commits] master 39d7c9d: Remove emem in SNMP UAT, use glib instead Wireshark code review
15:39 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
15:43 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
15:44 [Wireshark-commits] master a9b18ef: Display text representation of status codes Wireshark code review
15:47 [Wireshark-commits] master 0bb0b62: Display status code info bits if set Wireshark code review
15:47 [Wireshark-commits] master 2f369b2: Cleanup subtree types in opcua plugin Wireshark code review
15:48 [Wireshark-commits] master 9ac8052: glusterfs: correctly decode GFIDs that are passed in a dict Wireshark code review
15:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
16:24 [Wireshark-commits] master faac494: isakmp: support decryption for SHA-2 hash algorithms Wireshark code review
16:57 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
17:08 [Wireshark-commits] master b71b68c: Fix indent (Use 4spaces like end of the file and modelines info Wireshark code review
17:26 [Wireshark-commits] master de00c49: Convert a bunch of time_to_str functions to wmem Wireshark code review
17:59 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
18:32 [Wireshark-commits] master 6653289: Detecting gmodule2 on Homebrew almost worked... it behaves more like non-apple platforms Wireshark code review
18:36 [Wireshark-commits] [wireshark] branch lts-1.8.2 created (now db4cb96) Wireshark code review
18:43 [Wireshark-commits] master c62d6e5: Undo Graham's change to move find-package down. Fix detection of Homebrew on APPLE Wireshark code review
18:50 [Wireshark-commits] master 452b8de: Use correct dependencies for 'release_notes' target so that 'nmake ... release_notes' will work. Wireshark code review
18:50 [Wireshark-commits] master c607a3f: Add a preference to use Japanese ISUP TTC version with 13 bit CIC. Wireshark code review
18:50 [Wireshark-commits] lts-1.8.2 84faf42: Add a check for an oversized record. Wireshark code review
18:52 [Wireshark-commits] master caf5e59: Undo Graham's change to find the "correct" fix Wireshark code review
19:00 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
19:08 [Wireshark-commits] master 9301c5b: NEWS was updated again Wireshark code review
19:11 [Wireshark-commits] master e0aabd9: Convert more time_to_str functions to wmem Wireshark code review
19:11 [Wireshark-commits] master b166553: remove more unused code Wireshark code review
19:15 [Wireshark-commits] master 67a924b: The visibility warning is only valid on non-msvc platforms Wireshark code review
19:16 [Wireshark-commits] master 27c5eaf: Update info as to packages needed for Windows and Fedora. Wireshark code review
19:23 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
19:31 [Wireshark-commits] master 4c0d8fd: Ignore 'docbook/ws?g_chm/' Wireshark code review
19:47 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
20:26 [Wireshark-commits] master-1.12 fb0266f: Do not handle P_Mul packet as ASCII string when calculating checksum. Wireshark code review
20:27 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
20:27 [Wireshark-commits] master b2b7a6b: Do not handle P_Mul packet as ASCII string when calculating checksum. Wireshark code review
20:28 [Wireshark-commits] master 87aed58: Register DMP as new-style dissector Wireshark code review
20:28 [Wireshark-commits] master ee137c4: Register P_Mul as new-style dissector Wireshark code review
20:37 [Wireshark-commits] master cf99e6b: packet-ipdc.c: proto_tree_add_text -> something filterable. Wireshark code review
20:38 [Wireshark-commits] master a279fa7: Have ipmi "dissectors" register through the build process instead of "manually" Wireshark code review
20:39 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
20:42 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
20:44 [Wireshark-commits] master ad97c1e: kill unmaintained python bindings Wireshark code review
21:01 [Wireshark-commits] master 3a3b36f: kill one last python remnant Wireshark code review
21:01 [Wireshark-commits] master d5fb63a: Fix copy/paste errors in stun attributes value_string[] array. Wireshark code review
21:04 [Wireshark-commits] master bbc7293: fix format string typos Wireshark code review
21:05 [Wireshark-commits] master 1496111: Fix a whitepace error that got committed in the last change Wireshark code review
21:09 [Wireshark-commits] master a82c8d1: More wspython removal. Wireshark code review
21:19 [Wireshark-commits] master aeb1888: Remove the (old, broken) Python bindings option to ./configure (and a few other references). Wireshark code review
21:31 [Wireshark-commits] master 7f6ebec: Hide hidden columns in Qt. Wireshark code review
21:46 [Wireshark-commits] master 319ad97: Add a cast to satisfy the buildbots. Wireshark code review
21:51 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
22:03 [Wireshark-commits] master f5476e9: Explicitly declare/cast 'unsigned <variable>' as 'unsigned int <variable>' Applying part of Bug 7825 Wireshark code review
22:14 [Wireshark-commits] master 1777f60: The broken python support is beeing removed. Wireshark code review
22:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
22:54 [Wireshark-commits] master d58ac9a: Get rid of the last bits of Python, as they break the build. Wireshark code review
22:58 [Wireshark-commits] master 048646d: More Python removal. Wireshark code review
23:14 [Wireshark-commits] master f113306: More Python-bindings removal. Wireshark code review
23:37 [Wireshark-commits] master 1567820: Add a FIXME referring to bug 4096 Wireshark code review
23:56 [Wireshark-commits] master 6c79a71: Column visibility fixups. Wireshark code review
June 17, 2014
00:06 [Wireshark-commits] master e047e3a: Convert tcap dissector to wmem Wireshark code review
00:08 [Wireshark-commits] master 923cf41: Fix copy/paste errors in value_string. Wireshark code review
00:08 [Wireshark-commits] master 11243e3: Qt: fix loading of language translation Wireshark code review
00:44 [Wireshark-commits] master 289aa37: Remove detection of Python libraries: They are not used anymore. Wireshark code review
05:44 [Wireshark-commits] master a9a73a8: Get the Windows doc builds going again: define top_srcdir because it's used in Makefile.common. Wireshark code review
05:48 [Wireshark-commits] master 5ca64ca: Add support for WRITE_LONG16 & REPORT_REFERRALS to scsi dissector Picking up leftover work on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8843 Wireshark code review
05:50 [Wireshark-commits] master-1.10 0741bba: Fix NodeId and ExpandedNodeId encoding masks Wireshark code review
14:29 [Wireshark-commits] master f847b92: It's so simple: If we require a package but provide alternative methods of finding the package don't allow the first method to fail terminally. Todo: Fix this in all other places as well. Wireshark code review
14:44 [Wireshark-commits] master f9b05dc: isakmp: allow IKEv1 decryption with non-PSK authentication Wireshark code review
14:49 [Wireshark-commits] master d1cdbd7: isakmp: add support for IKEv1 AES decryption Wireshark code review
15:45 [Wireshark-commits] master-1.12 a95d0f1: Unify variable and identifier names according to the UA specification Wireshark code review
15:46 [Wireshark-commits] master-1.12 ee3f0a9: Fix NodeId and ExpandedNodeId encoding mask display Wireshark code review
15:56 [Wireshark-commits] master-1.12 3e1eaed: Unify displaying of NodeId Wireshark code review
15:56 [Wireshark-commits] master-1.12 95cc25a: Move ServiceFault from ComplexType- to ServiceParser Wireshark code review
15:57 [Wireshark-commits] master-1.12 547f731: Improve display of Open/CloseSecureChannel requests and responses Wireshark code review
15:58 [Wireshark-commits] master-1.12 35c980f: Regenerate all sources using latest OPC UA specification Wireshark code review
15:59 [Wireshark-commits] master-1.12 eaeb03b: Remove unused array length fields Wireshark code review
15:59 [Wireshark-commits] master-1.12 da96994: opcua_simpletypes.c:94:12: error: static declaration of 'hf_opcua_NamespaceUri' follows non-static declaration Wireshark code review
16:00 [Wireshark-commits] master-1.12 f399a63: Display text representation of status codes Wireshark code review
17:07 [Wireshark-commits] master-1.12 7eb1aec: Display status code info bits if set Wireshark code review
17:08 [Wireshark-commits] master-1.12 c41b64b: Cleanup subtree types in opcua plugin Wireshark code review
17:09 [Wireshark-commits] master 9991f43: Add dissect_nt_64bit_time_ex for retrieving the created proto_item Wireshark code review
17:11 [Wireshark-commits] master 91c29ec: Add myself as author for the opcua dissector plugin Wireshark code review
17:12 [Wireshark-commits] master 647255d: Unify how opcua arrays are displayed Wireshark code review
17:14 [Wireshark-commits] master-1.10 56ecf64: Move ServiceFault from ComplexType- to ServiceParser Wireshark code review
17:14 [Wireshark-commits] master-1.10 c3d6a86: Fix display of CloseSecureChannel requests and responses Wireshark code review
17:16 [Wireshark-commits] master 8c0d3ae: Return number of bytes dissected in dissector:call Wireshark code review
17:25 [Wireshark-commits] master 7067e3a: Create and register subtree identifiers for all opcua array types Wireshark code review
17:25 [Wireshark-commits] master c30df31: lua_pushstring takes a copy of its argument Wireshark code review
17:56 [Wireshark-commits] master-1.12 c6736f0: isakmp: allow IKEv1 decryption with non-PSK authentication Wireshark code review
17:56 [Wireshark-commits] master-1.10 9615ddc: isakmp: allow IKEv1 decryption with non-PSK authentication Wireshark code review
17:58 [Wireshark-commits] master-1.8 57a2086: isakmp: allow IKEv1 decryption with non-PSK authentication Wireshark code review
17:58 [Wireshark-commits] master-1.12 1d87b4d: isakmp: support decryption for SHA-2 hash algorithms Wireshark code review
17:59 [Wireshark-commits] master-1.12 225aeef: make satellite orbital position filterable Wireshark code review
18:01 [Wireshark-commits] master-1.12 b8cb7d3: isakmp: add support for IKEv1 AES decryption Wireshark code review
18:03 [Wireshark-commits] master-1.12 e9c3905: make the satellite symbol rate filterable Wireshark code review
18:04 [Wireshark-commits] master-1.12 3c1f13c: make cable frequency filterable Wireshark code review
18:06 [Wireshark-commits] master-1.12 d34c0d0: make cable symbol rate filterable Wireshark code review
18:08 [Wireshark-commits] master-1.12 04792d5: use proto_tree_add_float_format_value() correctly Wireshark code review
18:08 [Wireshark-commits] master-1.12 33caf46: dissect more components of the track header box Wireshark code review
18:09 [Wireshark-commits] master-1.12 8ce3af7: conver sat freq and symbol rate into doubles in order to make the filtering work, fix typos Wireshark code review
18:11 [Wireshark-commits] master-1.12 0937cce: convert cable freq, symbol rate into doubles Wireshark code review
18:14 [Wireshark-commits] master-1.12 a3ff1c1: avoid proto_tree_add_uint_format() when we just want the default description Wireshark code review
18:15 [Wireshark-commits] master-1.12 67e6170: make local time offset filterable Wireshark code review
18:17 [Wireshark-commits] master-1.12 fd2566c: make next time offset filterable Wireshark code review
18:17 [Wireshark-commits] master 17a5526: fix underflow in BER constrained bitstrings Wireshark code review
18:17 [Wireshark-commits] master-1.12 d0156c4: fix underflow in BER constrained bitstrings Wireshark code review
18:17 [Wireshark-commits] master-1.10 1eb9b9e: fix underflow in BER constrained bitstrings Wireshark code review
18:18 [Wireshark-commits] master-1.12 70261f4: make terrestrial centre frequency filterable Wireshark code review
18:19 [Wireshark-commits] master-1.12 d8f30a8: make population id filterable Wireshark code review
18:20 [Wireshark-commits] master-1.12 9107e5c: do a plausibility check for interaction channel data in the linkage descriptor Wireshark code review
18:22 [Wireshark-commits] master-1.12 e8dd396: make the PCR value filterable Wireshark code review
18:23 [Wireshark-commits] master-1.12 1230627: simplify PCR calculation Wireshark code review
18:35 [Wireshark-commits] master-1.12 c0b5d6f: EPL: Duplicated frames Wireshark code review
19:30 [Wireshark-commits] master-1.12 be6ef28: Add myself as author for the opcua dissector plugin Wireshark code review
19:31 [Wireshark-commits] master-1.12 f8fcb34: Add dissect_nt_64bit_time_ex for retrieving the created proto_item Wireshark code review
19:33 [Wireshark-commits] master-1.12 8e5241a: Unify how opcua arrays are displayed Wireshark code review
19:38 [Wireshark-commits] master-1.12 d2b6365: Create and register subtree identifiers for all opcua array types Wireshark code review
19:39 [Wireshark-commits] master 55cdf03: ip version and header-length are not full byte values. Show the bit decoding for these values. Wireshark code review
19:44 [Wireshark-commits] master 43d9a4b: Simplify obtaining the absolute path of the build dir Wireshark code review
20:04 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
20:54 [Wireshark-commits] master 4179383: Initialize rq_hdr.session Wireshark code review
20:55 [Wireshark-commits] master-1.12 35e920c: Initialize rq_hdr.session Wireshark code review
21:02 [Wireshark-commits] master 74fec38: Get QtShark building on Win7 with Qt 5.3.0 using Qt Creator. Wireshark code review
21:28 [Wireshark-commits] master f4b9ea4: Initialize smb ioctl_function struct member Wireshark code review
21:28 [Wireshark-commits] master-1.12 c9f2311: Initialize smb ioctl_function struct member Wireshark code review
21:45 [Wireshark-commits] master ba6eb5c: Set the rlc len field before we try to use it in an expert info. Wireshark code review
21:45 [Wireshark-commits] master-1.12 2c877e0: Set the rlc len field before we try to use it in an expert info. Wireshark code review
21:46 [Wireshark-commits] master-1.10 f608926: Set the rlc len field before we try to use it in an expert info. Wireshark code review
22:06 [Wireshark-commits] master 93b5a31: When building an OS X package for GTK+, put the libraries in lib. Wireshark code review
22:07 [Wireshark-commits] master-1.12 268c965: When building an OS X package for GTK+, put the libraries in lib. Wireshark code review
22:32 [Wireshark-commits] [wireshark] branch lts-1.2.11 created (now b33d799) Wireshark code review
22:37 [Wireshark-commits] master d5e2782: Update a comment about how to better identify retransmissions Wireshark code review
22:39 [Wireshark-commits] master ed38e69: Make sure we hide columns for live captures as well. Wireshark code review
22:53 [Wireshark-commits] master c9dd677: make dissect_ipmi_cmd() static Wireshark code review
22:57 [Wireshark-commits] lts-1.2.11 4157dc2: Copy over r52570 with manual intervention: Wireshark code review
23:08 [Wireshark-commits] master 91f58d6: check for correct ftype Wireshark code review
23:22 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
23:36 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
23:58 [Wireshark-commits] master 6664030: Rewrite check for ws_mempbrk_sse42.c compilation Wireshark code review
June 18, 2014
00:06 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
00:24 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
01:23 [Wireshark-commits] master a61ebef: Set the conditional SSE42_SUPPORTED in all circumstances. Wireshark code review
03:22 [Wireshark-commits] master 8241b87: Get rid of the Python stuff, as we've gotten rid of Python plugin support. Wireshark code review
03:58 [Wireshark-commits] master 237669a: Update debian/symbols for the changed library ABIs Wireshark code review
04:28 [Wireshark-commits] master 4cebb06: Add -Werror when testing -m compiler flags. Wireshark code review
04:58 [Wireshark-commits] master 20accf3: Don't do the check for clang/clang++. Wireshark code review
05:39 [Wireshark-commits] master 7bae85a: Fix x86 buildbots, revert sse4.2 AM_CONDITIONAL logic Wireshark code review
05:47 [Wireshark-commits] master c507304: If we don't check for something, don't print a result. Wireshark code review
05:52 [Wireshark-commits] master 57b27ec: Optimize tvbparse character set checking. Wireshark code review
05:53 [Wireshark-commits] master 04c9009: TCP: do desegmentation sanity checks for all sub dissectors types Wireshark code review
05:54 [Wireshark-commits] master 6e6bd90: Convert the obvious emem to wmem in lua code. Wireshark code review
05:54 [Wireshark-commits] master 6aa1470: Replace glib memory with wmem memory Wireshark code review
06:09 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
06:12 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
06:17 [Wireshark-commits] master 666127f: PDCP LTE: do not try to decipher PDCP control messages (like ROHC feedback) Wireshark code review
06:18 [Wireshark-commits] master-1.12 2f8a254: PDCP LTE: do not try to decipher PDCP control messages (like ROHC feedback) Wireshark code review
06:54 [Wireshark-commits] master 5440665: Fix building uiqt on Windows with the cmake build system: Protecting HAVE_PCAP_CREATE was not enough for the moc run in qt, maybe it doesn't have _WIN32 set? Don't even try to detect this function on WIN32 for now. Wireshark code review
06:59 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
07:00 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
07:23 [Wireshark-commits] master 4aad9d3: Fix compilation warning Wireshark code review
07:30 [Wireshark-commits] master 7939f68: Don't put c-comments into cmake files. Won't work at midnight either. Wireshark code review
09:50 [Wireshark-commits] master 421d817: Don't compile anything with -msse4.2 unless the compiler supports it. Wireshark code review
14:14 [Wireshark-commits] master 971ffd6: Fixup: tvb_get_string(z) -> tvb_get_string(z)_enc Wireshark code review
14:15 [Wireshark-commits] master 246fe2c: Fixup: tvb_* -> tvb_captured Wireshark code review
14:20 [Wireshark-commits] master 021e7af: Fixup: tvb_ensure_length_remaining -> tvb_ensure_captured_length_remaining Wireshark code review
14:22 [Wireshark-commits] master 7fea55a: Fixup: ep_address_to_str -> address_to_str Wireshark code review
15:00 [Wireshark-commits] master cd56eb9: move dissection of usbpcap isochronous packets to a separate function Wireshark code review
15:07 [Wireshark-commits] master b5a462b: Try to calculate the initial RTT of tcp conns Wireshark code review
15:34 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
15:45 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
16:15 [Wireshark-commits] master e308e7c: Update ASN.1 source files with the API changes done in g021e7af Wireshark code review
16:16 [Wireshark-commits] master f2dd6c0: SABP: fix an error spotted by pre-commit hook Wireshark code review
17:03 [Wireshark-commits] master 54819e5: ssl_parse_key_list() gets called from the UI, so don't use packet scope. Wireshark code review
17:47 [Wireshark-commits] master-1.12 e042581: Guarantee that open routines are initialized Wireshark code review
17:47 [Wireshark-commits] master c6324a0: Get rid of some ancient qualityreview comments... Wireshark code review
18:03 [Wireshark-commits] master cc37b50: Get rid of obsolete references to nettle Wireshark code review
18:04 [Wireshark-commits] master f99aaf8: PCLI: do not register UDP port 9000 by default as it is not allocated to this protocol by IANA Wireshark code review
18:05 [Wireshark-commits] master e09d127: Update PIDL source files with the API changes done in g021e7af Wireshark code review
18:05 [Wireshark-commits] master 248a503: Update ASN.1 source files with the API changes done in g971ffd6 Wireshark code review
18:11 [Wireshark-commits] master 009bebb: Fix copy-paste probem in COAP dissector Wireshark code review
18:19 [Wireshark-commits] master-1.12 d6f4b75: Fix copy-paste probem in COAP dissector Wireshark code review
18:27 [Wireshark-commits] master 08063d8: Build unit test binaries with Cmake Wireshark code review
18:31 [Wireshark-commits] master 77e3473: Do C-Flags and CXX-Flags the same way. Wireshark code review
18:32 [Wireshark-commits] master fca7b3f: Check for lua by grepping the output of tshark -v Wireshark code review
18:46 [Wireshark-commits] master 5e5e201: Another message from Clang for unknown -f and -m flags. Wireshark code review
18:55 [Wireshark-commits] master c6007e8: We don't need -Werror=unknown-warning-option with Clang. Wireshark code review
18:58 [Wireshark-commits] master 8dabe00: We don't need -Qunused-arguments with Clang Wireshark code review
19:27 [Wireshark-commits] master ff5c968: Only check for -msse4.2. Wireshark code review
19:28 [Wireshark-commits] master 72078cf: Undo more of Graham's changes: - We don't expect to find all packages and it is normally OK for some to fail. Wireshark code review
19:39 [Wireshark-commits] master 681d823: The data is actually http, call the http disector for it. Wireshark code review
19:40 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
19:55 [Wireshark-commits] master 67dac59: Change the indication for out-of-order packets. This is experimental and will be verified by Jasper next week Wireshark code review
19:58 [Wireshark-commits] master 461c6a0: Rename the Shortname of initial RTT to something short (iRTT) Wireshark code review
20:43 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
20:55 [Wireshark-commits] master 6da6bf7: Get the handle for the pw_hdlc_nocw_hdlc_ppp dissector. Wireshark code review
20:55 [Wireshark-commits] master-1.12 4a4b267: Get the handle for the pw_hdlc_nocw_hdlc_ppp dissector. Wireshark code review
20:57 [Wireshark-commits] master-1.10 f94ad09: Get the handle for the pw_hdlc_nocw_hdlc_ppp dissector. Wireshark code review
20:57 [Wireshark-commits] master 13597c9: Rename the filtername to initial_rtt Wireshark code review
21:26 [Wireshark-commits] master 4d1e1e7: Sort the Ethernet pseudo-wire types so that they're together. Wireshark code review
23:51 [Wireshark-commits] master 153793a: Remove svn $Id$ keyword in Lua scripts Wireshark code review
June 19, 2014
00:11 [Wireshark-commits] master 5844e12: Optimize dissect_sip_uri() Wireshark code review
00:11 [Wireshark-commits] master 43c64c0: Update the sample code dealing with desegmentation to new style dissector Wireshark code review
00:15 [Wireshark-commits] master-1.12 8a104e0: Try to calculate the initial RTT of tcp conns Wireshark code review
00:15 [Wireshark-commits] master-1.12 c52c909: Get rid of some ancient qualityreview comments... Wireshark code review
00:16 [Wireshark-commits] master-1.12 7d72f26: Rename the Shortname of initial RTT to something short (iRTT) Wireshark code review
00:17 [Wireshark-commits] master-1.12 3d23e94: Rename the filtername to initial_rtt Wireshark code review
00:35 [Wireshark-commits] master 85499fb: Add simple script to export release tarball right from Git Wireshark code review
00:35 [Wireshark-commits] master 5a6366c: Generate xz compressed archives instead of .bz2-s Wireshark code review
06:48 [Wireshark-commits] master bcff3c5: Add the ability to dynamically add a new protocol to export PDU dialog box Wireshark code review
06:56 [Wireshark-commits] master-1.12 d4f9805: Add the ability to dynamically add a new protocol to export PDU dialog box Wireshark code review
07:29 [Wireshark-commits] master-1.12 32f4bee: Add simple script to export release tarball right from Git Wireshark code review
07:30 [Wireshark-commits] master-1.12 701b6ad: Generate xz compressed archives instead of .bz2-s Wireshark code review
14:36 [Wireshark-commits] master 46a808a: Add GTK modules for existing LBM dissectors. Wireshark code review
17:23 [Wireshark-commits] master daa70fe: Revert "Fixup: tvb_ensure_length_remaining -> tvb_ensure_captured_length_remaining" Wireshark code review
17:54 [Wireshark-commits] master 3adc5b8: To make a dissector available for Decode As, just use dissector_add_handle(). Wireshark code review
18:22 [Wireshark-commits] master 0b245a4: Use the same offset += rtnValue logic for all TLV types, instead of a special case for chassis, port & ttl. I've avoided using any mathematical checks even though tlv type vals increase linearly just in case they change in the future. Wireshark code review
18:22 [Wireshark-commits] master-1.12 7e92d04: EPL: Reassemble the splitted payload Wireshark code review
18:23 [Wireshark-commits] master 53594f3: Dissectors for totemnet and totemsrp protocols implemented in corosync cluster engine. Bug 3232. Wireshark code review
18:24 [Wireshark-commits] master c95ff6b: Add dissector for Generic Network Virtualization Encapsulation (Geneve). Wireshark code review
18:24 [Wireshark-commits] master 3557ac4: Fix warnings in test binaries Wireshark code review
18:26 [Wireshark-commits] master 14824e6: Revert "Fixup: tvb_* -> tvb_captured" Wireshark code review
18:27 [Wireshark-commits] master b0bc4d5: Revert "Fixup: ep_address_to_str -> address_to_str" Wireshark code review
18:27 [Wireshark-commits] master 7398779: rename variable to avoid shadow warning Wireshark code review
18:42 [Wireshark-commits] master d0ac937: Revert "Update ASN.1 source files with the API changes done in g021e7af" Wireshark code review
18:42 [Wireshark-commits] master 39f6a8b: Revert "Update PIDL source files with the API changes done in g021e7af" Wireshark code review
18:46 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
18:54 [Wireshark-commits] master 83762f9: Add sys/socket.h which should fix solaris Wireshark code review
18:58 [Wireshark-commits] master 46ecf18: Use address_to_str(NULL, ...) for strings allocated outside dissectors. Wireshark code review
19:05 [Wireshark-commits] master 08a318a: Those address_to_str() calls were in packet scope, and were safe. Wireshark code review
19:08 [Wireshark-commits] master 592c367: Fix underflow causing infinite loop in openflow dissector Wireshark code review
19:08 [Wireshark-commits] master-1.12 1dfe213: Fix underflow causing infinite loop in openflow dissector Wireshark code review
19:10 [Wireshark-commits] master 1257446: address_to_str() *does* take a const pointer. Wireshark code review
19:14 [Wireshark-commits] master e1c0674: Long and short names are inverted Wireshark code review
19:15 [Wireshark-commits] master-1.12 7ea0d6c: Long and short names are inverted Wireshark code review
19:44 [Wireshark-commits] master 0a3b1d8: Kerberos: fix dissection of packets when Record Mark is present Wireshark code review
19:44 [Wireshark-commits] master-1.12 bc075ae: Kerberos: fix dissection of packets when Record Mark is present Wireshark code review
19:46 [Wireshark-commits] master 627de38: Removed SVN Id from epan dir. Wireshark code review
19:55 [Wireshark-commits] master 5ed05dd: batch of manual tvb_length conversions Wireshark code review
19:56 [Wireshark-commits] master 78a5f0c: gtk_table_new is deprecated in GTK3. Change to use grid instead, and use ws_gtk_grid_attach_extended() to do the heavy lifting. Wireshark code review
19:56 [Wireshark-commits] master 15a0a63: batch of manual tvb_length conversions Wireshark code review
19:56 [Wireshark-commits] master 9e81d58: Fix indent (use 4 spaces) and add modelines Wireshark code review
19:59 [Wireshark-commits] wireshark-win32-libs rev 448: / /trunk/packages/: user-guide-52567.zip user-guide-g7ea0d6c.zip /trunk/: README.txt pascal
20:01 [Wireshark-commits] wireshark-win64-libs rev 402: / /trunk/packages/: user-guide-52567.zip user-guide-g7ea0d6c.zip /trunk/: README.txt pascal
20:01 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
21:06 [Wireshark-commits] wireshark-win32-libs rev 449: /tags/2014-06-19/ pascal
21:07 [Wireshark-commits] wireshark-win64-libs rev 403: /tags/2014-06-19/ pascal
21:19 [Wireshark-commits] master-1.12 b1c025a: Update User Guide for upcoming 1.12.0 release Wireshark code review
21:23 [Wireshark-commits] master b936dbd: Protocols sending the OS's AF_INET6 value are OS-specific or broken. Wireshark code review
21:47 [Wireshark-commits] master a32dbae: Don't crash when closing the Summary window if the file has been closed. Wireshark code review
21:48 [Wireshark-commits] master-1.12 4a5b04b: Don't crash when closing the Summary window if the file has been closed. Wireshark code review
21:52 [Wireshark-commits] master 0c0bd54: no need to initialize these two vars Wireshark code review
21:52 [Wireshark-commits] master 1e9bc6e: handle TS packet reassembly for PES packets with 0 length field (unknown length) Wireshark code review
22:05 [Wireshark-commits] master 88b0d0a: Cleaned up some CLang dead assignment warnings. Wireshark code review
22:16 [Wireshark-commits] master 8b12768: calling subdissectors shouldn't be conditional on a tree Wireshark code review
22:16 [Wireshark-commits] master a45ce57: Optimize dissect_sip_route_header() Wireshark code review
22:18 [Wireshark-commits] master 158a329: Update User Guide Wireshark code review
22:18 [Wireshark-commits] master b98dc77: Cleanup filter fields that checkdisplayfilter.pl was complaining about. Wireshark code review
22:20 [Wireshark-commits] master f5e072a: Remove "pkg" prefix from display filters. Wireshark code review
22:21 [Wireshark-commits] master e07b795: Save the size and position of the expert info dialog Wireshark code review
22:21 [Wireshark-commits] master e9bce9d: Add dissectors to match the groups of display filters they represent instead of all coming from proto_zbee_nwk. Wireshark code review
22:23 [Wireshark-commits] master 84777a6: Removed SVN Id tag Wireshark code review
23:07 [Wireshark-commits] master db0e534: Changed a cast (from guint to guint64) in a call to gtk_tree_store_set(). The data is actually 64-bit, and was being fetched that way - but not stored that way - leading to some very strange (and large) values. Wireshark code review
23:33 [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering. Wireshark code review
23:34 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
23:49 [Wireshark-commits] master cdb6802: Make cmake build work for msvc 2013 (Graham Bloice) Wireshark code review
23:55 [Wireshark-commits] master 0c3e1a2: Add casting and license info to fix buildbots Wireshark code review
June 20, 2014
02:58 [Wireshark-commits] master 728e5a1: packet-vnc.c: Improve re-assembly. Wireshark code review
04:04 [Wireshark-commits] master df93705: Improve the tolerance of checkfiltername.pl so it can be added to the pre-commit script. Wireshark code review
04:09 [Wireshark-commits] master 4560881: Cleanup display filters reported by checkfiltername.pl Wireshark code review
05:18 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
05:33 [Wireshark-commits] master 980f5f6: batch of tvb-length conversions Wireshark code review
06:07 [Wireshark-commits] master 80c070f: Don't hide tcp option kind/len fields Wireshark code review
06:07 [Wireshark-commits] master-1.12 224ab2d: Don't hide tcp option kind/len fields Wireshark code review
06:14 [Wireshark-commits] master ee2885f: add cast to fix buildbot Wireshark code review
06:32 [Wireshark-commits] master-1.12 b1da509: Add GTK modules for existing LBM dissectors. Wireshark code review
06:58 [Wireshark-commits] master 28e8ce5: Add proto_tree_add_subtree and proto_tree_add_subtree_format Wireshark code review
07:06 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
07:10 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
07:13 [Wireshark-commits] master d91953f: fix printf argument index Wireshark code review
16:22 [Wireshark-commits] master ffccb9c: no need for if(tree) Wireshark code review
16:23 [Wireshark-commits] master 4df6b51: remove duplicate offset=0 Wireshark code review
16:43 [Wireshark-commits] master ce3d2ff: Rename dissector_add_handle() to dissector_add_for_decode_as(). Wireshark code review
16:48 [Wireshark-commits] master e9424fa: One more change to dissector_add_for_decode_as. Wireshark code review
17:04 [Wireshark-commits] master 2ab2921: Revert part of svn revision 52045 (git b38ee917) Wireshark code review
17:05 [Wireshark-commits] master-1.12 6a369cf: Revert part of svn revision 52045 (git b38ee917) Wireshark code review
17:38 [Wireshark-commits] master 7186b8a: Fix documentation generation on Windows Wireshark code review
18:51 [Wireshark-commits] master 6808afd: TCP: update the list of options and put Kind and Length items in the right subtree Wireshark code review
18:56 [Wireshark-commits] master-1.12 f5ea0d2: TCP: update the list of options and put Kind and Length items in the right subtree Wireshark code review
19:19 [Wireshark-commits] master 312ed10: Add --help and --version long options. Wireshark code review
21:00 [Wireshark-commits] master 26bbee3: Add some long options for capture short options. Wireshark code review
21:14 [Wireshark-commits] master 9a50b0f: Define OPTSTRING_CAPTURE_COMMON as nothing if we don't have pcap. Wireshark code review
21:23 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
21:29 [Wireshark-commits] master 13b5d9b: Use OPTSTRING_CAPTURE_COMMON here as well. Wireshark code review
21:30 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
21:32 [Wireshark-commits] master 5537c53: "-d" isn't common to all capturing programs, it's dumpcap-specific. Wireshark code review
21:39 [Wireshark-commits] master cc4710a: Also define LONGOPT_CAPTURE_COMMON as nothing if we don't have pcap. Wireshark code review
21:48 [Wireshark-commits] master 85ad72c: Add long names for -a, -b, and -p. Wireshark code review
21:51 [Wireshark-commits] master b3885a9: Fix builds without pcap. Wireshark code review
22:05 [Wireshark-commits] master dc5d0ed: Add flags required for VS2013 to Cmake Wireshark code review
22:39 [Wireshark-commits] master fd8bf42: Process all .in files, not only the ones needed for Unix'ish systems. Wireshark code review
23:05 [Wireshark-commits] master 84df8eb: relnotes got updated again Wireshark code review
23:06 [Wireshark-commits] master 5d65e02: More .in files to handle Wireshark code review
23:26 [Wireshark-commits] master 235d3a2: Fix build without pcap. Wireshark code review
23:43 [Wireshark-commits] master b2622e1: Move the "capture-comment" long option to LONGOPT_CAPTURE_COMMON. Wireshark code review
23:58 [Wireshark-commits] master c11ae8a: Add .rc files to the sources to have them included in the build Change-Id: I84dda519e617b24d92fcf374670a4a6ee6f488ee Reviewed-on: https://code.wireshark.org/review/2506 Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx> Wireshark code review
June 21, 2014
01:05 [Wireshark-commits] master 3773a75: Add command-line argument to request the version to a number of the utilities. Wireshark code review
04:01 [Wireshark-commits] master 37b903d: batch of tvb-length conversions Wireshark code review
17:33 [Wireshark-commits] master 43443af: Move get_copyright_info() to wsutil. Wireshark code review
18:02 [Wireshark-commits] master a111224: Move get_os_version_info() to libwsutil. Wireshark code review
18:09 [Wireshark-commits] master 554c902: Move the Windows build target OS definitions to Win XP Wireshark code review
18:17 [Wireshark-commits] master e02c66f: Check constraints for OSPFv2 LSAs: 1 Router LSA: >= 24 bytes (>= 0 link descriptor(s) required) 2 Network LSA: >= 28 bytes (>= 1 router-ID(s) required) 3 Summary LSA: >= 28 bytes (>= 1 TOS metric block(s) required) 4 Summary LSA: >= 28 bytes (>= 1 TOS metric block(s) required) 5 AS-External LSA: >= 36 bytes (>= 1 TOS forwarding block(s) required) 7 NSSA LSA: >= 36 bytes (>= 1 TOS forwarding block(s) required) 9 Opaque Link LSA: >= 20 bytes 10 Opaque Area LSA: >= 20 bytes 11 Opaque AS LSA: >= 20 bytes Wireshark code review
18:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
18:25 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
18:30 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
18:31 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
18:34 [Wireshark-commits] master d0a567e: We need <windows.h> on Windows. Wireshark code review
18:39 [Wireshark-commits] master ac53439: cfutils.c is now part of libwsutil. Wireshark code review
19:02 [Wireshark-commits] master aeed656: We need the Unicode utilities, at least on Windows. Wireshark code review
19:07 [Wireshark-commits] master f13f70d: Need <string.h> for string routines. Wireshark code review
19:09 [Wireshark-commits] master e5abf34: Is <stdio.h> necessary here? Wireshark code review
19:35 [Wireshark-commits] master d99d1b9: Add a get_compiler_info() routine in libwsutil to get compiler information. Wireshark code review
19:37 [Wireshark-commits] master 83d832c: Get rid of trailing blank lines. Wireshark code review
19:45 [Wireshark-commits] master 8960430: cfutils.c is now part of libwsutils. Wireshark code review
19:54 [Wireshark-commits] master 9e8fb87: Clean up inclusion of cfutils.h. Wireshark code review
20:21 [Wireshark-commits] master 00f23a4: Move the routine to get a CPU information string to wsutil. Wireshark code review
20:22 [Wireshark-commits] master 3c96970: Get rid of trailing blank lines. Wireshark code review
20:31 [Wireshark-commits] master 73c7add: Move the routine to get memory information to wsutil. Wireshark code review
20:36 [Wireshark-commits] master 3c979e6: Reorder some statements to avoid unused build-type directories Change-Id: I4209eff78faa619030d3cacdc759fd143a238247 Reviewed-on: https://code.wireshark.org/review/2526 Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx> Wireshark code review
21:33 [Wireshark-commits] master a70dea1: Move get_os_major_version() to wsutil and rename it to get_windows_major_version(). Wireshark code review
June 22, 2014
01:06 [Wireshark-commits] master c46329c: Add a routine to return a version string including VCS information. Wireshark code review
01:11 [Wireshark-commits] master 7ba4aef: Don't declare CFString_to_C_string() if we don't have OS X frameworks. Wireshark code review
01:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
01:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
01:15 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
01:49 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
01:55 [Wireshark-commits] master 376dfe8: Fix build errors for tfshark and echld. Wireshark code review
02:51 [Wireshark-commits] master e088923: Update to reflect current reality. Wireshark code review
02:53 [Wireshark-commits] master c935411: Remove trailing white space, copyedit, add a missing period. Wireshark code review
03:51 [Wireshark-commits] master dfa7337: create a new function that dissects the usb linux iso transfer (just copied the existing code) Wireshark code review
03:51 [Wireshark-commits] master 2aae7ca: create the iso descriptor tree's title in a simpler way Wireshark code review
03:52 [Wireshark-commits] master 2b6ce23: rename the ti variable Wireshark code review
03:52 [Wireshark-commits] master 6b90679: no need to check the parent tree when we create the iso descriptor tree Wireshark code review
03:53 [Wireshark-commits] master 4c740dc: the tree that we use in the iso transfer function in is the urb_tree Wireshark code review
03:55 [Wireshark-commits] master 3e5e18f: Build version.h before trying to build wsutil. Wireshark code review
04:11 [Wireshark-commits] master 08bd012: minor cleanups Wireshark code review
14:34 [Wireshark-commits] master f5e2b42: convert to proto_tree_add_subtree[_format] Wireshark code review
15:04 [Wireshark-commits] master b587740: [Automatic manuf, services and enterprise-numbers update for 2014-06-22] Wireshark code review
15:07 [Wireshark-commits] master-1.12 3775ebd: [Automatic manuf, services and enterprise-numbers update for 2014-06-22] Wireshark code review
15:09 [Wireshark-commits] master-1.10 5402ae1: [Automatic manuf, services and enterprise-numbers update for 2014-06-22] Wireshark code review
15:11 [Wireshark-commits] master-1.8 9aa3d94: [Automatic manuf, services and enterprise-numbers update for 2014-06-22] Wireshark code review
15:16 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
15:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
16:42 [Wireshark-commits] master 58bbfa5: When setting entry_tree, set entry_item as well. Wireshark code review
16:56 [Wireshark-commits] master 164af00: Bluetooth: Complete sessions Wireshark code review
16:56 [Wireshark-commits] master 10fc6e2: Bluetooth: A2DP: Fix fuzz failture Wireshark code review
16:57 [Wireshark-commits] master 4a3d0b8: Logcat: Fix dump formats Wireshark code review
16:57 [Wireshark-commits] master 0a96087: Logcat: Set data-text-lines dissectors for log Wireshark code review
18:16 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
18:32 [Wireshark-commits] master a59d62e: 64-bit Cygwin's dependencies for Bison are wrong; it doesn't require m4. Wireshark code review
18:39 [Wireshark-commits] master d51faaa: Point to the Cygwin mirrors page. Wireshark code review
18:49 [Wireshark-commits] master 38e0ad0: Replace C++-style comments with "#if 0"/"#endif". Wireshark code review
20:23 [Wireshark-commits] master dfe7e71: Fix a leak in the SCTP dissector Wireshark code review
20:23 [Wireshark-commits] master ce99d8a: Fix leak in nbap init function Wireshark code review
20:31 [Wireshark-commits] master-1.12 91a375f: Fix leak in nbap init function Wireshark code review
20:54 [Wireshark-commits] master 3fc441e: Initialize whole buffer in GTP dissector Wireshark code review
20:54 [Wireshark-commits] master-1.12 a3e3db5: Initialize whole buffer in GTP dissector Wireshark code review
20:54 [Wireshark-commits] master-1.10 975297b: Initialize whole buffer in GTP dissector Wireshark code review
21:00 [Wireshark-commits] master-1.12 d24be5b: Bluetooth: A2DP: Fix fuzz failture Wireshark code review
21:07 [Wireshark-commits] master 188aa9a: convert to proto_tree_add_subtree[_format] Wireshark code review
21:07 [Wireshark-commits] master 2c0214e: LLTD dissector Wireshark code review
21:08 [Wireshark-commits] master 9356d5c: convert to proto_tree_add_subtree[_format] for ASN.1 dissectors Wireshark code review
21:34 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
21:42 [Wireshark-commits] master 9c35a5d: Make dissect_lltd() a new-style dissector and register it as such. Wireshark code review
21:49 [Wireshark-commits] master 6896def: Get rid of some unused variables. Wireshark code review
21:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
22:18 [Wireshark-commits] master ab6a45a: Get rid of set-but-not-used variable. Wireshark code review
June 23, 2014
03:34 [Wireshark-commits] master 6e0be01: Add col_append_lstr(), speedup column generation for TCP. Wireshark code review
08:24 [Wireshark-commits] master eaf6e55: Fix a typo. Wireshark code review
14:42 [Wireshark-commits] master c9a5fbe: Optimize sip_is_known_sip_header() Wireshark code review
14:49 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
14:52 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
15:30 [Wireshark-commits] master 9079e3a: Cheat and try to fix the generated file manually. Wireshark code review
15:54 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
16:22 [Wireshark-commits] master 520190c: Revert "Cheat and try to fix the generated file manually." Wireshark code review
16:22 [Wireshark-commits] master 02edc33: Revert "Optimize sip_is_known_sip_header()" Wireshark code review
16:48 [Wireshark-commits] master cb04fd5: Add all AF_ types for Windows that are in WinSock.h or WinSock2.h Wireshark code review
16:48 [Wireshark-commits] master 54cc0d8: Replace AF_ values by COMMON_AF_ values. Remove no longer needed system includes Wireshark code review
17:05 [Wireshark-commits] master 858c48a: Point the user at http://www.cygwin.com/install.html for downloads. Wireshark code review
17:36 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
17:52 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
19:10 [Wireshark-commits] master 59e860c: [WIP] qt: Add support for Polish language Wireshark code review
20:13 [Wireshark-commits] master dd7134d: Initialize whole buffer in GPRS Mobility and Session Management dissector Wireshark code review
20:13 [Wireshark-commits] master-1.12 c7874f7: Initialize whole buffer in GPRS Mobility and Session Management dissector Wireshark code review
20:14 [Wireshark-commits] master-1.10 abae269: Initialize whole buffer in GPRS Mobility and Session Management dissector Wireshark code review
20:24 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
21:56 [Wireshark-commits] master 1d92195: Have individual programs get libpcap and libz version info. Wireshark code review
22:06 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
22:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
22:23 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
22:49 [Wireshark-commits] master 9cdbb25: Don't report the run-time version of pcap if we weren't built with pcap. Wireshark code review
23:19 [Wireshark-commits] master 8702a6b: Remove some unneeded includes Wireshark code review
23:31 [Wireshark-commits] master e22d3c9: ssl: fix ClientKeyExchange, fix TLSv1.2 SKE for DH Wireshark code review
23:58 [Wireshark-commits] master 213189e: Move the routines to talk to dumpcap into a static libcapchild. Wireshark code review
June 24, 2014
00:04 [Wireshark-commits] master a442d7b: Include ZLIB_CFLAGS so we file zlib.h. Wireshark code review
00:18 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
00:20 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
00:28 [Wireshark-commits] master adf6b1a: For capchild headers, include <capchild/XXX.h>. Wireshark code review
00:28 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
00:36 [Wireshark-commits] master 7bbf35b: Fix some more capchild includes. Wireshark code review
00:37 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
00:48 [Wireshark-commits] master 7fe1f82: Fix name of library. Wireshark code review
00:55 [Wireshark-commits] master 9fe540c: dos2unix is now in Utils, not Base. Wireshark code review
01:48 [Wireshark-commits] master 0cf591c: Add a doxygen.cfg.in file for the capture child library. Wireshark code review
02:01 [Wireshark-commits] master 4976d67: Restore correct tree assignment. Wireshark code review
02:07 [Wireshark-commits] master f71a6d0: capture_ifinfo.c and capture_sync.c are now in libcapchild. Wireshark code review
02:08 [Wireshark-commits] master 836feeb: Remove unneeded sys/types.h Wireshark code review
02:08 [Wireshark-commits] master baf3e81: Get rid of trailing blanks. Wireshark code review
02:13 [Wireshark-commits] master 243fc40: Add libcapchild, remove the files that are now in it. Wireshark code review
02:32 [Wireshark-commits] master 0f76609: Remove unneeded include <sys/stat.h> Wireshark code review
03:11 [Wireshark-commits] master e68638f: usb iso urbs on linux can't possibly contain a setup packet Wireshark code review
03:28 [Wireshark-commits] master e978cad: Create capchild/doxygen.cfg Wireshark code review
03:35 [Wireshark-commits] master b671551: Another file to generate in the configure script. Wireshark code review
03:54 [Wireshark-commits] master 4105c48: Another capchild.lib -> libcapchild.lib. Wireshark code review
06:57 [Wireshark-commits] master 4f1d20a: proto_tree_add_uint() takes a value, not an encoding, as an argument. Wireshark code review
07:10 [Wireshark-commits] master dbd409d: Fix OS X CMake build. Wireshark code review
16:07 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz-Test buildbot-no-reply
16:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
17:25 [Wireshark-commits] master eaf6bf3: MBIM: add an option to force SMS PDU decoding format if MBIM_DEVICE_CAPS_INFO message was not captured Wireshark code review
19:26 [Wireshark-commits] master 65b7521: Ensure proto_item from subtree is initialized Wireshark code review
19:34 [Wireshark-commits] master 2a9cc7a: Correct indentation in make-dissector-reg Wireshark code review
19:35 [Wireshark-commits] master 830d1b1: Add quotes around MAKEDIR. Wireshark code review
19:36 [Wireshark-commits] master 00212e5: Fix sorting RTP Streams by jitter Wireshark code review
19:56 [Wireshark-commits] master b4d4218: OSPF Cleanup. Remove unnecessary TFS declarations Wireshark code review
20:05 [Wireshark-commits] master 5a3632e: Load WinPcap before we get the run-time information string. Wireshark code review
20:11 [Wireshark-commits] master deda668: Add the capchild directory to some lists of rules. Wireshark code review
20:49 [Wireshark-commits] master 0fb9369: Support -w even if we're not built with pcap. Wireshark code review
20:49 [Wireshark-commits] master-1.12 25d39ca: Support -w even if we're not built with pcap. Wireshark code review
20:50 [Wireshark-commits] master-1.10 ed39971: Support -w even if we're not built with pcap. Wireshark code review
21:59 [Wireshark-commits] master 2a1e3d1: Fix two bugs in kafka dissection Wireshark code review
22:01 [Wireshark-commits] master 09b86bd: GTK3: Fix changing filter expression's bg color based on validity Wireshark code review
22:02 [Wireshark-commits] master-1.12 018fa44: GTK3: Fix changing filter expression's bg color based on validity Wireshark code review
22:02 [Wireshark-commits] master-1.10 b82fbe7: GTK3: Fix changing filter expression's bg color based on validity Wireshark code review
22:28 [Wireshark-commits] master 83da877: Add back initializers dropped in g9356d5c689fa Wireshark code review
23:33 [Wireshark-commits] master-1.10 1bda08e: Add quotes around MAKEDIR. Wireshark code review
23:33 [Wireshark-commits] master-1.12 0db675d: Add quotes around MAKEDIR. Wireshark code review
23:36 [Wireshark-commits] master-1.12 e314763: Fix sorting RTP Streams by jitter Wireshark code review
23:42 [Wireshark-commits] master 29ecd11: convert to proto_tree_add_subtree[_format] Wireshark code review
23:43 [Wireshark-commits] master 3a943e9: Reduce maximum permitted leakage to 100KB Wireshark code review
23:55 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows-7-x64 buildbot-no-reply
June 25, 2014
02:15 [Wireshark-commits] master 5aa6cf9: Update my email address in a couple more spots. Wireshark code review
02:38 [Wireshark-commits] master a11879e: Get rid of an unused variable. Wireshark code review
08:20 [Wireshark-commits] master 3f43688: List elided_label.h only once. Wireshark code review
14:43 [Wireshark-commits] master 03f7a4b: Remove wiretap/AUTHORS (after ensuring all names are present in the top-level AUTHORS file). Wireshark code review
16:15 [Wireshark-commits] master 8ac87dc: fix_bug_10199: enhancement Telephony VoIP Call add ability to show all SIP Flows. Add SIP Flows menu option beside VoIP Calls. Flow for all SIP message types (which have a call-id) is shown in SIP Flow. Add useful info(original flow method, response code, cseq) to comment field in conversation and flow dialogs. Wireshark code review
16:35 [Wireshark-commits] master 888f22d: convert to proto_tree_add_subtree[_format] Wireshark code review
17:05 [Wireshark-commits] master 13a972b: DTPT: remove unused variables Wireshark code review
17:16 [Wireshark-commits] master 4224e35: ssl-utils: add missing ett registration Wireshark code review
17:58 [Wireshark-commits] master a8652ea: DLSw: ett2 proto_item variable is an input parameter for dissect_dlsw_capex() Wireshark code review
18:01 [Wireshark-commits] master e0461ec: Indicate tshark can read (-r) from stdin and named pipes now. Wireshark code review
18:53 [Wireshark-commits] master fd5b077: DLSw: better fix, as suggested by Evan Wireshark code review
20:27 [Wireshark-commits] master 8cde7a7: Boost the maximum packet size to 131072. Wireshark code review
20:27 [Wireshark-commits] master-1.12 9ade6ec: Boost the maximum packet size to 131072. Wireshark code review
20:30 [Wireshark-commits] master-1.10 b3bf922: Boost the maximum packet size to 131072. Wireshark code review
20:43 [Wireshark-commits] master 474b90e: Boost the maximum snapshot length to 262144, for USBPcap. Wireshark code review
20:43 [Wireshark-commits] master-1.12 4c4ae26: Boost the maximum snapshot length to 262144, for USBPcap. Wireshark code review
20:44 [Wireshark-commits] master-1.10 0134e95: Boost the maximum snapshot length to 262144, for USBPcap. Wireshark code review
21:06 [Wireshark-commits] master 765405d: Update a comment. Wireshark code review
21:06 [Wireshark-commits] master-1.12 9d8adb2: Update a comment. Wireshark code review
21:06 [Wireshark-commits] master-1.10 b986160: Update a comment. Wireshark code review
21:12 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows XP x86 buildbot-no-reply
22:30 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86 buildbot-no-reply
23:02 [Wireshark-commits] master 81963e7: Decrease TRAFFIC_CAPTURE_DURATION from 60s to 15s. Wireshark code review
23:03 [Wireshark-commits] master-1.10 bf2d11f: Decrease TRAFFIC_CAPTURE_DURATION from 60s to 15s. Wireshark code review
23:03 [Wireshark-commits] master-1.12 ced8a05: Decrease TRAFFIC_CAPTURE_DURATION from 60s to 15s. Wireshark code review
23:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
June 26, 2014
02:41 [Wireshark-commits] master b632c23: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
02:43 [Wireshark-commits] master 06cf499: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
02:59 [Wireshark-commits] master c63cd9f: New HP DTD dictionary file Wireshark code review
05:15 [Wireshark-commits] master 732656c: STUN: Add support of MS-ICE2 (Used by Lync) Wireshark code review
11:41 [Wireshark-commits] master f798709: convert to proto_tree_add_subtree[_format] Wireshark code review
11:48 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
11:50 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
12:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
12:20 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
13:09 [Wireshark-commits] master 7c1b5e9: Fix several compilation warnings Wireshark code review
14:07 [Wireshark-commits] master a09de61: Fix Function call argument is an uninitialized value Wireshark code review
15:26 [Wireshark-commits] master 1f724bc: iSER: Add iSER dissector support Wireshark code review
15:33 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
15:35 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:38 [Wireshark-commits] master c9b03b4: add a cast, the mask makes it safe (stupid compiler) Wireshark code review
17:47 [Wireshark-commits] master-1.12 b97d70d: Fix compilation of packet-btavdtp.c. Wireshark code review
21:34 [Wireshark-commits] master 4742fc8: Fixed linker flags for MSVC to not attempt to make and link a manifest Added solution "folder" for tests. Wireshark code review
22:21 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
June 27, 2014
00:48 [Wireshark-commits] master 9d4af5f: Check the validity of fields given to tshark with "-e": complain and exit if they aren't valid. Wireshark code review
00:51 [Wireshark-commits] master-1.12 35ee9d2: Check the validity of fields given to tshark with "-e": complain and exit if they aren't valid. Wireshark code review
01:39 [Wireshark-commits] master-1.10 8539d9e: Fix bug9931 'Encapsulated ethernet packets sometimes show invalid FCS' Wireshark code review
01:54 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 7 x64 buildbot-no-reply
02:47 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
03:21 [Wireshark-commits] master 06ba7b4: a USB urb of an unknown transfer type does not contain a setup packet Wireshark code review
03:22 [Wireshark-commits] master 1560b67: show an expert info if a non-control urb contains a setup packet Wireshark code review
03:25 [Wireshark-commits] master-1.12 a189ed8: handle TS packet reassembly for PES packets with 0 length field (unknown length) Wireshark code review
03:27 [Wireshark-commits] master 8d2eaaa: If we have no fields, don't try to iterate through them. Wireshark code review
03:27 [Wireshark-commits] master-1.12 713fbc6: If we have no fields, don't try to iterate through them. Wireshark code review
03:47 [Wireshark-commits] master a87e292: Tighten the dump-glossary test. Wireshark code review
03:52 [Wireshark-commits] master f36db97: RTCP: Add support for MS-RTP Support for Profile Specific Extensions from MS-RTP Support for RTCP Feedback Messages Support for Application Layer Feedback Messages. MS-RTP: Real-time Transport Protocol (RTP) Extensions http://msdn.microsoft.com/en-us/library/office/cc431492.aspx Wireshark code review
04:01 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
04:08 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
04:24 [Wireshark-commits] master f0d291b: In function 'dissect_rtcp_psfb': packet-rtcp.c:1232: warning: unused parameter 'top_item' Wireshark code review
07:41 [Wireshark-commits] master efc0a00: We're not currently using dissect_rtcp_psfb_remb(); #if 0 it out. Wireshark code review
08:44 [Wireshark-commits] master 9ef47ae: Report more information on a sync_xxx_open() call failure. Wireshark code review
08:55 [Wireshark-commits] master a67b7f5: Use GQueue for generating statistics Wireshark code review
09:18 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
10:37 [Wireshark-commits] master d894c2e: Use g_queue_free_full() only on GLib > 2.32 Wireshark code review
13:29 [Wireshark-commits] master 18e14a4: Have the makefile run windepoyqt if it exists to copy the required dlls to the install dir. Wireshark code review
June 28, 2014
05:57 [Wireshark-commits] master 929afd2: Fix several GTK warnings in Windows. Wireshark code review
12:05 [Wireshark-commits] master 7bf6862: convert to proto_tree_add_subtree[_format] Wireshark code review
12:16 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
12:17 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
12:22 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
12:30 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
17:41 [Wireshark-commits] master 5b9ceae: Remove unused variables post commit 7bf6862ecf0d0a508bf097f3b52d07bd19128272 Wireshark code review
23:23 [Wireshark-commits] master 78e328c: Fix missing g_list_next() with GLib < 2.32 Wireshark code review
June 29, 2014
00:03 [Wireshark-commits] master e1a8c95: Standardize the names of, and document, the taps and heuristic dissector tables made avaialble by these dissectors. Wireshark code review
13:10 [Wireshark-commits] master fe4b7ee: convert to proto_tree_add_subtree[_format] Wireshark code review
14:52 [Wireshark-commits] master e8a8d62: proto_tree_add_subtree[_format] Wireshark code review
15:05 [Wireshark-commits] master f174370: [Automatic manuf, services and enterprise-numbers update for 2014-06-29] Wireshark code review
15:07 [Wireshark-commits] master-1.12 a2e2571: [Automatic manuf, services and enterprise-numbers update for 2014-06-29] Wireshark code review
15:09 [Wireshark-commits] master-1.10 8a9573e: [Automatic manuf, services and enterprise-numbers update for 2014-06-29] Wireshark code review
17:50 [Wireshark-commits] master 60ffafd: Fix compile error when building w/o GNUTLS Wireshark code review
17:56 [Wireshark-commits] master e39e44d: GSM MAP: ensure that p2p_dir is always initialized before calling GSM SMS dissector Wireshark code review
18:16 [Wireshark-commits] master-1.12 1d08bee: GSM MAP: ensure that p2p_dir is always initialized before calling GSM SMS dissector Wireshark code review
18:36 [Wireshark-commits] master-1.10 f6609f6: GSM MAP: ensure that p2p_dir is always initialized before calling GSM SMS dissector Wireshark code review
21:18 [Wireshark-commits] master dd63ae2: proto_tree_add_subtree[_format] Wireshark code review
23:03 [Wireshark-commits] master fe42762: Move some more stuff into wsutil. Wireshark code review
23:21 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
23:22 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
23:27 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
23:29 [Wireshark-commits] master 8599b72: Put in missing forward declaration. Wireshark code review
23:32 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
23:36 [Wireshark-commits] master 53c2a4d: clopts_common.c is now part of wsutil. Wireshark code review
June 30, 2014
00:04 [Wireshark-commits] master fe8661a: clopts_common.c is now part of wsutil. Wireshark code review
01:36 [Wireshark-commits] master df58337: Move capture_ui_utils.[ch] to libui. Wireshark code review
05:09 [Wireshark-commits] master b33512b: Move capture_session.h to capchild; what it declares is defined there. Wireshark code review
05:13 [Wireshark-commits] master e2801d0: Windows: fix update of version information in wireshark and tshark Wireshark code review
05:22 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
05:29 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
05:30 [Wireshark-commits] master 7d1a93f: Make a routine unused outside capture_ui_utils.c static. Wireshark code review
05:39 [Wireshark-commits] master ad1391a: Move capture.[ch] to libui. Wireshark code review
06:00 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
06:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
07:35 [Wireshark-commits] master 241862a: Get rid of unused routine. Wireshark code review
08:14 [Wireshark-commits] master 01c9ac8: Get rid of another unused routine. Wireshark code review
12:28 [Wireshark-commits] master 9cf40b6: Fix Bug #10238: Display filter expression dialog items do not expand/display properly. Wireshark code review
12:29 [Wireshark-commits] master-1.12 1322190: Fix Bug #10238: Display filter expression dialog items do not expand/display properly. Wireshark code review
13:24 [Wireshark-commits] master 3b15891: Bluetooth: Add missing connection_handle Wireshark code review
13:24 [Wireshark-commits] master 099bc93: Logcat: Remove commented code Wireshark code review
14:14 [Wireshark-commits] master 9387979: Fix the display of AVP:s that are not fully dissected fixes Bug #10237 Wireshark code review
14:38 [Wireshark-commits] master 073bf49: From Johan Whahl: Added dissection of the SIP Service-Route header. Wireshark code review
14:44 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
21:08 [Wireshark-commits] master 60d0faf: Move proto_hier_stats.[ch] to libui. Wireshark code review
21:10 [Wireshark-commits] master f1ff663: Warn about unencrypted HTTP traffic over port 443 Wireshark code review
21:37 [Wireshark-commits] master 5e28386: Move stat_menu.h to libui. Wireshark code review
21:48 [Wireshark-commits] master c1d2b29: Move filters.[ch] to libui. Wireshark code review
21:50 [Wireshark-commits] master fe1ef6c: Get rid of trailing blank line. Wireshark code review
22:11 [Wireshark-commits] master a07dc8b: Add echld_test to the list of files we ignore (built with --enable-echld). Wireshark code review
22:36 [Wireshark-commits] master 0a2de4f: Always set the crash information. Wireshark code review
22:38 [Wireshark-commits] master-1.12 4b59394: Always set the crash information. Wireshark code review
22:39 [Wireshark-commits] master-1.10 b4eeb6a: Always set the crash information. Wireshark code review
22:51 [Wireshark-commits] master 62fa030: Do startup things in an order more like that of gtkshark. Wireshark code review
23:03 [Wireshark-commits] master ac88f71: Clean up a comment. Wireshark code review
23:12 [Wireshark-commits] master efafca7: Drop privileges very early on. Wireshark code review
23:15 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
23:20 [Wireshark-commits] master bb6f5ea: Reflect the move of filters.c to libui. Wireshark code review

Mail converted by MHonArc