Wireshark-commits, May 2014
May 01, 2014
03:03 [Wireshark-commits] master a53cd45: Fixed typo in docbook (usuall to usually) Wireshark code review
09:12 [Wireshark-commits] master 6e21a4b: Try to fix warning C4244: '-=' : conversion from '__int64' to 'int', possible loss of data Wireshark code review
11:35 [Wireshark-commits] master 60c580d: AT: do not always prepend "/" to protocol name Wireshark code review
11:52 [Wireshark-commits] master 2f960b7: gluster: add support for GlusterD v3 procedures Wireshark code review
12:12 [Wireshark-commits] master fbd3c93: Fix procedure of finding packages Wireshark code review
13:12 [Wireshark-commits] master 39b533e: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
13:13 [Wireshark-commits] master 601dc73: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
13:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
13:14 [Wireshark-commits] master 583a47c: Fix Dereference of null pointer found by Clang analyzer Wireshark code review
13:16 [Wireshark-commits] master 523fbe2: Unreachable code in ui/gtk/main.c Wireshark code review
13:24 [Wireshark-commits] master d3d4fb9: Add OSPF Authentication Trailer (RFC6506) Wireshark code review
13:48 [Wireshark-commits] master dedc090: Fix -Wunreachable-code found by Clang Wireshark code review
14:15 [Wireshark-commits] master 6a80524: Cleanup SPDY dissector. Wireshark code review
15:10 [Wireshark-commits] master b31381d: Add a comment re VS2013EE requiring that win32.mak needs to be separately obtained. Wireshark code review
15:11 [Wireshark-commits] master 5410fab: Add a comment re certain variables beibg defined in win32.mak. Wireshark code review
15:12 [Wireshark-commits] master a42b04e: Remove 'include win32.mak' from certain nmake files when not needed. Wireshark code review
19:04 [Wireshark-commits] master 4d55a12: MBIM: dissect MBIM_SET_STK_PAC and MBIM_STK_PAC_INFO messages Wireshark code review
May 02, 2014
05:48 [Wireshark-commits] master b5120cd: Add support for Logical Link Down TLV. TLV is 1 octet long, and only MSB holds info with 7 unused bits Wireshark code review
10:51 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz-Test buildbot-no-reply
13:12 [Wireshark-commits] master 2b2d8a9: Fix Dereference of null pointer found by Clang analyzer Wireshark code review
13:39 [Wireshark-commits] master 34fa169: Add a new Dissector for HiSLIP Wireshark code review
14:34 [Wireshark-commits] master f181756: Optimize wmem_strbuf_grow. Wireshark code review
14:37 [Wireshark-commits] master abc3879: Reintroduce wmem_allocator_force_new Wireshark code review
14:40 [Wireshark-commits] master c27ad66: Add modelines info Wireshark code review
14:41 [Wireshark-commits] master 13e8983: Add modelines info Wireshark code review
14:43 [Wireshark-commits] master fa84054: Enhance display of SPDY packet (Remove some information from column) Wireshark code review
21:07 [Wireshark-commits] master 5f23901: wmem: add new simple block allocator, use it in packet-scope. Wireshark code review
21:34 [Wireshark-commits] master b7d6055: Move value string of LLDP OUI to epan/oui.h Wireshark code review
21:35 [Wireshark-commits] master 59a4a85: ECP dissector Remove packet-lldp.h depends * Fix indent (use tabs) * Use VDP function for end VTPDU Wireshark code review
21:36 [Wireshark-commits] master a394d44: LLDP: Remove packet-lldp.h Wireshark code review
22:54 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
May 03, 2014
21:38 [Wireshark-commits] master 32e3e41: Update TODO comments Wireshark code review
21:39 [Wireshark-commits] master 1ddce8b: Have RRC tell MAC about RAPID ranges so it can show for RAPIDs seen Wireshark code review
21:46 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
21:50 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
21:53 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
21:54 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
21:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
22:00 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
23:51 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz-Test buildbot-no-reply
May 04, 2014
01:13 [Wireshark-commits] master 9606ec5: Remove enabling HAVE_SNOW3G by default Wireshark code review
02:55 [Wireshark-commits] master bdfe17f: GUI modules for LBM aka 29West dissectors. Wireshark code review
15:04 [Wireshark-commits] master e7a51d7: [Automatic manuf, services and enterprise-numbers update for 2014-05-04] Wireshark code review
15:07 [Wireshark-commits] master-1.10 a1df6a4: [Automatic manuf, services and enterprise-numbers update for 2014-05-04] Wireshark code review
15:09 [Wireshark-commits] master-1.8 d072858: [Automatic manuf, services and enterprise-numbers update for 2014-05-04] Wireshark code review
19:23 [Wireshark-commits] master 1d1730f: Update some soft-deprecated APIs. Wireshark code review
21:08 [Wireshark-commits] master 6c7ab45: MAC LTE: fix compilation error Wireshark code review
22:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
22:24 [Wireshark-commits] master 19e650f: Fuzz fewer iterations of the fast block allocator Wireshark code review
May 05, 2014
03:07 [Wireshark-commits] master 0b0c98a: set(<variable>) *undefines* the variable; a value must be specified. Wireshark code review
03:12 [Wireshark-commits] master 8f2f727: Not finding a non-required package is *NOT* an error! Wireshark code review
03:57 [Wireshark-commits] master f13bbf2: Fast block allocator: make wmem_block_fast_hdr_t single linked list. Wireshark code review
03:58 [Wireshark-commits] master 984e522: Fix possible buffer overflow in col_append_sep_fstr() Wireshark code review
04:28 [Wireshark-commits] master bf3fbb3: Add dissector for 3GPP2 A21/S102 protocol. Wireshark code review
06:05 [Wireshark-commits] master 16dfe11: Several tweaks to fast block allocator Wireshark code review
07:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
11:18 [Wireshark-commits] master 56b8c9e: Fix indent (use tab) and modelines Wireshark code review
11:19 [Wireshark-commits] master 491a321: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
11:32 [Wireshark-commits] master 402bbcb: Reduce wmem fast-block fuzz rounds even further Wireshark code review
12:52 [Wireshark-commits] master a0b76c9: Allow IPv6 Mobility Option Service Selection with option length = 1 Wireshark code review
13:07 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
13:08 [Wireshark-commits] master 9361938: Fix dead assignment found by clang in test code Wireshark code review
13:49 [Wireshark-commits] master ac99cfd: Media Agnostic USB Packet Dissector Wireshark code review
13:52 [Wireshark-commits] master a1ddde9: SSH dissector: fix MAC length calculation for recent OpenSSH features Wireshark code review
13:59 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
14:00 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
14:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
14:50 [Wireshark-commits] master 0523c2d: Fix build with older compilers Wireshark code review
14:54 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
15:25 [Wireshark-commits] master ce282a7: OpenFlow 1.3 OXM field OXM_OF_IPV6_ND_SLL incorrectly dissected (128 bits read instead of 48) Wireshark code review
15:26 [Wireshark-commits] master 33586a0: OpenFlow 1.4 OXM field OXM_OF_IPV6_ND_SLL incorrectly dissected (128 bits read instead of 48) Wireshark code review
15:26 [Wireshark-commits] master 326202f: Solaris doesn't like anonymous unions Wireshark code review
15:33 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
15:51 [Wireshark-commits] master 09a9c86: Add the possibillity to add a string to the termination id. Wireshark code review
16:57 [Wireshark-commits] master 2aa66aa: SSH Dissector : Remove ssh_proto_tree_add_item (No longer needed) Wireshark code review
17:12 [Wireshark-commits] master e35ccba: Add RFC6463 (Runtime Local Mobility Anchor (LMA) Assignment Support for Proxy Mobile IPv6) MIP6 Mobile Option Wireshark code review
18:20 [Wireshark-commits] master-1.8 8ad08b9: Fix possible buffer overflow in col_append_sep_fstr() Wireshark code review
18:20 [Wireshark-commits] master-1.10 b76f8c7: Fix possible buffer overflow in col_append_sep_fstr() Wireshark code review
18:23 [Wireshark-commits] master 2975593: libnl is a Linux-specific library; don't offer libnl support except on Linux. Wireshark code review
18:25 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
20:46 [Wireshark-commits] master eecc135: Added parentheses to macros to prevent unexpected behavior Wireshark code review
21:26 [Wireshark-commits] master 542b4e6: MAC/RLC/PDCP LTE: replace obsolete APIs Wireshark code review
May 06, 2014
02:30 [Wireshark-commits] master f764765: Increase the work used to time wmem allocators Wireshark code review
06:41 [Wireshark-commits] master be3a153: tcp: move & optimize printing tcp flags to seperate routine. Wireshark code review
06:48 [Wireshark-commits] master 209f82a: Cleanup LLDP dissection, convert add_text to tree items. Just started on this, more changes incoming Wireshark code review
06:49 [Wireshark-commits] master ecc6b8d: Move common part of col_append_fstr, col_append_sep_fstr to seperate fnction. Wireshark code review
06:55 [Wireshark-commits] master a4a851c: MySQL protocol dissector: Add support for sessiontracking in MySQL 5.7.4. Bug 9948. Wireshark code review
07:01 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
07:09 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
07:28 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
07:32 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
07:37 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
07:49 [Wireshark-commits] master 72662c2: Try to fix packet-mysql.c(1446) : warning C4244: 'function' : conversion from 'guint64' to 'gint', possible loss of data Wireshark code review
07:51 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
07:57 [Wireshark-commits] master da00889: Add a cast to make MSVC happy. Wireshark code review
07:58 [Wireshark-commits] master a915de5: Fix build failures caused by lldp cleanup Wireshark code review
14:03 [Wireshark-commits] master 4e82d2e: sigcomp: Add buffer check to STATE-ACCESS Wireshark code review
15:59 [Wireshark-commits] master 037fb82: Minor changes to LBM dissectors: (1) Display sequence numbers in both decimal and hex (2) Fix an inconsistency in field naming between LBT-RU and LBT-RM. Wireshark code review
16:00 [Wireshark-commits] master 910ab7b: Enhance Microsoft NLB dissection Wireshark code review
16:05 [Wireshark-commits] master 3851e09: Fix macro parens to avoid unexpected behaviour Wireshark code review
19:25 [Wireshark-commits] master c0fbe0d: Update kafka dissector closer to latest spec Wireshark code review
19:27 [Wireshark-commits] master d73fc0b: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
19:51 [Wireshark-commits] master 9a51c1e: Added check for MAUSB length being multiple of a DWORD. Wireshark code review
19:56 [Wireshark-commits] master ef24d48: VALS() doesn't take the address of a (pointer to a) value_string, it takes a pointer to a value_string. Wireshark code review
19:57 [Wireshark-commits] master d3a1cde: fix dissect_usb_endpoint_descriptor Wireshark code review
20:32 [Wireshark-commits] master ec5ba07: Tweak ber_choice flow control. Wireshark code review
21:34 [Wireshark-commits] master 2e16091: Don't pass the address of a pointer to a *_string to VALS() or RVALS(). Wireshark code review
21:43 [Wireshark-commits] master 398c81a: PDCP LTE: add identification of ZUC based security algorithms Wireshark code review
22:21 [Wireshark-commits] master 6011d2e: "Reserved" is not a valid 'fieldconvert' value for an hf. Wireshark code review
May 07, 2014
00:52 [Wireshark-commits] master 8c167e1: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
00:54 [Wireshark-commits] master 45b6780: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
04:32 [Wireshark-commits] master 9b78301: Further LLDP dissection cleanup Wireshark code review
05:37 [Wireshark-commits] master 24ca06f: Make it pass the new check in checkapi "Error out if someone passes the address of a pointer to a *_string to VALS() or RVALS()." Wireshark code review
05:37 [Wireshark-commits] master 3430987: Error out if someone passes the address of a pointer to a *_string to VALS() or RVALS(). Wireshark code review
05:44 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
05:46 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
05:46 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
05:50 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
05:50 [Wireshark-commits] master b07195a: Fix a typo. Wireshark code review
05:50 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
05:51 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
05:54 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
09:00 [Wireshark-commits] master f3b6316: Use a strong hash function for ethernet addresses. Wireshark code review
23:53 [Wireshark-commits] master 18ee622: Add handling of TEXT and HTML types. Wireshark code review
May 08, 2014
00:31 [Wireshark-commits] master 078daeb: Populate heuristic extension list during initialization and not during each call to heuristic_uses_extension. Wireshark code review
02:15 [Wireshark-commits] master 8352880: Recognize kafka's ConsumerMetadata message type Wireshark code review
06:29 [Wireshark-commits] master 4eaf1c8: MAC LTE: get extended BSR sizes configuration from RRC Wireshark code review
10:51 [Wireshark-commits] master 54be3ea: TCAP: set a fence on info column after calling sub dissector Wireshark code review
11:08 [Wireshark-commits] master f058946: packet-dis: correct 'Terminal Primary Mode' and 'Sync State' enumeration values Wireshark code review
13:04 [Wireshark-commits] master a7ac739: MAC LTE: fix copy/paste error Wireshark code review
13:31 [Wireshark-commits] master-1.10 efd7ec4: TCAP: set a fence on info column after calling sub dissector Wireshark code review
13:39 [Wireshark-commits] master 75bbbc2: Prettify a little, by showing ike2 flag values in flag root, and showing MID and flags in Info column Wireshark code review
13:41 [Wireshark-commits] master-1.8 46df3d6: TCAP: set a fence on info column after calling sub dissector Wireshark code review
13:50 [Wireshark-commits] master 8070155: Remove trailing whitespace Wireshark code review
15:02 [Wireshark-commits] master e46d144: Small fix to how number of traffic classes is displayed for ETS. Used proto_tree_add_uint_format_valu instead of append_text Wireshark code review
15:42 [Wireshark-commits] master a8456cc: MAC LTE: add a comment explaining why g_hash_table_lookup_extended is used Wireshark code review
15:44 [Wireshark-commits] master d0cf941: Fix a whitespace after IKE_AUTH Wireshark code review
19:30 [Wireshark-commits] master 379c9f2: Add a command option for dumpcap. Wireshark code review
19:58 [Wireshark-commits] master aa3a968: Profiling show that g_log() takes a lot of CPU even when logging isn't active. Wireshark code review
May 09, 2014
03:04 [Wireshark-commits] master 1abeb27: Refactor Wiretap Wireshark code review
03:11 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
03:11 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
03:12 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
03:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
03:49 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
03:51 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
04:30 [Wireshark-commits] master f5a0d7e: Try to fix the build boot by changing the signature of catapult_dct2000_dump() to the declared one. Wireshark code review
04:31 [Wireshark-commits] master 9edba65: Use g_ alloced memory (instead of emem) when printing fields. emem shouldn't be used for GUI functions. Wireshark code review
05:20 [Wireshark-commits] master a651f3e: Revert "Try to fix the build boot by changing the signature of catapult_dct2000_dump() to the declared one." Wireshark code review
05:21 [Wireshark-commits] master a1b1c8b: Revert "Refactor Wiretap" Wireshark code review
07:51 [Wireshark-commits] master e5cfd9e: Squelch compiler warnings. Wireshark code review
09:03 [Wireshark-commits] master 3f247a5: Be less aggressive about rebuilding sminmpec.c. Wireshark code review
12:13 [Wireshark-commits] master cfe3bfd: Add -Q for QtShark and change the dumpcap command to use number of packets. Wireshark code review
15:14 [Wireshark-commits] master 532c3bc: Initialize int_seid to 0 in btavdtp dissector Wireshark code review
15:20 [Wireshark-commits] master 877942c: Revert "Use g_ alloced memory (instead of emem) when printing fields. emem shouldn't be used for GUI functions." Wireshark code review
15:50 [Wireshark-commits] master-1.10 9f6a834: Be less aggressive about rebuilding sminmpec.c. Wireshark code review
16:19 [Wireshark-commits] master-1.8 78563c2: Be less aggressive about rebuilding sminmpec.c. Wireshark code review
17:09 [Wireshark-commits] buildbot failure in Wireshark 1.8 on Windows-XP-x86 buildbot-no-reply
17:14 [Wireshark-commits] buildbot failure in Wireshark 1.8 on Ubuntu-12.04-x64 buildbot-no-reply
May 10, 2014
15:42 [Wireshark-commits] master dac0a0c: packet-link16: Link 16 message dissector (MIL-STD-6016) Wireshark code review
May 11, 2014
03:17 [Wireshark-commits] master 43bb76a: Function to calculate twos complement is quicker and hopefully better understandable. Wireshark code review
07:28 [Wireshark-commits] master d13e139: Interpret DHCPv6 option 18 as a byte array. RFC 3315, section 22.18 strongly suggests that any other such interpretation is inappropriate: Wireshark code review
12:44 [Wireshark-commits] master dc8357d: packet-link16: fix typos Wireshark code review
12:45 [Wireshark-commits] master 06657ca: packet-dis: fix typos Wireshark code review
15:35 [Wireshark-commits] master 2f023ea: [Automatic manuf, services and enterprise-numbers update for 2014-05-11] Wireshark code review
15:35 [Wireshark-commits] master-1.10 0bd3ab1: [Automatic manuf, services and enterprise-numbers update for 2014-05-11] Wireshark code review
15:35 [Wireshark-commits] master-1.8 c143130: [Automatic manuf, services and enterprise-numbers update for 2014-05-11] Wireshark code review
15:36 [Wireshark-commits] master 8e37416: Fix leaking heuristic dissector names. Wireshark code review
15:36 [Wireshark-commits] master 4ca79e9: Remove some dead emem code. Wireshark code review
15:50 [Wireshark-commits] master 5d98ab7: Simplify IPv4 address hashing Wireshark code review
16:47 [Wireshark-commits] master e2eea89: Small fixes to Follow Streams dialog box: - get the right IPv6 client address - display the right client to server string for UDP/SSL in Qt port Wireshark code review
16:47 [Wireshark-commits] master df2dc92: packet-dis: SISO-J Link 16 PDU dissector (SISO-STD-002) Wireshark code review
16:53 [Wireshark-commits] master 4af23b0: Fix display of unidirectional follow TCP/UDP streams Wireshark code review
16:54 [Wireshark-commits] master 44d83c2: Don't build update-sminmpec by default when using CMake. Wireshark code review
17:01 [Wireshark-commits] master 98f608c: Identify client/server by their IP address and port number in follow streams dialog box Wireshark code review
17:04 [Wireshark-commits] master-1.10 ccce29a: Don't build update-sminmpec by default when using CMake. Wireshark code review
17:04 [Wireshark-commits] master-1.8 3784556: Don't build update-sminmpec by default when using CMake. Wireshark code review
18:09 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz-Test buildbot-no-reply
18:09 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
18:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
18:10 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Ubuntu-12.04-x64 buildbot-no-reply
18:10 [Wireshark-commits] buildbot failure in Wireshark 1.8 on Windows-XP-x86 buildbot-no-reply
18:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
18:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
18:11 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows-XP-x86 buildbot-no-reply
19:25 [Wireshark-commits] master 7a010fa: NEWS got updated again. This shows two inconsistencies how Gerald's and my machine generate this file: - Line width seems to be different - We use different time zones. Is there a way to make at least the first point consistent? Wireshark code review
19:35 [Wireshark-commits] master 03f75dd: It is possible to check out a source tree that is not co-located with the .git repository. First attempts to support that setup. Wireshark code review
21:13 [Wireshark-commits] master ff466a9: Increase time permitted when fuzzing with valgrind. Wireshark code review
23:13 [Wireshark-commits] master d73400a: Minor optimization to packet-frame.c Wireshark code review
May 12, 2014
01:41 [Wireshark-commits] master 9554b2f: Condense DIS dissector to a single file. Wireshark code review
05:20 [Wireshark-commits] master d1d5caa: Fix tshark -z follow, tcp stats regression when TCP stream index is > 0 Wireshark code review
16:00 [Wireshark-commits] master 483e459: Do some cleanup related to deprecated function names and revised function return values): Wireshark code review
17:05 [Wireshark-commits] master 9803122: Ignore SIGPIPE on systems that have it. Wireshark code review
20:15 [Wireshark-commits] master a22b912: Added dissection of EPHandleDelete Req & Resp packets Wireshark code review
21:45 [Wireshark-commits] master d7befa8: Fix copy-and-paste error with cause value_strings, and change indentation to match generated code Wireshark code review
21:49 [Wireshark-commits] master 89e61b9: Save the result of tvb_reported_length_remaining() and use it to reduce the number of calls to tvb_reported_length_remaining(). Wireshark code review
22:17 [Wireshark-commits] master 2981ae4: Add default paths for the Qt online installer for Windows. Wireshark code review
May 13, 2014
04:17 [Wireshark-commits] master f1c2406: Allow 16 SAs to be added, but allocate on heap to avoid growing stack Wireshark code review
04:21 [Wireshark-commits] master 44191fc: Dumber "simple" wmem allocator. Wireshark code review
04:28 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
04:30 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
04:42 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
05:12 [Wireshark-commits] master 67bc394: IPsec: fix implicit conversion of pointer warning Wireshark code review
05:13 [Wireshark-commits] master-1.10 b765985: Small fixes to Follow Streams dialog box: - get the right IPv6 client address - display the right client to server string for UDP/SSL in Qt port Wireshark code review
05:15 [Wireshark-commits] master-1.10 f6b86a4: Identify client/server by their IP address and port number in follow streams dialog box Wireshark code review
06:27 [Wireshark-commits] master fb1e251: LLDP cleanup : Management Address TLV Wireshark code review
08:45 [Wireshark-commits] master c32fb05: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
09:10 [Wireshark-commits] master f964740: Enhance HTTP2 dissector * Add missing padding for CONTINUATION frame * Add filter for generated padding length * add unused flags Wireshark code review
11:49 [Wireshark-commits] master cd8188d: Reduce the number of calls to tvb_reported_lenght_remaining(). Wireshark code review
16:07 [Wireshark-commits] master f7819de: In ascii_xx_inplace use g_ascii_isupper/g_ascii_islower directly, it *should* be slightly more efficient. Wireshark code review
16:14 [Wireshark-commits] master 3157bf6: isprint() -> g_ascii_isprint() Wireshark code review
16:38 [Wireshark-commits] master 218b8c9: HTTP2 enhance display when priority flag is set * Add bitmask and fix length for exclusive flag * Add missing bitmask for stream dependency * Add fielder with calcultated weight value (weight+1, see spec for more information) Wireshark code review
16:41 [Wireshark-commits] master 2c00d66: Use pre-scan command line parameters with double while(opt=getopt...) Wireshark code review
May 14, 2014
02:26 [Wireshark-commits] master dcdd076: pcapng->interface_data is an array of interface_data_t. Wireshark code review
10:46 [Wireshark-commits] master 2828bf7: The filter string can only be valid, if an interface is selected. Wireshark code review
10:50 [Wireshark-commits] master 836530e: - Replace tvb_length_remaining -> tvb_captured_length_remaining, - Use length_remaining in tvb_find_line_end() rather than -1 it should give a faster code path. Wireshark code review
15:38 [Wireshark-commits] master-1.10 1283e76: Get rid of the background pixmap, set the background color directly. Wireshark code review
15:41 [Wireshark-commits] master b2055d7: Update enums to SISO_REF_010-00v20-0 Annex A, section A.1 and A.2 Wireshark code review
15:42 [Wireshark-commits] master beb119f: Don't use -1 as length in frame dissector. Wireshark code review
15:44 [Wireshark-commits] master fbf3391: - curr_layer_num got wrong for STUN. - Change depreciated API. Wireshark code review
15:45 [Wireshark-commits] master aa5d912: Add a comment indicating that 'PLATFORM' is apparently set only for X64. Wireshark code review
16:59 [Wireshark-commits] master d7c4bde: tcp: display calculated checksum Wireshark code review
17:05 [Wireshark-commits] master-1.10 40fe99a: Deleted one line to much in previous chgange. Wireshark code review
17:12 [Wireshark-commits] master a1b9393: Revert "Don't throw for offset at end of TVB with len -1." Wireshark code review
17:29 [Wireshark-commits] master-1.10 5cdb0c3: Don't use -1 as length in frame dissector. Wireshark code review
17:30 [Wireshark-commits] master-1.10 6a77ad9: Manually apply https://code.wireshark.org/review/1289 to master-1.10: Wireshark code review
18:53 [Wireshark-commits] master bc15fad: AMQP: always display its name in protocol column, whatever the protocol version Wireshark code review
19:18 [Wireshark-commits] master 99e92ac: Drop unused voip_bg.xpm Wireshark code review
20:04 [Wireshark-commits] master 9c07e97: Add an expert info for GT with no digits. Wireshark code review
20:05 [Wireshark-commits] master d7f1ac3: wmem documentation updates Wireshark code review
May 15, 2014
02:31 [Wireshark-commits] master b8f0e8c: Eliminate some calls to tvb_get_ptr(). Wireshark code review
03:02 [Wireshark-commits] master 1bfe396: Get rid of some uses of tvb_get_ptr(). Wireshark code review
03:16 [Wireshark-commits] master 09bf170: Get rid of some uses of tvb_get_ptr(). Wireshark code review
03:23 [Wireshark-commits] master 84fcadc: Get rid of some uses of tvb_get_ptr(). Wireshark code review
03:50 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
04:02 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
04:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
04:17 [Wireshark-commits] master 45da41d: Fix declaration to match definition. Wireshark code review
11:58 [Wireshark-commits] master 53eeff6: Do not leave the Options Interfaces Dialog open, when the Main Window is closed. Wireshark code review
12:08 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
14:32 [Wireshark-commits] master 773c02d: diameter_3gpp: Dissect Feature-List flags in Gx message Wireshark code review
20:18 [Wireshark-commits] master 37fd797: STUN dissector: fix hf name (stun_... => hf_stun_....) Wireshark code review
20:19 [Wireshark-commits] master 7ba7612: STUN dissector: fix (soft) warning about tvb_length Wireshark code review
May 16, 2014
02:38 [Wireshark-commits] master aa922b0: Try to fix stack-buffer-overflow caught by ASAN Wireshark code review
05:34 [Wireshark-commits] master 59eb8cf: Make (almost) all fields filterable and use "normal" dissection functions to do it. Wireshark code review
05:42 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
06:57 [Wireshark-commits] master 6989feb: DNS: Use acronyms from RFC7218 for DANE / TLSA Wireshark code review
06:59 [Wireshark-commits] master c24ede3: DNS: fix soft-deprecated APIs Wireshark code review
14:17 [Wireshark-commits] master c3513b4: Add modelines info Wireshark code review
14:18 [Wireshark-commits] master 33750ab: IP Protocol : Update description of IP Protocol Wireshark code review
16:18 [Wireshark-commits] wireshark-win32-libs rev 444: / /trunk/packages/: gtk+-bundle_2.24.23-1.1_win32ws.zip /trunk/: README.txt gerald
16:19 [Wireshark-commits] wireshark-win64-libs rev 398: / /trunk/packages/: gtk+-bundle_2.24.23-1.1_win64ws.zip /trunk/: README.txt gerald
16:20 [Wireshark-commits] wireshark-win32-libs rev 445: /tags/2014-05-16/ gerald
16:21 [Wireshark-commits] wireshark-win64-libs rev 399: /tags/2014-05-16/ gerald
16:25 [Wireshark-commits] master 0a24908: Build with GTK+ 2.24.23. Wireshark code review
22:17 [Wireshark-commits] master ba3c0d7: Show EMM and ESM causes in the Info column Wireshark code review
May 17, 2014
06:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
07:21 [Wireshark-commits] master a42df48: Use a pre allocated buffer in wmem_strdup_vprintf() reduces the function cost by more than half. Wireshark code review
07:21 [Wireshark-commits] master 89a72f3: Add SAE authentication algorithm in 802.11 Wireshark code review
12:04 [Wireshark-commits] master 8129c2d: Add casts to fix OSX 10.6 buildbot Wireshark code review
12:07 [Wireshark-commits] master 25ba4a2: Guard closing capture window with ifdef. Wireshark code review
12:20 [Wireshark-commits] master 72a6a8c: Fixes after wmem_strdup_vprintf() optimization Wireshark code review
12:30 [Wireshark-commits] master 9fe221a: Fix newly optimized strdup_vprintf. Wireshark code review
12:41 [Wireshark-commits] master 3aee917: wiretap: remove unused code, drop number_of_interfaces Wireshark code review
13:33 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
13:38 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
13:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
17:22 [Wireshark-commits] master cea149a: wiretap: fix regression, missing initialization Wireshark code review
17:39 [Wireshark-commits] master 2408297: lua: fix buffer underrun Wireshark code review
21:33 [Wireshark-commits] master ea95c83: Introduce col_add_lstr(), use it instead of slower col_add_fstr. Wireshark code review
21:44 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
21:48 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
22:29 [Wireshark-commits] master 2d0507e: Use gsize rather than int, to avoid some complaints about shortening. Wireshark code review
May 18, 2014
16:18 [Wireshark-commits] master 9705c9b: [Automatic manuf, services and enterprise-numbers update for 2014-05-18] Wireshark code review
16:19 [Wireshark-commits] master-1.10 828466c: [Automatic manuf, services and enterprise-numbers update for 2014-05-18] Wireshark code review
16:19 [Wireshark-commits] master-1.8 4a91654: [Automatic manuf, services and enterprise-numbers update for 2014-05-18] Wireshark code review
19:37 [Wireshark-commits] master 5701cea: - Modify Cisco Compatible Extentions MFP dissection - Add Cisco Compatible Extensions DTPC dissection Wireshark code review
20:13 [Wireshark-commits] master 5235dc6: Only call ep_tcp_port_to_display/ep_udp_port_to_display once for sorce and destination ports. Wireshark code review
20:28 [Wireshark-commits] master fe05383: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
May 19, 2014
00:18 [Wireshark-commits] master faeb050: Mysql : add new flag for server status flags Wireshark code review
00:21 [Wireshark-commits] master ca6441e: MySQL: add new (extended) Capability flags Wireshark code review
00:22 [Wireshark-commits] master f75f47b: MySQL: fix soft-deprecated APIs Wireshark code review
01:46 [Wireshark-commits] master e5353bf: Use g_ alloced memory (instead of emem) when printing fields. emem shouldn't be used for GUI functions anyway. Wireshark code review
02:21 [Wireshark-commits] master 12d9fb7: udp: display calculated checksum Wireshark code review
02:21 [Wireshark-commits] master e6d6183: ip: display calculated checksum Wireshark code review
02:27 [Wireshark-commits] master d7bd2ec: Add new proto_tree_add_format_text() function Wireshark code review
09:14 [Wireshark-commits] master 4222091: change the satellite frequency into a float (freq in GHz) and make it filterable Wireshark code review
09:37 [Wireshark-commits] master 0adac83: convert SEK and SIV to their binary form only once when a new key/iv is set, don't do the same conversion for each apdu Wireshark code review
17:14 [Wireshark-commits] master 69623c9: Increase frag_id for self contained subpackets in mp2t packets. This fix length calculation on second pass. Wireshark code review
17:22 [Wireshark-commits] master 78ba6e4: Fix warning about the adaptation field control for docsis packet. The specs actually say that it should be set to 1. Wireshark code review
20:13 [Wireshark-commits] master 868fa65: Remove incorrect _U_ flag in dissect_mausb signature Wireshark code review
22:01 [Wireshark-commits] master eef176d: DIS: update enumerations to SISO-REF-010-00v20-0 Wireshark code review
May 20, 2014
16:15 [Wireshark-commits] master 12d297e: PCP : Enhance display of Option... * Display reserved using FT_BYTES * Set option code in option subtree Wireshark code review
16:17 [Wireshark-commits] master 9c08654: PCP: Add Description Option for the Port Control Protocol (RFC 7220) Wireshark code review
16:19 [Wireshark-commits] master 98991c3: PCP: Discovering NAT64 IPv6 Prefixes Using the Port Control Protocol (RFC7225) Wireshark code review
16:19 [Wireshark-commits] master 88ff6c0: PCP: Remove whitespace before ( Wireshark code review
16:23 [Wireshark-commits] master e9f5dcf: Dissect Key/Value Address Pair LCAF Wireshark code review
18:35 [Wireshark-commits] master c7cea8f: Update ELP LCAF dissection to new draft revision Wireshark code review
18:36 [Wireshark-commits] master 7e4b8a1: Fix error in dcbx feature TLV dissection. Willing and Error bits were flipped Wireshark code review
19:15 [Wireshark-commits] master 57e380a: SSL/TLS: Add Padding Extension (20) Wireshark code review
19:18 [Wireshark-commits] master 33fc6e6: Fix the SET_ADDRESS_HF() macro. Wireshark code review
22:01 [Wireshark-commits] master 572e76b: Don't panic in case of mediaproxy-ng/rtpengine extension Wireshark code review
22:05 [Wireshark-commits] master 438d1f8: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
22:12 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
22:14 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
22:26 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
May 21, 2014
02:06 [Wireshark-commits] master 2b0ad54: Fix indent (use tabs) Wireshark code review
02:49 [Wireshark-commits] master 5d8c3cc: Dissect Source/Destination 2-Tuple Lookups LCAF Wireshark code review
03:02 [Wireshark-commits] master 0ac1779: Add cast to satisfy buildbot Wireshark code review
03:17 [Wireshark-commits] master a1e6b10: Fix lua directory tests. Wireshark code review
12:04 [Wireshark-commits] master fa3eecf: Add MAC address family numbers (RFC 7042) Wireshark code review
12:05 [Wireshark-commits] master 93630b5: Add value to correct tree in Key/Value LCAF Wireshark code review
13:03 [Wireshark-commits] master 87573a6: Dissect Replication List Entries LCAF Wireshark code review
17:09 [Wireshark-commits] master 3a60f8d: LISP: Add support for MAC address AFI Wireshark code review
17:21 [Wireshark-commits] master a150988: Dissect Multicast Group Membership Information LCAF Wireshark code review
17:44 [Wireshark-commits] master bb01c7a: Remove extra parentheses. Wireshark code review
20:17 [Wireshark-commits] master 2cfda31: Change the signature of dissector_try_heuristic() to return hdtbl_entry which can be used to call the found heuristic dissector on the next pass. Wireshark code review
21:18 [Wireshark-commits] master 011a330: DIS: implement IFF PDU Wireshark code review
23:03 [Wireshark-commits] master 0cb180a: Print the values in the BSS Load Element in human readable format as well. Wireshark code review
May 22, 2014
03:29 [Wireshark-commits] master adb3f70: Wrong length of Modulation Type and Modulation System fields in Satellite Delivery Descriptor Wireshark code review
07:13 [Wireshark-commits] master db4abb6: LLDP Cleanup : 802.3 TLV Wireshark code review
11:04 [Wireshark-commits] master e92ee35: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
13:52 [Wireshark-commits] master 19c1989: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
15:05 [Wireshark-commits] master 177c655: Tighten heuristic checks for IEEE 802.15.4 protocols, and add Decode-As by PANID for when we still get it wrong. Wireshark code review
15:12 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
15:13 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
15:18 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
15:18 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
15:18 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
15:22 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
15:49 [Wireshark-commits] master e1ab96c: Missed update of one dissector_try_heuristic() when merging. ssed# asn1/s1ap/s1ap.diff Wireshark code review
16:35 [Wireshark-commits] master a60c661: Call dissect_ip_tcp_options to save the window scale. Wireshark code review
19:08 [Wireshark-commits] master b762dd0: GSM SIM: fix a typo and update obsolete API calls Wireshark code review
20:57 [Wireshark-commits] master c4ca41e: RADIUS: Remove double space before type (t=...) Wireshark code review
21:55 [Wireshark-commits] master b48a215: Don't use sizeof(guintN) for sizes of data in packets. Wireshark code review
May 23, 2014
02:13 [Wireshark-commits] master-1.10 3057ffc: Rework debug_print_hash logic so that it's supported by older versions of perl. Wireshark code review
02:49 [Wireshark-commits] master-1.10 45e901d: Use g_ alloced memory (instead of emem) when printing fields. emem shouldn't be used for GUI functions anyway. Wireshark code review
02:57 [Wireshark-commits] master 6287efb: tvb parameter should not be NULL as the lengths are nonzero. Wireshark code review
03:00 [Wireshark-commits] master-1.10 177affe: tvb parameter should not be NULL as the lengths are nonzero. Wireshark code review
03:02 [Wireshark-commits] master c0c480d: Allow wtap_read() and wtap_seek_read() to return non-packet records. Wireshark code review
03:05 [Wireshark-commits] master 2456b22: Fix some white space issues. Wireshark code review
03:35 [Wireshark-commits] master 7a706d6: Add cast to please mac buildbot Wireshark code review
03:37 [Wireshark-commits] master 1f26536: Add jumbo-allocation support to wmem fast block Wireshark code review
04:53 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
05:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
05:21 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
07:23 [Wireshark-commits] master ca97ba0: Update comment about -Wunreachable-code and -Wdocumentation Wireshark code review
10:48 [Wireshark-commits] master 716fdc8: Revert "Fix some white space issues." Wireshark code review
10:50 [Wireshark-commits] master a344c97: Revert "Allow wtap_read() and wtap_seek_read() to return non-packet records." Wireshark code review
12:47 [Wireshark-commits] master eb3cdb9: Zero out pinfo->src and dst before adding a frag. Wireshark code review
13:16 [Wireshark-commits] master 8393390: Dissect AS Number LCAF Wireshark code review
13:23 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
13:25 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
13:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
15:08 [Wireshark-commits] master c94987d: Dissect Nonce Locator LCAF Wireshark code review
15:08 [Wireshark-commits] master de29a8d: LISP : error: declaration of 'address' shadows a global declaration [-Werror=shadow] Wireshark code review
15:22 [Wireshark-commits] master 16d7dca: SIP: parse ports definition in security mechanism Wireshark code review
15:24 [Wireshark-commits] master 1c5e92d: SIP: remove leading spaces/tabs between security parameters Wireshark code review
15:26 [Wireshark-commits] master 0eafcb9: Fix -Wdocumentation Wireshark code review
15:48 [Wireshark-commits] master 5896e2c: Improve handling of short MQTT PDUs. Wireshark code review
17:48 [Wireshark-commits] master bbfdfa4: Remove trailing blank lines. Wireshark code review
17:52 [Wireshark-commits] master f6f5985: Fix the type of i4b_read_rec() to reflect what it actually returns. Wireshark code review
17:53 [Wireshark-commits] master a267f16: Get rid of trailing blank lines. Wireshark code review
17:57 [Wireshark-commits] master f8d7255: Get rid of extra trailing blank lines. Wireshark code review
17:59 [Wireshark-commits] master 1a9336b: Fix a comment. Wireshark code review
18:03 [Wireshark-commits] master ae1ec15: Get rid of extra trailing blank lines. Wireshark code review
18:07 [Wireshark-commits] master 7f6f5fc: Fix comment. Wireshark code review
18:10 [Wireshark-commits] master 8ce793c: file_seek() sets the error variable; no need to set it ourselves. Wireshark code review
18:53 [Wireshark-commits] master 8a7e1f4: Don't assume all packets have time stamps. Wireshark code review
19:26 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
20:38 [Wireshark-commits] [wireshark] branch master-1.12 created (now 8a7e1f4) Wireshark code review
20:48 [Wireshark-commits] master-1.12 7da8c2a: Initialize master-1.12. Wireshark code review
20:50 [Wireshark-commits] [wireshark] annotated tag v1.12.0-rc1 created (now 82ccefd) Wireshark code review
20:57 [Wireshark-commits] master 285405a: 1.11.4 → 1.99.0. Wireshark code review
21:00 [Wireshark-commits] [wireshark] annotated tag v1.99.0-rc1 created (now 60c5072) Wireshark code review
21:04 [Wireshark-commits] master f635efb: More checks for the presence of a time stamp. Wireshark code review
21:56 [Wireshark-commits] master-1.12 1f897cc: More checks for the presence of a time stamp. Wireshark code review
22:36 [Wireshark-commits] master dc0ff56: More checks for the presence of a time stamp. Wireshark code review
22:38 [Wireshark-commits] master-1.12 73c9c7c: More checks for the presence of a time stamp. Wireshark code review
23:24 [Wireshark-commits] master 9e2db54: Set the presence flags. Wireshark code review
23:24 [Wireshark-commits] master-1.12 b056e18: Set the presence flags. Wireshark code review
23:41 [Wireshark-commits] master d470a46: More handling of missing time stamps. Wireshark code review
23:41 [Wireshark-commits] master-1.12 d5d0f51: More handling of missing time stamps. Wireshark code review
23:44 [Wireshark-commits] master f67fc8a: Fix some whitespace issues. Wireshark code review
23:45 [Wireshark-commits] master-1.12 95a057a: Fix some whitespace issues. Wireshark code review
May 24, 2014
06:51 [Wireshark-commits] master 33ae4cb: Fixed mausb valid bit & added invalid_valid TFS Wireshark code review
18:31 [Wireshark-commits] master 6db77b0: Allow wtap_read() and wtap_seek_read() to return records other than packets. Wireshark code review
19:13 [Wireshark-commits] master-1.12 2310c43: Allow wtap_read() and wtap_seek_read() to return records other than packets. Wireshark code review
20:57 [Wireshark-commits] master 1b6cc63: Add support for plugins to handle pcap-ng block types. Wireshark code review
20:58 [Wireshark-commits] master-1.12 9b03a0e: Add support for plugins to handle pcap-ng block types. Wireshark code review
21:04 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
21:05 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
21:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
21:21 [Wireshark-commits] master d5b1730: Fix a compiler warning. Wireshark code review
21:21 [Wireshark-commits] master-1.12 782d41e: Fix a compiler warning. Wireshark code review
21:50 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
21:54 [Wireshark-commits] master 6dffc3b: Distinguish between "events" and "reports". Wireshark code review
21:55 [Wireshark-commits] master-1.12 c74afc3: Distinguish between "events" and "reports". Wireshark code review
21:58 [Wireshark-commits] master-1.12 1d20394: Fixed mausb valid bit & added invalid_valid TFS Wireshark code review
May 25, 2014
00:05 [Wireshark-commits] master 318cf8a: Add support for dissecting non-packet records. Wireshark code review
00:05 [Wireshark-commits] master-1.12 0c2fdbc: Add support for dissecting non-packet records. Wireshark code review
00:36 [Wireshark-commits] master 088b064: Add support for dissecting pcap-ng file-type-specific blocks. Wireshark code review
00:36 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
00:36 [Wireshark-commits] master-1.12 59509c2: Add support for dissecting pcap-ng file-type-specific blocks. Wireshark code review
00:38 [Wireshark-commits] master 3229854: Get rid of trailing blank. Wireshark code review
00:38 [Wireshark-commits] master-1.12 1f5f8ed: Get rid of trailing blank. Wireshark code review
00:51 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
15:24 [Wireshark-commits] master ff2061a: [Automatic manuf, services and enterprise-numbers update for 2014-05-25] Wireshark code review
15:25 [Wireshark-commits] master-1.12 a83174e: [Automatic manuf, services and enterprise-numbers update for 2014-05-25] Wireshark code review
15:25 [Wireshark-commits] master-1.8 6d2796f: [Automatic manuf, services and enterprise-numbers update for 2014-05-25] Wireshark code review
15:25 [Wireshark-commits] master-1.10 6fda9c8: [Automatic manuf, services and enterprise-numbers update for 2014-05-25] Wireshark code review
16:39 [Wireshark-commits] master c4ead25: GSM RLC MAC: Do not skip too many lines of the CSN_DESCR when the field is missing Wireshark code review
18:12 [Wireshark-commits] master 08ce84e: Grab-bag of dead initializers and two actual bugs. Wireshark code review
18:25 [Wireshark-commits] master f8d6351: Fix [-Werror=clobbered] gcc warning Wireshark code review
19:34 [Wireshark-commits] master-1.12 a9298b8: GSM RLC MAC: Do not skip too many lines of the CSN_DESCR when the field is missing Wireshark code review
19:35 [Wireshark-commits] master-1.10 783d06d: GSM RLC MAC: Do not skip too many lines of the CSN_DESCR when the field is missing Wireshark code review
21:20 [Wireshark-commits] master 37d40eb: MAC LTE: fix dissection of Extended Power Headroom control element Wireshark code review
21:38 [Wireshark-commits] master-1.12 e5b7a95: MAC LTE: fix dissection of Extended Power Headroom control element Wireshark code review
23:34 [Wireshark-commits] master-1.12 97dc329: Fix [-Werror=clobbered] gcc warning Wireshark code review
May 26, 2014
12:20 [Wireshark-commits] master 26840fa: Replace manual string handling with strbuf Wireshark code review
12:21 [Wireshark-commits] master-1.12 8da17d1: Replace manual string handling with strbuf Wireshark code review
12:51 [Wireshark-commits] master-1.10 9008494: Permit "jumbo" allocations in emem Wireshark code review
19:38 [Wireshark-commits] master 70d67a2: Make packet-ieee80211.c a tiny bit less unreadable. <rant> This file is riddled with lots of magical flags causing the code to do one thing or another, and then in several cases with non-telling variable names (e.g. is_centrino). My absolute favourite is Wireshark code review
21:53 [Wireshark-commits] master 5dfdd2b: Optimize dissect_eth_common(): cache result of get_ether_name() Wireshark code review
23:15 [Wireshark-commits] master abed02a: Fix fencepost error in HTTP dissector Wireshark code review
23:16 [Wireshark-commits] master-1.12 7e44111: Fix fencepost error in HTTP dissector Wireshark code review
May 27, 2014
09:45 [Wireshark-commits] master 7527224: make satellite orbital position filterable Wireshark code review
11:20 [Wireshark-commits] master 5ff629e: CMake: Remove FeatureSummary.cmake and fix display of feature Wireshark code review
11:33 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
11:46 [Wireshark-commits] master 281616f: Fix build on my old Windows XP Buildbot (With VS2008EE) (Try 2...) Wireshark code review
15:13 [Wireshark-commits] master 0911ce1: make the satellite symbol rate filterable Wireshark code review
20:56 [Wireshark-commits] master 3ce020a: ssl-utils: fix TLS number of padding extension Wireshark code review
21:21 [Wireshark-commits] master 9c98f9f: make cable frequency filterable Wireshark code review
21:42 [Wireshark-commits] master b3008f3: make cable symbol rate filterable Wireshark code review
21:42 [Wireshark-commits] master b4fb165: use proto_tree_add_float_format_value() correctly Wireshark code review
22:02 [Wireshark-commits] master cc3931c: FIELDDISPLAY can be or'd with BASE_VAL64_STRING. Wireshark code review
23:52 [Wireshark-commits] master-1.12 7477e31: bugfix address handling Wireshark code review
23:53 [Wireshark-commits] master-1.10 be1f44b: bugfix address handling Wireshark code review
23:55 [Wireshark-commits] master 1b439df: Use proto_tree_add_format_text() Wireshark code review
23:58 [Wireshark-commits] master eb1bbb6: Fix indent (use tabs) Wireshark code review
May 28, 2014
00:02 [Wireshark-commits] master c3b2b54: Fix indent (use 4 spaces) Wireshark code review
00:25 [Wireshark-commits] master 0701d61: Add EtherNet/IP connection conversation filters Wireshark code review
05:54 [Wireshark-commits] master 482e6a6: LLDP Cleanup : 802.1 Qbg TLV Wireshark code review
07:47 [Wireshark-commits] master-1.12 029c11c: LLDP Cleanup : 802.1 Qbg TLV Wireshark code review
07:48 [Wireshark-commits] master-1.12 6c4889c: ssl-utils: fix TLS number of padding extension Wireshark code review
08:51 [Wireshark-commits] master 9cd3c5c: glusterfs: show filenames in the summary for common procedures Wireshark code review
12:36 [Wireshark-commits] master 9d77e7c: QIcon is not needed. Wireshark code review
14:33 [Wireshark-commits] master 925b48e: Clang complains about the size of empty structs. Wireshark code review
15:15 [Wireshark-commits] master 6dabe12: Commit 5ff629ec5ac636b901b2a004aa4d5248f68a5d0f requires the minimum cmake version to be 2.8.3. Make this explicit. Wireshark code review
15:18 [Wireshark-commits] master 76cabf3: Try to fix Ubuntu buildbot (make dist failed) Wireshark code review
15:27 [Wireshark-commits] master 4467e02: packet-ppcap.c: Minor cleanup Wireshark code review
15:30 [Wireshark-commits] master e570507: packet-klerberos.c: Use typedef (true_false_string) to properly define a true_false_string. Wireshark code review
15:40 [Wireshark-commits] master 48ce562: Minor: use VALS macro (as per convention); Add editor modelines; Do whitespace changes. Wireshark code review
17:01 [Wireshark-commits] master 74774fd: Update reference for I-Bit support. Also remove the reference to the original ID. Change-Id: I51357fc04699a40af2d34ec2bd36518d09d3b180 Reviewed-on: https://code.wireshark.org/review/1848 Reviewed-by: Michael Tüxen <tuexen@xxxxxxxxxxxxx> Wireshark code review
17:46 [Wireshark-commits] master a192e47: Use Q_UNUSED instead of _U_ Wireshark code review
20:48 [Wireshark-commits] master d817b27: Update m3ap.cnf to match packet-m3ap.c change done in commit b40cb1ad Wireshark code review
21:47 [Wireshark-commits] master 40a21bc: packet-kerberos.c: Use tfs_set_notset in hf[] entry instead of a local version. Wireshark code review
23:41 [Wireshark-commits] master 56d8ff6: Add Modelines Wireshark code review
23:43 [Wireshark-commits] master bb78e8f: Add Modelines and use tabs and fix typo Wireshark code review
May 29, 2014
01:15 [Wireshark-commits] master 0ed2672: Try to fix the problems with the SPNEGO negTokenInit differences in Microsoft implementations Wireshark code review
01:19 [Wireshark-commits] master 88a64b9: Improve the fix by removing code that miss dissects SPNEGO stuff ... as well as remove redundant stuff from the spnego.cnf file. Wireshark code review
09:35 [Wireshark-commits] master ababf68: Have the protocol item cover only the PEEKREMOTE header. Wireshark code review
09:35 [Wireshark-commits] master-1.12 42e8515: Have the protocol item cover only the PEEKREMOTE header. Wireshark code review
11:21 [Wireshark-commits] master 2fa5996: glusterfs: if filename itself will become <EMPTY> Wireshark code review
16:38 [Wireshark-commits] master f7b1607: Bugfix EIP explicit connection conversation and allow ForwardClose to not be present in capture for generated filter to work properly. Wireshark code review
17:29 [Wireshark-commits] master 254e227: dissect more components of the track header box Wireshark code review
17:30 [Wireshark-commits] master 91dac27: conver sat freq and symbol rate into doubles in order to make the filtering work, fix typos Wireshark code review
17:30 [Wireshark-commits] master 7aecd47: convert cable freq, symbol rate into doubles Wireshark code review
17:32 [Wireshark-commits] master 357b610: start a dissector for GDB's remote serial protocol Wireshark code review
17:35 [Wireshark-commits] master 8b6c4e7: add gdb to the list of new protocols Wireshark code review
17:57 [Wireshark-commits] master 21a1208: Introduce 802.11 dissectors with wired-in "FCS present" indications. Wireshark code review
17:57 [Wireshark-commits] master-1.12 5e3b7ec: Introduce 802.11 dissectors with wired-in "FCS present" indications. Wireshark code review
18:17 [Wireshark-commits] master-1.12 c706276: Revert "MAC LTE: fix dissection of Extended Power Headroom control element" Wireshark code review
18:18 [Wireshark-commits] master-1.12 c813024: Grab-bag of dead initializers and two actual bugs. Wireshark code review
18:19 [Wireshark-commits] master-1.12 2e41a53: MAC LTE: fix dissection of Extended Power Headroom control element Wireshark code review
18:23 [Wireshark-commits] master-1.12 cb26f37: Clang complains about the size of empty structs. Wireshark code review
19:03 [Wireshark-commits] master-1.12 fe38765: FIELDDISPLAY can be or'd with BASE_VAL64_STRING. Wireshark code review
May 30, 2014
08:03 [Wireshark-commits] master 8515bd7: avoid proto_tree_add_uint_format() when we just want the default description Wireshark code review
08:47 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
11:22 [Wireshark-commits] master 7882284: Bluetooth: Fix Content Protection call for VDP Wireshark code review
11:24 [Wireshark-commits] master 32e66a4: Bluetooth: Add music duration info for SBC Wireshark code review
11:25 [Wireshark-commits] master 2abc541: Bluetooth AVDTP/RTP: Separate the streams Wireshark code review
11:25 [Wireshark-commits] master e3473c9: Bluetooth: AVDTP: Upgrade session logic Wireshark code review
11:25 [Wireshark-commits] master 5742d2e: Bluetooth: L2CAP: Another fix for CIDs Wireshark code review
11:26 [Wireshark-commits] master 53c66a9: Bluetooth: Avoid using macro GPOINTER_TO_UINT() Wireshark code review
11:26 [Wireshark-commits] master 49cc957: Bluetooth: AVDTP: Add support for APT-X configuration Wireshark code review
11:27 [Wireshark-commits] master 1258ce7: Bluetooth: AVDTP: First step to fully support AVDTP session Wireshark code review
11:49 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
12:47 [Wireshark-commits] master aff3807: cmake: Not all system have HtmlViewer Wireshark code review
12:48 [Wireshark-commits] master 7bf49b3: Set PLUGIN_INSTALL_DIR properly for wireshark.pc Wireshark code review
13:08 [Wireshark-commits] master a1656bc: fix packet-btavdtp.c: In function 'dissect_bta2dp': packet-btavdtp.c:2796:36: error: 'sep_data.vendor_codec' may be used uninitialized in this function [-Werror=maybe-uninitialized] packet-btavdtp.c:2799:12: error: 'sep_data.vendor_id' may be used uninitialized in this function [-Werror=maybe-uninitialized] Wireshark code review
13:14 [Wireshark-commits] master 9182126: Detect multiple MAUSB Packets in a single TCP packet Wireshark code review
13:16 [Wireshark-commits] master 75531b6: EPL: Duplicated frames Wireshark code review
13:36 [Wireshark-commits] master 5c6403b: Honor configured CMAKE_INSTALL_LIBDIR when installing libraries Wireshark code review
13:36 [Wireshark-commits] master 7c1171f: Fix wireshark.pc install destination Wireshark code review
13:59 [Wireshark-commits] master c04b529: cmake: Add feature info for SBC Wireshark code review
14:20 [Wireshark-commits] master a7a4aa9: ssl: add SslSession structure Wireshark code review
14:20 [Wireshark-commits] master 00251ed: dtls: use SslSession Wireshark code review
14:20 [Wireshark-commits] master 13e4f77: ssl: use SslSession Wireshark code review
14:46 [Wireshark-commits] master-1.12 ad64632: Bump .so versions for 1.12 in CMake builds, too Wireshark code review
16:31 [Wireshark-commits] master 9f0419d: make local time offset filterable Wireshark code review
16:31 [Wireshark-commits] master bc3ab61: make next time offset filterable Wireshark code review
17:21 [Wireshark-commits] master 419ea28: make terrestrial centre frequency filterable Wireshark code review
17:54 [Wireshark-commits] master 584b813: ssl-utils: dissect the certificate type TLS extension Wireshark code review
17:55 [Wireshark-commits] master a8e6d12: ssl/dtls: add support for Raw Public keys Wireshark code review
20:01 [Wireshark-commits] master d84b683: Add AMQP listening port option to preferences Wireshark code review
20:48 [Wireshark-commits] master 60daeba: Use tcp_info_append_uint() more Wireshark code review
May 31, 2014
05:07 [Wireshark-commits] master c91dd11: Split off the dissectors for 802.3 "slow protocols". Wireshark code review
05:27 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
05:56 [Wireshark-commits] master 2af61db: Fix (legitimate) compiler warning. Wireshark code review
06:08 [Wireshark-commits] master 5672da8: Add a copyright/idempotency wrapper. Wireshark code review
09:04 [Wireshark-commits] master 877f38b: make population id filterable Wireshark code review
09:28 [Wireshark-commits] master 7999724: We need a "wlan_datapad" dissector as well. Wireshark code review
13:01 [Wireshark-commits] master 5315416: Move cpuid to seperate header file. Wireshark code review
13:11 [Wireshark-commits] master 62fd14c: Add nghttp2 lib (HPACK) Wireshark code review
13:18 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
13:26 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
13:32 [Wireshark-commits] master 3ec1ec1: do a plausibility check for interaction channel data in the linkage descriptor Wireshark code review
13:49 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
14:01 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
14:15 [Wireshark-commits] master c4aa524: NGHTTP2: fix typo (nghttp2_ent.h => nghttp2_net.h) Wireshark code review
14:20 [Wireshark-commits] master 41c78af: NGHTTP2: fix -Wshadow about index with some old GCC release or Mac OS X buildbot Wireshark code review
14:53 [Wireshark-commits] master 33fc5c0: NGHTTP2: Add missing nghttp2_int.h (need by make dist...) Wireshark code review
15:01 [Wireshark-commits] master 173e302: nghttp2: upgrade library to g4f7223e and add casts to please buildbots Wireshark code review
15:20 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:30 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
15:35 [Wireshark-commits] master 158dd9c: nghttp2: more warning fixes Wireshark code review
15:49 [Wireshark-commits] master 09816dd: nghttp2: do not copy nghttp2* objects in wsutil folder Wireshark code review
18:33 [Wireshark-commits] master af10e83: HTTP2: Showing decompressed headers Wireshark code review
18:39 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
18:45 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
19:00 [Wireshark-commits] master a92d6bd: HTTP2: try to please OSX 10.6 x64 buildbot Wireshark code review
22:07 [Wireshark-commits] master 7c68a8e: Move the definitions of OUI value_strings to epan/oui.c. Wireshark code review

Mail converted by MHonArc