Wireshark-bugs: [Wireshark-bugs] [Bug 11152] Wireshark decodes some valid RTP packets as STUN pa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 04 Jul 2015 14:56:03 +0000

Comment # 10 on bug 11152 from 
(In reply to Michael Mann from comment #9)
> I don't want to hijack this bug, but I looked at the suggested changes. 
> Would it make more sense to have a "global" list of heuristic dissectors
> rather than have individual preferences in individual dissectors?  We have a
> global list for dissectors in general, but I guess uses may want to
> differentiate disabling a protocol from disabling a heuristic.

Yeah I was wondering the same thing when I was making the code changes. I
thought maybe it wasn't possible to have a generic common way to disable/enable
heuristic dissectors, but looking at them it sure looks like it should be.

But it's not completely trivial to do so, because some/many of them need to be
disabled by default, and the way they've done that in code is inconsistent; so
I'd have to go through each protocol that has a heuristic and verify what it
does. And arguably the heur_dissector_add() should be changed to take a boolean
of whether it should be enabled/disabled by default.

There are ~200 protocols that add a heuristic dissector, so it's a big job but
not insurmountable. Maybe we should take this to the dev list?

You are receiving this mail because:
  • You are watching all bug changes.