Wireshark-bugs: [Wireshark-bugs] [Bug 3290] TRY_TO_FAKE_THIS_ITEM disables bounds errors
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 17 Apr 2014 20:34:30 +0000

Comment # 38 on bug 3290 from 
(In reply to comment #35)
> (In reply to comment #34)
> > Does this still deserve to be In Progress? I think it can be marked as fixed
> > now, and the remaining stale patches denied?
> 
> Well keep in mind that so far only proto_tree_add_item() and
> proto_tree_add_bits_item() are protected; the other proto_tree_add_XXX()
> APIs are not.
> 
> Though, OTOH, I guess those other APIs are (in the common case) protected
> because the thing's value you're adding to the tree has (presumably) already
> been fetched with tvb_get_XXX().  Maybe the others don't really need
> protection...

Bug 9983 just showed that dissectors don't necessarily fetch their FT_BYTES
before calling proto_tree_add_bytes*().

You are receiving this mail because:
  • You are the assignee for the bug.
  • You are watching all bug changes.