Wireshark-bugs: [Wireshark-bugs] [Bug 9610] USB: Add DFU dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 07 Jan 2014 23:42:59 +0000

changed bug 9610

What Removed Added
Attachment #12411 Flags review_for_checkin? review_for_checkin+

Comment # 6 on bug 9610 from 
Comment on attachment 12411 [details]
[PATCH 2/3] USB: Dissect Application-specific Interface
Class/Subclass/Protocols

Thanks, committed in r54640.

Though I would note that you're use of extended value strings is probably
excessive. When the value-string contains very few elements I would expect the
extended version to actually be slower just because of the additional logic and
pointers involved internally. I typically reserve extended value strings for
cases involving many elements, though admittedly I've never benchmarked
anything.

You are receiving this mail because:
  • You are watching all bug changes.