Wireshark-bugs: [Wireshark-bugs] [Bug 9444] Add initial parameter parser for commands in RTPprox
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 26 Nov 2013 12:08:47 +0000

Comment # 3 on bug 9444 from 
(In reply to comment #2)

> - paramtypenames[] value_string array lacks a {0, NULL} at the end

Done!

https://github.com/lemenkov/wireshark/commit/8708e34

> - rtpptoxy_add_parameter should be renamed to rtpproxy_add_parameter I guess
> :)

Yes. definitely :)

https://github.com/lemenkov/wireshark/commit/d217456

> - I'm not a big fan of recursive functions. Could we do a loop that calls
> rtpproxy_add_parameter several times and do the "if(realsize == 0) return;"
> check outside of the function (in the loop) instead? Moreover it might be
> better to do a <= 0 check in case offset ends being bigger than realsize
> because of a malformed packet (did not check closely whether it could happen
> or not).

Fixed that. Also it checks for realsize =< 0 (in a slightly different manner)

https://github.com/lemenkov/wireshark/commit/083749a

A combined patch will follow shortly.

You are receiving this mail because:
  • You are watching all bug changes.