Wireshark-bugs: [Wireshark-bugs] [Bug 9424] Implement ZigBee Green Power dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 19 Nov 2013 16:07:13 +0000

Comment # 6 on bug 9424 from 
(In reply to comment #5)
> New patch for ZigBee Green Power will be reattached as soon as possible.
> ZigBee security fix will be provided as a separated patch.
Thanks,

> 
> Could you please explain why it's better to use proto_tree_add_item instead
> of proto_tree_add_unit whenever possible?
No need to declare local variable or use tvb_get_*

> 
> And is it necessary to increment offset after each proto_tree_add_*
> according to Wireshark code conventions?
it is preferred

You are receiving this mail because:
  • You are watching all bug changes.