Wireshark-bugs: [Wireshark-bugs] [Bug 8961] Enhancement: Add dissector for the STANAG 4607 GMTIF
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 30 Jul 2013 18:42:43 +0000

changed bug 8961

What Removed Added
Attachment #11258 is obsolete   1

Comment # 3 on bug 8961 from 
Created attachment 11304 [details]
STANAG 4607 dissector patch

Attached revised patch; addresses all comments.

Thanks Evan, I believe I fixed everything you mention. Most notable: the Dxx
are field names, and although they correspond to bit positions, the numbering
for them is offset (it starts with D2 for bit 0)  (I did review these, and,
amazingly, I did find an error in my code).

I was tempted to create (but didn't) a short macro to shorten the repetitive
proto_tree_add_item() calls (a side effect being that these could now fit into
80 columns instead of spilling over). Should I have?

You are receiving this mail because:
  • You are watching all bug changes.