Wireshark-bugs: [Wireshark-bugs] [Bug 8891] (patch) KDSP dissector calls ieee80211 instead of ra
Date: Mon, 08 Jul 2013 10:31:26 +0000

Comment # 4 on bug 8891 from
Comment on attachment 11142 [details]
kdsp improvements + using proto_tree_add_expert

+      payload_len = (length + FRAME_HEADER_LEN) - offset;
+      if (cptbitmap & DATA_PACKLEN_FLAG) {
+        payload_tvb = tvb_new_subset(tvb, offset, payload_len,
reported_payload_len);
+        if (cptbitmap & DATA_DLT_FLAG) {
+          if (datalink_type == DATALINK_RADIOTAP) {
+            call_dissector(radiotap_handle, payload_tvb, pinfo, tree);
+            col_set_str(pinfo->cinfo, COL_PROTOCOL, "KDSP");
+          } else {
+            proto_tree_add_expert_format(sub_tree, pinfo,
&ei_kdsp_encoding_note, tvb, offset, payload_len,
+              "Datalink type unknown, can not parse.");
+          }
+        } else if (payload_len > 0) {
+          proto_tree_add_expert_format(sub_tree, pinfo,
&ei_kdsp_encoding_error, tvb, offset, payload_len,
+            "Payload expected but no link type specified. Can not decode.");
+        }
+      } else if (payload_len > 0) {
+        proto_tree_add_expert_format(sub_tree, pinfo, &ei_kdsp_encoding_error,
tvb, offset, payload_len,
+          "No payload expected but found some data.");

About this code, it is not possible to use : 
                if (!dissector_try_uint(wtap_encap_dissector_table, dlt,
                            tvb, pinfo, parent_tree)) {
(from epan/dissectors/packet-frame.c)

Because i try will some other kismet packet (from Bug 6953) and it is display
"unknown DLT..."


You are receiving this mail because:
  • You are watching all bug changes.