Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8718] ZigBee ZCL Identify cluster not managed

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 40 on bug 8718 from Evan Huus

Thanks for the patch, committed in r50229.

I noticed a few oddities I thought I'd ask about, although none of them are at
all serious.

There's one place where you do:
  raw_time = tvb_get_letohs(tvb, *offset);
  raw_time = (raw_time << 8) | (raw_time >> 8);
which I think is just a more complicated way of doing tvb_get_ntohs?

In a few places you check a var for 0 before looping over it:
  if (var != 0) {
    for (i=0; i<var; i++) {
    }
  }
which is unnecessary, since the loop should never run if the var is 0.

And finally, the parameter list of proto_register_zbee_zcl_appl_ctrl is
formatted oddly.

Yes, I'm being really picky now :)

---

      You are receiving this mail because:

• You are watching all bug changes.