Wireshark-bugs: [Wireshark-bugs] [Bug 8740] Bluetooth: Improve HFP dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 09 Jun 2013 19:45:11 +0000

Comment # 6 on bug 8740 from 
Current patch is generally fine, just a few minor points:

Bleeding-edge GCC complains as follows:
packet-bthfp.c: In function 'dissect_at_command':
packet-bthfp.c:1067:76: error: 'type' may be used uninitialized in this
function

The following code appears a lot, make it a macro or a functions?
   val = (guint8 *) wmem_alloc(wmem_packet_scope(), parameter_length + 1);
   memcpy(val, parameter_stream, parameter_length);
   val[parameter_length] = '\0';
   value = g_ascii_strtoull(val, NULL, 10);

Cheers,
Evan

You are receiving this mail because:
  • You are watching all bug changes.