Wireshark-bugs: [Wireshark-bugs] [Bug 8416] New: remove C++ incompatibilities from packet-pw-atm
| Bug ID |
8416
|
| Summary |
remove C++ incompatibilities from packet-pw-atm.c
|
| Classification |
Unclassified
|
| Product |
Wireshark
|
| Version |
SVN
|
| Hardware |
x86
|
| OS |
All
|
| Status |
UNCONFIRMED
|
| Severity |
Enhancement
|
| Priority |
Low
|
| Component |
Wireshark
|
| Assignee |
bugzilla-admin@wireshark.org
|
| Reporter |
beroset@mindspring.com
|
Created attachment 10140 [details]
patch to remove C++ incompatibilities from packet-pw-atm.c
Build Information:
FIX: packet list heading menu sensitivity
wireshark 1.9.1 (SVN Rev 47936 from /trunk)
Copyright 1998-2013 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled (64-bit) with Qt 4.8.4 with GLib 2.32.4, with libpcap, with libz
1.2.5,
with POSIX capabilities (Linux), without libnl, without SMI, without c-ares,
without ADNS, with Lua 5.1, without Python, with GnuTLS 2.12.20, with Gcrypt
1.5.0, with MIT Kerberos, without GeoIP, without PortAudio, with AirPcap.
Running on Linux 3.7.6-102.fc17.x86_64, with locale en_US.utf8, with libpcap
version 1.2.1, with libz 1.2.5, GnuTLS 2.12.20, Gcrypt 1.5.0, without AirPcap.
Intel(R) Core(TM) i5-2540M CPU @ 2.60GHz
Built using gcc 4.7.2 20120921 (Red Hat 4.7.2-2).
--
To clean up parts of Wireshark and to make it compatible with C++ compilers, a
few small changes were made. First, implicit casts were made explicit and
second, a structure member that had been declared as (essentially) an enum type
was changed to be an int type. The rationale is that there are a number of
places in the code where we do math on the pd.props field (such as "pd.props |=
PWC_PAY_SIZE_BAD;") even though the result might or might not be a valid enum
as defined in pwc_packet_properties_t. For that reason, the type is already
being used as an int rather that a true enum, and the pwc_packet_properties_t
is just being used as a convenient grouping of constants.
You are receiving this mail because:
- You are watching all bug changes.
