Wireshark-bugs: [Wireshark-bugs] [Bug 8275] Basic dissector: FIPA/ACL Message protocol over TCP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 18 Feb 2013 17:29:24 +0000

Comment # 11 on bug 8275 from 
(In reply to comment #10)
> Hi,
> 
> Thank you for your comments Evan.
> 
> (In reply to comment #8)
> > - You make a lot of use of manually-managed memory, via manual allocation
> > calls (g_new), data structures (GSList), and wireshark API calls
> > (tvb_get_string). That's usually discouraged, as it is much easier to avoid
> > leaks when using Wireshark's memory manager (see doc/README.malloc in 1.8,
> > or doc/README.wmem in trunk).
> 
> It shouldn't be too hard to use emem. I'll look into it.

For what it's worth, wmem is preferred for new code, but it's not a big deal.
Technically emem is deprecated in trunk, but only in the weakest sense, since
wmem isn't quite feature-compatible with it yet.

In general it's better to develop new dissectors against trunk since that's
where they will end up (we don't backport new dissectors to stable branches)
and since the API may have changed since the last stable release.

Cheers,
Evan

You are receiving this mail because:
  • You are watching all bug changes.