Wireshark-bugs: [Wireshark-bugs] [Bug 8112] MS-MMC dissector crash
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 22 Dec 2012 03:51:34 +0000

Comment # 8 on bug 8112 from 
one more thing: the code in question is

tool_version = tvb_get_ephemeral_unicode_string(tvb, offset,
                                                tool_version_length*2,
                                                ENC_LITTLE_ENDIAN);

proto_tree_add_string(tree, hf_msmms_command_tool_version, tvb,
                              offset, tool_version_length*2,
              format_text((guchar*)tool_version, tool_version_length));


tool_version is a UTF-8 string, i.e. a character can be encoded in one or more
bytes.

Looking at the code of format_text(), I can't see that this handles UTF-8
strings.

Should these two statements be replaced with 

proto_tree_add_unicode_string(..., tvb_get_ephemeral_unicode_string(...)) ?

(there's a number of similar code parts)

You are receiving this mail because:
  • You are watching all bug changes.