https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3884
Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |darkjames-ws@xxxxxxxxxxxx
--- Comment #14 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-08-10 15:23:46 PDT ---
(In reply to comment #13)
> (In reply to comment #11)
> > We might be able to work around the lack of packet_info mentioned in comment 4
> > by adding a packet_info * to tree_data_t and setting it in
> > proto_tree_create_root(). At that point the pinfo argument could be removed
> > from expert_*(). They could find the top-level tree item via pi->parent.
>
> Done in r44435, although it looks like we should keep pinfo in expert_*().
@@ -166,6 +166,10 @@ expert_set_info_vformat(packet_info *pinfo, proto_item
*pi,.
+ if (pinfo == NULL && pi->tree_data)
+ pinfo = PTREE_DATA(pi)->pinfo;
Gerald, does it work when dissecting without tree?
I'm afraid it will crash with NULL dereference (pi == NULL).
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
