Wireshark-bugs: [Wireshark-bugs] [Bug 7518] Add new dissector for DVB-S2 Baseband Frame and GSE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7518
--- Comment #5 from tru-j@xxxxxxxxxxxxxxxxx 2012-07-24 02:35:31 PDT ---
(In reply to comment #3)
Hi,
thanks a lot for the fast review. I will attach a new patch
(dvb-s2-bb_v2.patch).
> the code don't compile under Linux :
> packet-dvb-s2-bb.c: In function 'dissect_dvb_s2_bb':
> packet-dvb-s2-bb.c:659:17: error: 'gse_proto' may be used uninitialized in this
> function [-Werror=uninitialized]
> packet-dvb-s2-bb.c:564:22: note: 'gse_proto' was declared here
>
> Also 1 clang Warning :
> packet-dvb-s2-bb.c:851:9: warning: Value stored to 'byte' is never read
Unfortunately the code compiles error-free under my Debian but I have of course
fixed this points.
> About the code with CRC, there is some fucntion in epan/crc* it is not possible
> to use this function ?
For the Baseband Header CRC we need another polynomial generator (0xD5). The
"crc8-tvb" uses 0x07.
I have already an idea to write one universal crc function with the polynomial
generator as parameter. I will bring this idea to the dev-list and write a
patch separately later on.
> Why some time you use proto_tree_add_uint* (line 774, 782...) and use
> proto_tree_add_item ? (it is recommended to use proto_tree_add_item)
I have replaced all proto_tree_add_uint() with the _add_item() function.
I still need the proto_tree_add_uint_format() function for the formated display
of some values.
> There is also a mistake in patch from CMake (epan/CMakeList.txt) wrong filename
Fixed.
Thanks a lot again,
Best Regards - Tobias
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
