Wireshark-bugs: [Wireshark-bugs] [Bug 6995] Implementing dissector for PCEP extension according
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6995
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff.morriss.ws@xxxxxxxxx
--- Comment #3 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2012-03-26 18:23:51 PDT ---
There's too many proto_tree_add_text()'s in here. Stuff like this:
+ variance_processing_time = tvb_get_ntohl(tvb, offset2+20);
+ proto_tree_add_text(pcep_object_tree, tvb, offset2+20, 4, "Variance
processing time: %u ms^2", variance_processing_time);
should be rewritten into just a proto_tree_add_item() call (unless of course
the fetched value needs to be used for other processing--which it isn't in at
least the quoted case).
Stuff like this:
+ if (obj_length < OBJ_HDR_LEN+MONITORING_OBJ_MIN_LEN) {
+ proto_tree_add_text(pcep_object_tree, tvb, offset2, obj_length,
+ "Bad MONITORING object length %u, should be >= %u", obj_length,
+ OBJ_HDR_LEN+MONITORING_OBJ_MIN_LEN);
should be rewritten into expert info's.
I could let the latter case slide since the rest of the dissector is written
like that, but the protocol stuff really should be made filterable.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
