Wireshark-bugs: [Wireshark-bugs] [Bug 6950] openSAFETY - Malformed packets disable the dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 15 Mar 2012 05:20:26 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6950

Roland Knall <rknall@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8020|                            |review_for_checkin?
              Flags|                            |

--- Comment #5 from Roland Knall <rknall@xxxxxxxxx> 2012-03-15 05:20:25 PDT ---
Created attachment 8020
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8020
Guards the calledOnce boolean, against malformed traps.

The repeated calling of a dissector is necessary to dissect the openSAFETY
packages correctly. This leads to an issue, where if one call gets interrupted
due to a development error in the dissector itself, the mechanism for
preventing multiple wrong calls to the dissector get's interrupted, and no
further openSAFETY dissection is possible. 

This patch capsulates all expert_info calls, and add's an additional guard for
preventing unintentionally disabling the dissector.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.