Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6887] Patch for wireshark to support IEEE 1722.1 packets

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6887

tom.bottom@xxxxxxxxxxxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7925|0                           |1
        is obsolete|                            |
   Attachment #7932|                            |review_for_checkin?
              Flags|                            |

--- Comment #4 from tom.bottom@xxxxxxxxxxxxxxxxxxxx 2012-03-01 11:38:54 PST ---
Created attachment 7932
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7932
Patch revision 2

Added packet-ieee17221.c to epan/CMakeLists.txt
Removed hf_aem_sf_subtype
Changed c++ style comments to c style

Changed 
+        switch (subtype)
+        {
+            case 0x7A:
+            {
+                if (dissector_try_port(avb_dissector_table, 0x7A, tvb, pinfo,
tree))
...

to
+        if (dissector_try_port(avb_dissector_table, subtype, tvb, pinfo,
tree)) return;


The pinfo = NULL assignments were there because when I first wrote the
functions I wasn't sure if I would need pinfo someday but wasn't using it yet.
They were just to keep the compiler from complaining about unused variables.
They were at the end so if I did use them I wouldn't forget they were NULL and
break things. I will remove them once the final spec is approved if they turn
out to be unnecessary.

Currently running a fuzztest.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.