Wireshark-bugs: [Wireshark-bugs] [Bug 5769] BACnet who-is request device range values are not de
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 18 Jul 2011 19:40:32 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5769

--- Comment #3 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-07-18 19:40:31 PDT ---
(In reply to comment #2)
> (In reply to comment #1)
> After applying Michael's patch, a quick grep still shows at least 16 other
> fields being added to the protocol tree in little endian format.  I assume all
> these should be changed as well?  Affected fields:
> 
> hf_bacapp_invoke_id (2 occurrences)
> hf_bacapp_type (7 occurrences)
> hf_bacapp_pduflags
> hf_bacapp_SEG
> hf_bacapp_MOR
> hf_bacapp_SA
> hf_bacapp_NAK
> hf_bacapp_SRV (2 occurrences)

OK, I guess these fields are either FT_UINT8 or FT_BOOLEAN so the endian-ness
doesn't really matter.  Still, I dislike using TRUE since they're definitely
not little endian.  (Actually, I dislike ENC_NA too for the mere fact that it's
defined exactly the same as ENC_BIG_ENDIAN, so for protocols that are little
endian, it's too easy to "copy-and-paste" a proto_tree_*(..., ENC_NA) for a
field where endian doesn't matter to a field where it does matter but forget to
change ENC_NA to ENC_LITTLE_ENDIAN.)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.