Wireshark-bugs: [Wireshark-bugs] [Bug 5581] Support for additional fields in "Meta" protocol.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 18 Jan 2011 07:49:27 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5581

--- Comment #5 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2011-01-18 16:49:25 CET ---
(In reply to comment #4)
> No opinion of a core developer Wireshark?

This patch was made in the style of the existing code. Whatever you think of
the style (coding, indentation, etc), that is The Right Thing(sm). Consistency
trumps cleanup.
If cleanup is to be done, it has to go in its own patch.

> Note : the patch is not in review_for_checkin+

The bug was closed after commit, that dropped the attached patch from review
scope.
When the bug is reopened it is assumed the problem either is not fixed, or the
patch wasn't correct. Either way the patch is disputed, hence '?' is correct.

So, can we close this bug now?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.