Wireshark-bugs: [Wireshark-bugs] [Bug 4971] Enhancements to packet-ieee80211.c
Date: Mon, 5 Jul 2010 16:24:51 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4971

--- Comment #14 from Jouni Malinen <j@xxxxx> 2010-07-05 16:24:45 PDT ---
(In reply to comment #13)
> Well I'm not doing any 802.11 traces so I don't realy have a preference either.
> I just thougt that if you where filtering for a specific vendors subtype it
> would be easier with a vendor specific subtype filter + the code could do with
> a cleanup :-)

Filtering would be trivial with any of the methods mentioned so far for known
frames (e.g., just filter with oui==[OUI] && type==[type]). Vendor specific
handling could obviously make things cleaner in future, but it would require
more work for new IEs.

> A) Use the first patch

That would certainly be easiest for now.. ;-)

As far as cleaning up packet-ieee80211.c is concerned, there would certainly be
number of places that could use both small and large redesign.. I haven't yet
wanted to start working on this since I have no idea how many pending patches
people have on the file (the cleanup things I'm thinking of would likely
conflict with any such pending work) (and also, I don't really have too much
extra time available to do that cleanup either..).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.