Wireshark-bugs: [Wireshark-bugs] [Bug 4920] dissector/packet-batadv: Add support for v11 packet
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 1 Jul 2010 11:51:39 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4920

Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4841|review_for_checkin?         |review_for_checkin+
               Flag|                            |

--- Comment #2 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-07-01 14:51:37 EDT ---
(From update of attachment 4841)
Committed in SVN #33404

I've fixed what appears to be a copy/paste error:

...=ep_alloc(sizeof(struct batman_packet_v10));

which I changed to:
...=ep_alloc(sizeof(struct batman_packet_v11));

Speaking of copy/paste:

There appears to be much common, repeated code for each of the versions.

Please consider if it is possible to have less repeated code in some manner ?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.