Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3984] New: r29723 optimization, if (cinfo->col_data[col] != cinfo->col_buf[col

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984

           Summary: r29723 optimization,  if (cinfo->col_data[col] != cinfo-
                    >col_buf[col]) col_data is not always a constant
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: dgautheron@xxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Hi,

With col_set_str() cinfo->col_data[col] != cinfo->col_buf[col] and most of the
time it's either static memory, g_malloced or se_alloced memory, ie a constant
for the life of record->fdata->col_text.

But some dissectors still call col_set_str with ep_alloced memory (via
val_to_str)
cf. at least
packet-icmp.c
packet-wow.c


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.