Wireshark-bugs: [Wireshark-bugs] [Bug 2263] new wireshark dissector for SERCOS III (ethertype 0x
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 13 Feb 2008 13:42:34 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2263


Jaap Keuter <jaap.keuter@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1459|                            |review_for_checkin-
               Flag|                            |




--- Comment #1 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-02-13 13:42:33 GMT ---
(From update of attachment 1459)
I've a number of remarks:
Can't you distclean before dumping all intermediate files into a patch?
gmodule.h has no place in packet-sercos.c.
Does it need to be a plugin?
C++ style comments are a nono.
unused function parameters are tagged by _U_ instead of self assignment.
Please use meaningful labels i.s.o. constants.
Did you fuzztest it?


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.