Wireshark-bugs: [Wireshark-bugs] [Bug 1945] New: The bootp/dhcp v4 dissector doesn't decode all
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 27 Oct 2007 12:15:09 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1945

           Summary: The bootp/dhcp v4 dissector doesn't decode all relay
                    suboptions
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: stefan.puiu@xxxxxxxxx


Build Information:
wireshark SVN version 23284. 
--
While examining a capture file that was using DHCP relay suboption 6 (see
RFC3993), I noticed that wireshark was printing "invalid agent option" for the
suboption 6 part. I decided to look at the code in
epan/dissectors/packet-bootp.c and noticed that 0.99.6 only handles suboptions
1 and 2 (circuit ID and remote ID), and treats all others as invalid. The SVN
code handles suboption 9, and that's it. 

According to http://www.iana.org/assignments/bootp-dhcp-parameters, suboptions
from 1 to 10 have been defined. 3 is reserved, and most of the others have
their own RFC. For a start I've attached a patch that decodes suboption 6 just
as 1 and 2, and also suboption 3. This might not be entirely correct, since
suboptions 1 and 2 are opaque values (RFC3046), while 6 is an ASCII text
string.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.