Wireshark-bugs: [Wireshark-bugs] [Bug 1179] cmake build integration + dbus + bunch of memleak fi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 26 Oct 2006 12:24:22 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1179





------- Comment #20 from frederic.heem@xxxxxxxxx  2006-10-26 12:24 GMT -------
(In reply to comment #19)
> I.e., the change isn't being put in because it didn't compile without the
> changes, it's being put in because it might, in the future, not compile without
> the changes.
> 
> BTW, why is the full dbus patch doing
> 
> -/** Stop a low-level capture (stops the capture child). */
> -extern void capture_loop_stop(void);
> +/** Stop all captures (stops the capture child). */
> +extern void capture_loop_stop();
> 
> That changes a declaration that says "capture_loop_stop() takes no arguments"
> to one that says "capture_loop_stop() takes an unknown number of arguments",
> and thus disables compile-time checking of calls to capture_loop_stop().
> 
I can't even remember why it has been changed, this is a mistake.
extern void capture_loop_stop(void) has to be used.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.