Wireshark · Ethereal-users: Re: [Ethereal-users] TCP States

[Guy Harris <gharris@xxxxxxxxx>]

Ulf Lamping wrote:

> Do you mean adding a new field or change the existing one to a text 
> based field?
Neither.  I mean making "ipproto_val[]" not static, declaring it in 
"epan/ipproto.h", and changing the line for "ip.proto" to replace NULL 
with VALS(ipproto_val) (at the same time we change it to use BASE_DEC 
rather than BASE_HEX).
> Anyway, the handling of the hf_ip_proto field seems a bit odd.
Yup - but part of that is that we're using "ipprotostr()" to handle IP 
protocols *not* listed in the value-string table, as well as those that are.
One could, however, argue that any protocol likely to be in the 
protocols database on a system should also be in the value-string table, 
as they should be listed in the protocol-numbers list I mentioned; in 
that case, there's no need to use "proto_tree_add_uint_format()" for 
that field.