Ethereal-dev: Re: [ethereal-dev] DNS dissector and infinite-loop

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Thu, 7 Oct 1999 00:54:08 -0700
> Could be - "get_dns_name()" doesn't do any checks to make sure the stuff
> it's looking at is inside the packet.  Unfortunately, to do that takes a
> bit more work, as offsets aren't passed into a number of the DNS
> dissection routines; I'm looking at that.

OK, I've checked changes in to do more packet bounds-checking for DNS,
as well as propagating those changes and Gilbert's changes to
"packet-nbns.c".

It seems to be able to dissect the DNS and NetBIOS-over-TCP packets on
which I tried it, and manages not to blow up when handed Gilbert's
random-DNS packet.

There's probably more checking to be done, though.