Ethereal-dev: Re: [ethereal-dev] Some more patches to ethereal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Mon, 04 Oct 1999 22:29:33 -0500
On Sat, Oct 02, 1999 at 12:29:39AM -0700, Guy Harris wrote:
> > Here's a small patch which fixes a SEGV dumper, and makes the previous
> > color to be the default for the color chooser.
> 
> The patch includes:
> 
> 	a patch to "dfilter.c" that is currently in the CVS tree
> 	(Gilbert checked that one in as a fix to the problem you
> 	reported earlier);
> 
> 	a patch to "file.c" that causes it to exit if the search through
> 	the list of packets for a packet that's on a given row in the
> 	display doesn't find the packet;
> 
> 	the changes to the color stuff.
> 
> What's the situation in which the patch to "file.c" fixes a SEGV? 

I think the SEGV that Santeri mentioned in his e-mail was the previous
fix that he posted, the one that I already checked in.

Other than that, there should be no SEGV problem.

> Perhaps there's an underlying bug wherein a bogus row number is being
> passed to "select_packet()".

I'm going to change the file.c change to a g_assert() to try to
catch that problem if it does occur. Santeri: did you see a problem
that you attempted to fix with the patch to file.c?

--gilbert